Commit Graph

162 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
556594b4cd
Fix coding standard spacing issues
- Fixes one line doc comments
- Fixes parent call spacing
- Fixes constant spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-24 21:06:17 -03:00
Maurício Meneghini Fauth
77957a69a5
Add trailing comma for multi-line functions
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-24 20:48:46 -03:00
Kamil Tekiela
902d1a1e77
Add native return type hints (#18126)
* Add remaining native return type hints to flush out bugs

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast the mixed value to int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix tests

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* getAutoIncrement() is supposed to return string

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast values to string in DummyResult

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Make getCollation() return non-nullable string

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast seqInIndex to int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast $cardinality to int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* createFile may return false

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove redundant cast

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update baselines

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-02-23 15:43:36 -03:00
Maurício Meneghini Fauth
4ff3724c3f
Use union with null instead of short nullable type
Since union type are now possible, using union with null makes more
clear that it is a union type.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-20 21:48:19 -03:00
Maurício Meneghini Fauth
613678f8f5
Replace assignments with null coalesce equal operator
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-20 17:03:05 -03:00
Maurício Meneghini Fauth
26b5860484
Merge pull request #18089 from kamil-tekiela/first-class-callable
Convert to first class callables
2023-02-14 17:36:13 -03:00
Kamil Tekiela
b6f0da1c09 Convert to first class callables
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-02-14 14:18:23 +00:00
Kamil Tekiela
87e42d591c Use short closures where possible
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-02-14 13:44:42 +00:00
Kamil Tekiela
dd699f348d Clean up LIKE escaping
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-11-25 00:06:52 +00:00
William Desportes
25c13d667b
Merge branch 'QA_5_2'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-10-26 12:22:38 +02:00
Mo Sureerat
aeab8a1c41
Fix #17793 - insert UUID (#17797)
* Add/Change table schema - Add UUID in default options
* Insert/Update - Generate uuid only not defined and not check null option
* Add/Change table schema - Hide UUID from default options if database not support & add unit test

Fix #17793

Signed-off-by: Mo Sureerat <sureemo@gmail.com>
2022-10-20 15:57:53 -03:00
Kamil Tekiela
f835485588 Remove remaining bits of Sanitize::jsFormat
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-17 21:31:07 +01:00
Kamil Tekiela
bd287cf79e Remove custom Twig escape_js_string filter
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-17 21:31:07 +01:00
Rodrigo Pokemaobr
556804c4e2 Removing get tables from twig template and removing relationextension from twig template
Signed-off-by: Rodrigo Pokemaobr <contato@pokemaobr.dev>
2022-05-31 16:22:46 -03:00
Rodrigo Pokemaobr
547f89996f Removing Foreign Data from Twig
Signed-off-by: Rodrigo Pokemaobr <contato@pokemaobr.dev>
2022-05-24 16:17:04 -03:00
Rodrigo Pokemaobr
d5585c3104 Removing search columns in foreigners from twig
Signed-off-by: Rodrigo Pokemaobr <contato@pokemaobr.dev>
2022-05-24 15:34:55 -03:00
Rodrigo Pokemaobr
228fde03ee Removing get display field function on twig template
Signed-off-by: Rodrigo Pokemaobr <contato@pokemaobr.dev>
2022-05-24 14:38:49 -03:00
Rodrigo Pokemaobr
5ce4fe0b49 Removing foreign dropdown from twig functions
Signed-off-by: Rodrigo Pokemaobr <contato@pokemaobr.dev>
2022-05-17 16:35:35 -03:00
Maurício Meneghini Fauth
5950693fb3
Fix possible undefined globals
Related to https://github.com/phpmyadmin/phpmyadmin/pull/17427.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-10 18:05:21 -03:00
Maurício Meneghini Fauth
1438cb211e
Replace global keyword with $GLOBALS
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-07 17:31:11 -03:00
Maurício Meneghini Fauth
c411121fd8
Move Relation classes into the ConfigStorage namespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-17 12:09:13 -03:00
Maurício Meneghini Fauth
fbd5b0a67c
Redesign the export/import pages to use Bootstrap components
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-11-25 13:37:47 -03:00
Maurício Meneghini Fauth
f00d70cccb
Remove useless whitespaces
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-15 17:05:40 -03:00
Maurício Meneghini Fauth
7a4536d4d6
Remove PhpMyAdmin\Twig\PluginsExtension class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-08-25 11:00:21 -03:00
William Desportes
f77433b9b7
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-28 01:37:17 +02:00
William Desportes
f013c6c7ed
Fix #14631 - Enum with comma produces incorrect search dropdown
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-07-28 00:32:16 +02:00
Maurício Meneghini Fauth
538d6e6127
Use array callable syntax for Twig extensions
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-19 16:36:17 -03:00
Maurício Meneghini Fauth
4dec56d883
Remove get_start_and_number_of_rows_panel() Twig function
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-17 17:56:34 -03:00
Maurício Meneghini Fauth
324dc2b95c
Merge pull request #16755 from mauriciofauth/util-gis
Extract GIS related methods from Util class
2021-03-22 16:43:29 -03:00
Maurício Meneghini Fauth
6a10449428
Merge branch 'QA_5_1'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-22 16:16:47 -03:00
Maurício Meneghini Fauth
54fc311a3f
Fix escape_mysql_wildcards Twig filter
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-22 16:14:51 -03:00
Maurício Meneghini Fauth
035e29a80b
Extract GIS related methods from Util class
Creates the PhpMyAdmin\Utils\Gis class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-22 15:03:39 -03:00
Maurício Meneghini Fauth
caa3337411
Extract FK related methods from Util class
Creates the PhpMyAdmin\Utils\ForeignKey class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-21 15:25:45 -03:00
Maurício Meneghini Fauth
7e23436533
Add Twig\FlashMessagesExtension class
Adds the flash() Twig function that return all flash messages.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-20 18:51:36 -03:00
Maurício Meneghini Fauth
2c2127b369
Rename PMA_Theme global variable to theme
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-07 15:15:27 -03:00
William Desportes
a9044ffcab
Upgrade phpmyadmin/twig-i18n-extension to 4.0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-25 01:51:18 +01:00
Maurício Meneghini Fauth
1e5fbd57fc
Create Twig\AssetExtension and image Twig function
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-28 16:09:17 -03:00
Maurício Meneghini Fauth
db3da81056 Remove some useless comments
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-13 19:56:56 -03:00
Maurício Meneghini Fauth
ac9bccf67d Replace $GLOBALS['dbi'] with global $dbi
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-11 09:24:21 -03:00
Maurício Meneghini Fauth
e81146e4b3 Remove useless return annotations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-07 10:30:27 -03:00
ABGEO
271eb4ffeb 🔥 Remove code related to ActionLinksModes.
Signed-off-by: Temuri Takalandze <takalandzet@gmail.com>
2020-06-28 21:31:27 +04:00
William Desportes
bd4d353d63
Fix coding-standard issues after the merge of #16192
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-15 13:59:32 +02:00
William Desportes
7e5dd8eba0
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-15 13:15:31 +02:00
William Desportes
14211e6118
Fix twig imports using old PSR-1 style
Ref: 273b666a71
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-14 22:55:55 +02:00
Maurício Meneghini Fauth
29d6697caa Remove mime_default_function Twig filter
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-06-12 01:19:14 -03:00
William Desportes
889715fefa
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-28 09:46:33 +02:00
William Desportes
43564f5f5f
Fix twig deprecations for php 8
Ref: https://github.com/twigphp/Twig/issues/3327
Upstream: https://github.com/twigphp/Twig/pull/3331

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-28 09:39:30 +02:00
Maurício Meneghini Fauth
199e3d9813 Fix coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 21:08:55 -03:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
487591badd Remove the DropDownUploadFileBlock HTML generator
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-01 20:06:09 -03:00