gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
125,737 Commits 12 Branches 481 Tags 2.4 GiB
afcb4e406d
Commit Graph

1886 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
36a77f7476
Force a full page reload for top menu links 
Each page is a different page, so it makes more sense to do a full page
reload instead of using AJAX to load the main content.

This also avoid some possible issues with broken event handlers and
not properly loaded pages.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-26 15:46:39 -03:00
Kamil Tekiela
4f20be0d6c Fix bug preventing opening information_schema 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-24 01:26:02 +00:00
Maurício Meneghini Fauth
c9659f4028
Merge branch 'QA_5_2' 2023-02-20 12:18:12 -03:00
Liviu-Mihail Concioiu
3224f6c47d
Fix #17599 - Fix passwordForm is null (#18043) 
* Fix passwordForm is null

---------

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
 2023-02-20 12:03:44 -03:00
William Desportes
a2e2ef9501
Merge branch 'QA_5_2' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-02-19 13:58:34 +01:00
William Desportes
d525a722b1
Add autocomplete attribute to password inputs to change password 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-02-19 12:39:58 +01:00
Kamil Tekiela
2b35303aae
Remove redundant code (#18063) 
PHPStorm has been a little annoying with showing all these code issues. I took some time to analyse most of them and fix whichever were easy to fix. This kind of change should improve future maintenance as developers do not need to wonder what a line of code does. Code that has no impact on functionality should be removed.

* Remove redundant variables
* Invert condition for better clarity
* Remove some of the redundant casts
* Replace switch with an if
* Fix foreach variable
* Remove redundant variable concat
* Remove redundant concats
* Replace for loop with str_repeat
* Remove always true param
* Turn property $position into local var
* Turn Pdf properties into local vars
* Remove unused properties in Pdf
* Change ternary into condition
* Remove redundant assignments
   They are immediately overwritten with a different value.
* Redundant array append
* Collapse if statements into assignments
* Use boolean constants instead of variables
* Remove unneeded parameter
* Remove null-coalesce
* Unnecessary assignment
* Remove redundant isset
* Remove readOnly flag for InsertEdit fields
* Remove function_exists and $mode var
* Remove duplicate condition
* Remove redundant elseif
* Remove redundant isset
* Use hasBodyParam()
* Simplify isRoutesCacheFileValid()
   Psalm complains but is wrong.

https://github.com/phpmyadmin/phpmyadmin/pull/18063

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-15 09:11:05 -03:00
Maurício Meneghini Fauth
3cb03e6d24
Refactor AJAX.scriptHandler.add() function 
Changes fire param to boolean and removes the return.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-09 15:43:08 -03:00
Maurício Meneghini Fauth
91167fb70b
Create the DesignerConfig JS object 
This removes the properties from the Window object.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-05 13:00:03 -03:00
Kamil Tekiela
5f009765ca Remove newlines in Twig 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-01-30 22:31:51 +00:00
Maurício Meneghini Fauth
07b3a85f3b
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-01-24 15:45:42 -03:00
Maurício Meneghini Fauth
5a267d0a81
Fix broken button that adds routine params 
- Fixes https://github.com/phpmyadmin/phpmyadmin/issues/17833

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-01-24 14:28:08 -03:00
Maurício Meneghini Fauth
93c77c3784
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-01-24 11:23:53 -03:00
Maurício Meneghini Fauth
3fc35e69ca
Add an alert for the FIDO U2F API deprecation 
Related to https://github.com/phpmyadmin/phpmyadmin/issues/17229.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-01-21 12:44:35 -03:00
Maurício Meneghini Fauth
37cf6484eb
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-01-17 00:01:42 -03:00
Maurício Meneghini Fauth
f143d2a709
Add support for Web Authentication API 
Adds a two factor authentication plugin that supports FIDO2/WebAuthn
security keys.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-01-16 18:20:05 -03:00
William Desportes
6d42cd8017
Add spellcheck="false" on some login text fields to avoid data leaks to spell checking services 
Ref: https://www.otto-js.com/news/article/chrome-and-edge-enhanced-spellcheck-features-expose-pii-even-your-passwords

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-01-16 12:43:54 +04:00
William Desportes
2f2f7d4c92
Add spellcheck="false" on password fields to avoid data leaks to spell checking services 
Ref: https://www.otto-js.com/news/article/chrome-and-edge-enhanced-spellcheck-features-expose-pii-even-your-passwords

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-01-16 12:39:10 +04:00
Maurício Meneghini Fauth
cdc2f37a1d
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-01-03 19:38:50 -03:00
William Desportes
19c4657f39
#17999 - Remove modals from the login page 
It shows weird buttons

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-12-30 15:52:16 +04:00
Maurício Meneghini Fauth
13890a947a
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-12-16 11:53:18 -03:00
Kamil Tekiela
db5db26c60
Refactor Database Search (#17962) 
* Refactor Search::getWhereClause()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Refactor Search::getSearchSqls()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix HTML escaping issues in Database search

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Change links to buttons

More semantically correct, does not link to a separate page on middleclick, and looks better.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Refactor Search::getSearchResults()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update psalm-baseline.xml

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update phpstan-baseline.neon

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-12-15 13:43:29 -03:00
William Desportes
556aacbc0f
Fix #17944 - unable to create a view from tree view button 
- Add the modal to the navigation panel
- Prevent modals to be removed on navigation bar is replaced

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-12-12 22:04:37 +01:00
Maurício Meneghini Fauth
83e8ed59cc
Remove Config object from the Window global object 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-30 22:00:29 -03:00
Maurício Meneghini Fauth
66f0c2869a
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-30 15:34:47 -03:00
Maurício Meneghini Fauth
e6f8623e1f
Merge pull request #17921 from kamil-tekiela/like 
Clean up LIKE escaping
 2022-11-30 14:27:14 -03:00
Maurício Meneghini Fauth
e8e62fdf86
Move some config messages to the JS Messages Controller 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-29 13:48:05 -03:00
Maurício Meneghini Fauth
f115608c45
Extract inline JS for import's upload progress logic 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-28 21:03:30 -03:00
William Desportes
0108190ebd
Fix #17177 - Preview SQL when reordering columns doesn't work on move columns 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-11-26 00:00:32 +01:00
William Desportes
69768f15e1
Fix #17632 - Login Page: Tab keypress to Text Fields 
Closes: #17633
Fixes: #17632

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-11-25 22:17:26 +01:00
William Desportes
e688c46455
Merge #17823 - Fix #17598 - Change password nav link is missing 
Pull-request: #17823
Fixes: #17598

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-11-25 21:53:37 +01:00
Kamil Tekiela
dd699f348d Clean up LIKE escaping 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-11-25 00:06:52 +00:00
Maurício Meneghini Fauth
f421836ebe
Remove inline JS in change_password.twig template 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-22 17:40:05 -03:00
Maurício Meneghini Fauth
5ab7640bc7
Remove force_file_* global vars and param 
Uses a HTML data attribute instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-21 17:30:55 -03:00
William Desportes
655c5e1541
Merge branch 'QA_5_2' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-11-20 18:16:02 +01:00
William Desportes
bad8f2f913
Fix #17340 - New Table -> VIRTUAL attribute is lost when adding new column 
Fixes: #17340

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-11-20 17:44:42 +01:00
William Desportes
8720f9f1ca
Update the translation for "Filter rows" to include ":" 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-11-19 19:56:23 +01:00
William Desportes
54b433c40c
Convert "Filter rows" on results table to Bootstrap 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-11-19 19:54:40 +01:00
William Desportes
dd915776f2
Convert "Filter rows" on central columns to Bootstrap 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-11-19 19:45:02 +01:00
William Desportes
5afd74a205
Merge branch 'QA_5_2' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-11-19 18:45:12 +01:00
William Desportes
027171169e
Fix PHP error on adding new column on create table form 
```
Internal error in ./templates/columns_definitions/column_attributes.twig#218
 Twig\Error\RuntimeError: An exception has been thrown during the rendering of a template ("preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated").
```

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-11-16 14:39:53 +01:00
Maurício Meneghini Fauth
aeb237f629
Fix TypeError in Server\ReplicationController class 
Fixes https://github.com/phpmyadmin/phpmyadmin/issues/17875

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-10 21:44:25 -03:00
Maurício Meneghini Fauth
77f9ebb61a
Improve error message when UseDbSearch config is disabled 
Replaces Html\Generator::mysqlDie() to avoid calling the exit construct.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-09 14:55:14 -03:00
William Desportes
484de699bb
Merge branch 'QA_5_2' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-10-29 20:11:18 +02:00
William Desportes
cf012620db
Merge #17826 - Remove spaces around links and correct text for monitor import file 
Pull-request: #17826

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-10-29 20:03:22 +02:00
Maurício Meneghini Fauth
69bbe6c5e4
Merge pull request #17801 from Arpit-Gulgulia/ticket_13773 
Fix #13773 - Export page of Settings is not responsive
 2022-10-29 09:13:43 -03:00
William Desportes
4ba2a88e73
Merge branch 'QA_5_2' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-10-26 17:01:39 +02:00
William Desportes
578b18b43f
Fix add index on new table form has duplicate go buttons in the modal 
Go to create a new table then add an index on a column you want to create, see the duplicate buttons in the footer

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-10-26 16:23:00 +02:00
William Desportes
de28c21aa3
Fix #17812 - Add missing styles to buttons on change procedure/function form 
See: #17833
Fixes: #17812

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-10-26 15:34:43 +02:00
William Desportes
85d75085b7
Merge #17808 - Fix #17772 - Wrong styles for add button from central columns on MariaDB 
Pull-request: #17808
Fixes: #17772

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-10-26 14:22:37 +02:00