gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
125,737 Commits 12 Branches 481 Tags 2.4 GiB
afcb4e406d
Commit Graph

56 Commits

Author SHA1 Message Date
Kamil Tekiela
276577ca2a
Remove $GLOBALS['PMA_PHP_SELF'] (#18149) 
* Remove $GLOBALS['PMA_PHP_SELF']

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove $GLOBALS['PMA_PHP_SELF'] from tests

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Moved cleanupPathInfo to Routing

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove parse_url from getRootPath

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update baselines

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove invalid tests

Surely, we never expect PATH to be backslash delimited. The code is not designed to handle this and the tests for this don't make much sense.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix trailing slash in path

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-27 17:56:27 -03:00
Maurício Meneghini Fauth
16a0660a78
Add native property types to test classes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-27 01:17:22 -03:00
Maurício Meneghini Fauth
556594b4cd
Fix coding standard spacing issues 
- Fixes one line doc comments
- Fixes parent call spacing
- Fixes constant spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-24 21:06:17 -03:00
Maurício Meneghini Fauth
77957a69a5
Add trailing comma for multi-line functions 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-24 20:48:46 -03:00
Maurício Meneghini Fauth
930f8826d3
Remove dead code for old PHP versions 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-12 13:59:40 -03:00
Maurício Meneghini Fauth
346923e20a
Set dbi only when the test needs it 
Related to https://github.com/phpmyadmin/phpmyadmin/pull/17637

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-14 02:21:45 -03:00
Maurício Meneghini Fauth
feca48cc76
Change return type of DatabaseInterface::getError method 
Now, it returns last error message or an empty string instead of false
if no errors occurred.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-27 14:43:14 -03:00
Maurício Meneghini Fauth
3e0856c77b
Remove useless string concatenations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-27 21:40:22 -03:00
Maurício Meneghini Fauth
f00d70cccb
Remove useless whitespaces 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-15 17:05:40 -03:00
Maurício Meneghini Fauth
355f6d9d20
Remove PhpMyAdmin\Config::enableBc method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-07-09 13:59:04 -03:00
Maurício Meneghini Fauth
9adaa912e1
Rename Response class to ResponseRenderer 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-30 12:35:22 -03:00
Maurício Meneghini Fauth
1ed9ab5dda
Fix failing unit test 
Random Seeds: 1623610942, 1623612011, 1623680984

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-14 12:41:49 -03:00
Maurício Meneghini Fauth
f3b79d83c0
Add PHPUnit's Covers annotation on test classes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-04 23:39:26 -03:00
Maurício Meneghini Fauth
a7d6df17d6
Remove warnings from PHPUnit 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-04-09 13:28:47 -03:00
Maurício Meneghini Fauth
33d711215d
Remove the PMA_VERSION constant 
Uses the PhpMyAdmin\Version::VERSION constant instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-08 22:22:55 -03:00
Maurício Meneghini Fauth
7e33d227f5
Rename the PMA_Config global variable to config 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-08 15:03:12 -03:00
Maurício Meneghini Fauth
0b8edc5bde
Use PSR-12 for namespace use statements 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-05 14:18:35 -03:00
William Desportes
76803f9422
Replace deprecated ->setMethods by ->onlyMethods 
See: https://github.com/sebastianbergmann/phpunit/pull/3687
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-03-04 23:24:25 +01:00
Maurício Meneghini Fauth
db3da81056 Remove some useless comments 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-13 19:56:56 -03:00
Maurício Meneghini Fauth
f2e49a92c6 Fix some type errors detected by PHPStan 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-09-30 19:23:01 -03:00
Maurício Meneghini Fauth
ceac762e09 Remove pmaThemePath and pmaThemeImage PHP globals 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-09-02 10:57:57 -03:00
Maurício Meneghini Fauth
ba09c84a05 Fix PHPStan errors for PHPUnit assert methods 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-08-10 16:20:53 -03:00
Maurício Meneghini Fauth
2358b9c4f9 Fix missing property type hints 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-22 21:42:22 -03:00
Maurício Meneghini Fauth
47f0960dce Add return type declaration to test methods 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-07 11:31:33 -03:00
Maurício Meneghini Fauth
3ae05c785d Use short list syntax and single line arrays 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-26 03:32:59 -03:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
9269d75fb4 Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-25 20:22:18 -03:00
William Desportes
a878168e6c
Fix a typo in my last commit 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-22 09:08:26 +02:00
William Desportes
b8e6834058
Rename PmaTestCase to AbstractNetwokTestCase 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-22 01:49:22 +02:00
William Desportes
ae575ffb14
Fix running tests in --process-isolation 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-21 16:21:20 +02:00
William Desportes
0964470643
Use parent::setGlobalConfig(); 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-21 13:19:23 +02:00
William Desportes
8f7d3d1fa7
Fix test cases after backupGlobals = false 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-21 02:07:45 +02:00
William Desportes
6eaa55e805
Call parent's setUp and tearDown 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-20 21:31:13 +02:00
William Desportes
0b2c24ee26
Use ::class in tests 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-20 12:15:40 +02:00
Maurício Meneghini Fauth
80a45fa0ae Break too long lines 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-16 18:08:20 -03:00
William Desportes
86822d7a02
Fix a test after the merge of #15872 
Ref: d93bbf3cbb
It was a mistake in d93bbf3cbb
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-03 23:47:29 +02:00
William Desportes
d93bbf3cbb
Fix tests after the merge of #15872 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-02 13:44:59 +02:00
Maurício Meneghini Fauth
206199105e Remove useless return type annotations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
676f48349a Reference global funcs and consts via use statement 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations 
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
1a14b3e4d3 Remove vim modelines 
These settings are no longer required as they are guaranteed through
other coding standard tools.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-09-02 09:43:21 -03:00
Maurício Meneghini Fauth
45dc342666 Fix coding standard errors 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-05-10 19:07:02 -03:00
William Desportes
31ab2cb4e8
Merge branch 'QA_4_8' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-05-11 00:03:16 +02:00
William Desportes
b5245272db
Use ::class for AuthenticationSignon test 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-05-05 13:48:29 +02:00
William Desportes
1c55346cdb
Add a test for setCookieParams 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-05-05 13:48:29 +02:00
Maurício Meneghini Fauth
92cc67fbf7 Replace assertContains() with assertStringContainsString() 
Using assertContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringContainsString() or assertStringContainsStringIgnoringCase() instead.
Using assertNotContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringNotContainsString() or assertStringNotContainsStringIgnoringCase() instead.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-02-24 16:32:28 -03:00
Maurício Meneghini Fauth
182491a73f Add void return type declaration for tests 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-02-22 21:33:55 -03:00
Maurício Meneghini Fauth
b9c0463d96 Use short array syntax instead of long array syntax 
Replaces array() with [].

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-30 01:42:21 -03:00
Maurício Meneghini Fauth
dc8c92bfd8 Enable strict mode in test files 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-16 04:36:04 -03:00
Maurício Meneghini Fauth
364ed60ee3 Fix AuthenticationSignonTest global dependencies 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-12-20 20:05:32 -02:00