Commit Graph

742 Commits

Author SHA1 Message Date
Chirayu Chiripal
48b0bfd259 no need to disable contructor of SplObjectStorage
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-06-25 09:24:19 +02:00
Ann + J.M
1fd8fde4ca Fix failing tests
Signed-off-by: Ann + J.M <phpMyAdmin@ZweiSteinSoft.de>
2014-06-22 16:49:17 +02:00
Michal Čihař
bc60315023 Adjust tests to new IV logic
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-12 10:18:45 +02:00
Chirayu Chiripal
ff688b18fb Bug-4448: Dump binary columns in hexadecimal notation not working and hex_for_blob -> hex_for_binary
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-06-10 19:00:16 +05:30
Ann + J.M
5ddd0c1990 Code style fixes
Signed-off-by: Ann + J.M <phpMyAdmin@ZweiSteinSoft.de>
2014-05-21 20:56:01 +02:00
Marc Delisle
0ee881da71 bug #4395 BLOB link transformation is broken
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-05-16 09:56:47 -04:00
Hugues Peccatte
9870cb5142 Update DB group queries format.
Update DB group test.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-04-23 21:30:12 +02:00
Hugues Peccatte
ebc2739c89 Update documentation.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-04-22 21:36:26 +02:00
Marc Delisle
507fa83e7f Merge branch 'QA_4_1' 2014-04-07 13:09:32 -04:00
Marc Delisle
81ed4c9c83 bug #4355 Precision specifier for DOUBLE type is truncated
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-04-07 13:08:41 -04:00
Chanaka Indrajith
70c3ad7c27 Remove unneccessary tests
Signed-off-by: Chanaka Indrajith <pe.chanaka.ck@gmail.com>
2014-04-05 23:20:50 +05:30
Michal Čihař
7233657d4d Remove support for SQL validator
The SOAP service seems to be down for quite some time and it is not
mentioned anywhere on Mimer website.

Signed-off-by: Michal Čihař <michal@cihar.com>
2014-04-02 12:10:52 +02:00
Michal Čihař
c6cc2f70b1 Merge branch 'QA_4_1' 2014-04-02 09:15:25 +02:00
Michal Čihař
b80e73979b Fixed PHP Parse error in Advisor
There is one rule which needs to pass more values to format string and
the code did not properly handle this. Now evaluating params and passing
them to vsprintf to process the format string.

Signed-off-by: Michal Čihař <michal@cihar.com>
2014-04-02 09:14:15 +02:00
Michal Čihař
58fcc7bb32 Add test for double format values
bug #4347

Signed-off-by: Michal Čihař <michal@cihar.com>
2014-04-02 09:09:19 +02:00
Michal Čihař
a40ce0eda7 Support AES_DECRYPT as well
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-03-25 13:59:29 +01:00
Michal Čihař
8dd5df2a7f Merge pull request #1077 from ganeshaditya1/multicolumn
Multicolumn sorting feature request(1507)
2014-03-24 15:21:54 +01:00
Aditya Sastry
a05ab9640b Multicolumn sorting feature request(1507)
This patch completely implements the feature requested and it modifies 4
existing files and adds one extra Javascript file. The existing system for
one column sorting has been refactored to be used for multicolumn sort.

Files messages.php and makegrid.js where modified to add the tool tip.

File sql.php was modified to add the import statement for the newly added JS
file.

The newly added columndelete.js is responsible for shift deleting the columns.
It gets the url of the link that was shift clicked and removes the name of the
column which we want to remove from the order by clause.

Finally, most of the crux of this feature request is implemented through
changes to the DisplayResult.class.php. 4 methods of this class have been
refactored to accomodate the required change. getsortparams() which process
the order by clause text remains the same, just the output parameters have
been turned into a array for each order by clause column. isInSort() has been
modified to check multiple order by clauses. The smart ordering feature in
to form a new function makeURL, which makes the url for multiple sorted table's
header's button's targets.

Signed-off-by: Aditya Sastry <ganeshaditya1@gmail.com>
2014-03-24 02:17:54 +05:30
Michal Čihař
d559fa6a21 Remove trailing whitespace from the code
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-03-20 09:36:48 +01:00
Michal Čihař
3ba249176a Remove incomplete @covers annotations
PHPUnit now uses these to list code which is covered and was not listed
in @covers, what produces quite a lot of errors. I don't think we really
need to explicitely list those directives.

Signed-off-by: Michal Čihař <michal@cihar.com>
2014-03-19 16:04:20 +01:00
Hugues Peccatte
cbc966c03d PHPCS updates.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-03-15 12:29:31 +01:00
Michal Čihař
40f9df6fcc Merge pull request #1067 from jeffchan/fix-tests
Fix unit test running individually by file
2014-03-15 08:26:49 +01:00
Hugues Peccatte
9b1f025fb7 PHPCS updates.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-03-14 23:06:46 +01:00
Jeff Chan
3e65f88dee Fix AuthenticationCookieTest::testAuth to have proper includes
Also change testAuthSetUserWithHeaders to have more flexible assertion

Signed-off-by: Jeff Chan <jefftchan@gmail.com>
2014-03-14 19:28:17 +00:00
Jeff Chan
719babd2c6 Import dependencies to make tests friendlier to running independently
The HHVM test runner runs the unit tests in parallel. Currently some tests
fail because not all the dependencies are properly included.

Signed-off-by: Jeff Chan <jefftchan@gmail.com>
2014-03-14 18:59:18 +00:00
Jeff Chan
69e2f227ab Move slow tests in HHVM to medium group
Signed-off-by: Jeff Chan <jefftchan@gmail.com>
2014-03-14 18:59:13 +00:00
Jeff Chan
581f8e4d94 Define MYSQL_VERSION string constant if not already defined
These tests were failing when run individually since the constant was
not defined. This patch defines the constant if it doesn't exist.

Signed-off-by: Jeff Chan <jefftchan@gmail.com>
2014-03-14 18:59:07 +00:00
Michal Čihař
3d0f237031 Fix expected message to match code
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-03-14 13:05:48 +01:00
Michal Čihař
3e83565cf2 Fix order of params to assertEquals
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-03-14 13:05:41 +01:00
Michal Čihař
a2d84745d2 Drop List::getSingleItem as it is not used
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-03-14 07:29:15 +01:00
Jeff Chan
013a9a3395 Move slow test in HHVM to group medium
These tests were failing on HHVM because of the default 3 second timeout.
Yes, HHVM is supposed to be faster, but there's a "warmup" time for scripts
in JIT mode (which is on by default). I suspect that's why they're failing.

Signed-off-by: Jeff Chan <jefftchan@gmail.com>
2014-03-13 20:52:13 +00:00
Michal Čihař
ffbb41d6d5 Fix expected message to match code
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-03-13 13:50:54 +01:00
Michal Čihař
28f0a09b2f Fix order of params to assertEquals
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-03-13 13:47:30 +01:00
Jeff Chan
0216a5a4a1 Move slow tests in HHVM to group medium
These tests were failing on HHVM because of the default 3 second timeout.
Yes, HHVM is supposed to be faster, but there's a "warmup" time for scripts
in JIT mode (which is on by default). I suspect that's why they're failing.

Signed-off-by: Jeff Chan <jefftchan@gmail.com>
2014-03-13 05:20:31 +00:00
Jeff Chan
3f0f634c38 Import config to make unit tests friendlier to running independently
The HHVM test runner runs the unit tests in parallel. Currently some tests
fail because not all the dependencies are properly included.

This is similar to 607cb3b0b3

Signed-off-by: Jeff Chan <jefftchan@gmail.com>
2014-03-12 03:30:36 +00:00
Jeff Chan
607cb3b0b3 Import dependencies to make unit tests friendlier to running independently
The HHVM test runner runs the unit tests in parallel. Currently some tests
fail because not all the dependencies are properly included.

This is similar to 659efe1a88

Signed-off-by: Jeff Chan <jefftchan@gmail.com>
2014-03-10 03:26:24 +00:00
Jeff Chan
659efe1a88 Import dependencies to make unit tests friendlier to running independently
The HHVM test runner runs the unit tests in parallel. Currently some tests
fail because not all the dependencies are properly included.

This is similar to 840f7b1215

Signed-off-by: Jeff Chan <jefftchan@gmail.com>
2014-03-09 08:16:24 +00:00
Madhura Jayaratne
2512ffe513 Merge pull request #1034 from jeffchan/fix-export-tests
Import export.lib.php to make unit tests friendlier to running independently
2014-03-09 11:41:56 +05:30
Madhura Jayaratne
821fe48794 Merge pull request #1033 from jeffchan/remove-duplicate-include
Remove duplicate include_once
2014-03-09 11:41:45 +05:30
Jeff Chan
4f241de077 Import export.lib.php to make unit tests friendlier to running independently
The HHVM test runner runs the unit tests in parallel. Currently some tests
fail because not all the dependencies are properly included.

This is similar to 1d58392622

Signed-off-by: Jeff Chan <jefftchan@gmail.com>
2014-03-09 05:03:05 +00:00
Jeff Chan
6b0e7d6807 Remove duplicate include_once
Signed-off-by: Jeff Chan <jefftchan@gmail.com>
2014-03-09 04:55:55 +00:00
Jeff Chan
1d58392622 Import gettext include to make unit tests friendlier to running independently
The HHVM test runner runs the unit tests parallelly. Currently some tests
fail because not all the dependencies are properly included.

This is similar to this commit 840f7b1215

Signed-off-by: Jeff Chan <jefftchan@gmail.com>
2014-03-09 04:24:51 +00:00
Michal Čihař
3bc935063f Merge remote-tracking branch 'origin/QA_4_1' 2014-03-06 09:18:27 +01:00
Michal Čihař
73cdd13a83 Merge pull request #994 from mebjas/QA_4_1
Correcting test for Config.class.php
2014-03-06 09:18:03 +01:00
minhaz
06e7aa4c26 Test case for Config.class.php fixed
Testcases modified:
Two test cases - one for no config file , other with config file

Signed-off-by: A V Minhaz <minhazav@gmail.com>
2014-03-06 12:08:48 +05:30
minhaz
13baf4ea18 testing permission for test object
Signed-off-by: A V Minhaz <minhazav@gmail.com>
2014-03-06 00:44:37 +05:30
minhaz
5868049867 Update PMA_Config_test.php
As per discussion in mailing list, another object is used to check for file permission while global object remains same!
Signed-off-by: A V Minhaz <minhazav@gmail.com>
2014-03-05 23:01:05 +05:30
minhaz
f580c8fb94 Correcting test for Config.class.php
The constant used to load config file i.e CONFIG_FILE was config.inc.php while it did not exist in code base, which was causing two similar test-case with no config-file.
CONFIG_FILE has been replaced with "config.sample.inc.php" which can be tested for.
 
Signed-off-by: A V Minhaz <minhazav@gmail.com>
2014-03-04 00:49:57 +05:30
Michal Čihař
f319824b54 Fix regexp to match
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-03-03 09:30:51 +01:00
Michal Čihař
6cbde74c25 Test encoded binary output
Otherwise PHP sometimes refuses to match binary content using PCRE.

Signed-off-by: Michal Čihař <michal@cihar.com>
2014-03-03 09:30:44 +01:00