gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
121,452 Commits 12 Branches 481 Tags 2.4 GiB
b1f94de32d
Commit Graph

178 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
d7ced91ae2
Fix db selection when nav tree is disabled 
$cfg['ShowDatabasesNavigationAsTree'] = false;

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-11-21 12:08:21 -03:00
William Desportes
e0adc6cbac
Fix #16973 - Undefined array key "n0_pos2_name" and not working pos3 
This also fixes a bug introduced in: 52fcbdf422
9 years ago, I tried hard to understand how it is used but for now I could not figure out.
This is now back to working code for the pos3 if.

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-20 01:30:38 +02:00
William Desportes
4d7890d1f6
Fix "TypeError: strlen() expects parameter 1 to be string, null given" 
Found on writing tests, should not happen

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-20 01:30:37 +02:00
Maurício Meneghini Fauth
2535853fcc
Fix duplicate quote in navigation nodes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-07-15 13:07:31 -03:00
William Desportes
eb258a806d
Query adjustments 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-24 16:19:53 +02:00
William Desportes
c781a7af75
Fix #16784 - Add a space between .second and .double CSS classes 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-02 12:55:12 +02:00
William Desportes
2b42dc9bcb
Fix #16786 - JS error when clicking on phpMyAdmin logo link defined to an external website using config NavigationLogoLinkWindow = main 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-01 23:59:39 +02:00
William Desportes
105a51ae28
Fix #16717 - Make main drawer sync call async and remove the reflow issue 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-03-19 19:40:07 +01:00
William Desportes
66f38555d4
Ref #14801 - Remove plain HTML for PHP code for ShowDatabasesNavigationAsTree option 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-12-07 10:31:11 +01:00
William Desportes
dfce335134
Some text code improvements 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-12-07 01:03:03 +01:00
Maurício Meneghini Fauth
ac9bccf67d Replace $GLOBALS['dbi'] with global $dbi 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-11 09:24:21 -03:00
William Desportes
466ff06b3b
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-09-15 14:22:24 +02:00
William Desportes
62b9d8ca92
Merge #16354 - Fixes #14698 - Database named as 'New' causes PHP fatal error 
Pull-request: #16354
Fixes: #14698

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-09-15 14:18:56 +02:00
Nina Pypchenko
de168edc59 Fixes #14698. Navigation tree no longer breaks on encountering a database named 'New' 
Signed-off-by: Nina Pypchenko <22447785+nina-py@users.noreply.github.com>
 2020-09-15 20:53:02 +10:00
William Desportes
d63a72ad51
Fixes #16278 - Remove underscore prefix from property names 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-08-06 15:46:39 +02:00
Maurício Meneghini Fauth
2358b9c4f9 Fix missing property type hints 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-22 21:42:22 -03:00
Maurício Meneghini Fauth
652c55a5ef Remove Config\PageSettings::getNaviSettings method 
Related to https://github.com/phpmyadmin/phpmyadmin/issues/16258.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-12 17:40:19 -03:00
Maurício Meneghini Fauth
3b285ff17e Use identical operator for non-empty strings 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-10 18:06:29 -03:00
Maurício Meneghini Fauth
e81146e4b3 Remove useless return annotations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-07 10:30:27 -03:00
William Desportes
fd21520711
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-07-01 14:40:36 +02:00
William Desportes
50af2c9baa
Fix coding standard issues 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-07-01 14:35:20 +02:00
William Desportes
bbe1132484
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-07-01 14:05:53 +02:00
William Desportes
9444234e78
Fix #16237 - Logo missing in upper left corner of navigation panel 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-07-01 13:55:11 +02:00
William Desportes
4f6a1fc161
Fix coding standard issues after merge of #16226 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-06-27 18:13:45 +02:00
William Desportes
d6a1e4aee2
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-06-26 19:19:57 +02:00
William Desportes
425c1c32a7
Fix #16226 - Error 500 after copying a table 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-06-26 19:11:53 +02:00
Maurício Meneghini Fauth
2529824c23 Extract change column action from table structure index method 
Related to #16136

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-06-08 18:20:48 -03:00
William Desportes
5d933e03b9
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-06-07 23:40:25 +02:00
William Desportes
d06ec742e3
Fix an "Uncaught TypeError: PhpMyAdmin\DatabaseInterface::dataSeek()" 
Uncaught TypeError: PhpMyAdmin\DatabaseInterface::dataSeek(): Argument #2 ($offset) must be of type int, string given, called in libraries/classes/Navigation/Nodes/NodeDatabase.php on line 488 and defined in libraries/classes/DatabaseInterface.php:2724"

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-06-07 23:06:40 +02:00
William Desportes
055a9bf3bc
Be sure to cast the result and not a possibly undefined index that would send a notice 
Ref: 490d731d6c

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-06-05 14:03:13 +02:00
William Desportes
7623fed14a
Fix all found errors and add typehints if possible on NavigationTree class 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-06-02 23:50:49 +02:00
William Desportes
62baf0b8ea
Change Node::getChild return to ?Node 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-06-02 23:10:35 +02:00
William Desportes
6266583e63
Add some typehints on NavigationTree 
Ref: #16158

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-06-02 09:18:51 +02:00
William Desportes
490d731d6c
Add some fallbacks if the data is not available 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-31 01:25:23 +02:00
William Desportes
a1a6dd99ea
Move vPath, aPath, pos to paths_nav using data-* attributes 
Ref: d944f0851e
Ref: aec59d5007

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-31 00:58:16 +02:00
William Desportes
aec59d5007
Move pos3_name and pos3_value to pos3_nav using data-* attributes 
Ref: d944f0851e

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-31 00:47:11 +02:00
William Desportes
d944f0851e
Move pos2_name and pos2_value to pos2_nav using data-* attributes 
Note: data-* are standard attributes

I did not move the back-end part so it is easier to find the places to refactor calls

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-31 00:41:32 +02:00
Maurício Meneghini Fauth
f4582e083e Use early exit when possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
bd979dd1ff Remove useless elseif with if 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-26 22:53:44 -03:00
Maurício Meneghini Fauth
3ae05c785d Use short list syntax and single line arrays 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-26 03:32:59 -03:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-25 22:42:37 -03:00
William Desportes
4b0985843f
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-20 01:13:58 +02:00
William Desportes
481023e946
Fix #16127 - table column description error when DisableIS=true 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-19 20:11:53 +02:00
Maurício Meneghini Fauth
80a45fa0ae Break too long lines 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-16 18:08:20 -03:00
William Desportes
9a95abd05f
Use declaration of global $dbi 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-16 12:03:29 +02:00
Maurício Meneghini Fauth
84139f4d51 Remove some useless variables 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-13 16:15:37 -03:00
Maurício Meneghini Fauth
a64393e7f5 Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-13 00:23:28 -03:00
Yash Bothra
40665b1f35
Fix #15893 - broken urls in navigation 
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
 2020-03-08 00:48:52 +01:00
William Desportes
18b7622b6f
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-03-06 08:27:45 +01:00
Simon Vikstrom
e472b8bbc4
Fix "Uncaught TypeError: urlencode() expects parameter 1 to be string, int given in" 
If a user creates two tables prefixed with number__... like
2020__abc
2020__cde

then phpmyadmin will group then, the key will end up being an integer instead of a string and  PHP will error out on it.

Signed-off-by: Simon Vikstrom <pullreq@devsn.se>
 2020-03-06 08:18:11 +01:00