gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
121,452 Commits 12 Branches 481 Tags 2.4 GiB
b1f94de32d
Commit Graph

303 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
30fac275c5
Suppress some PHP 8.1 deprecations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-08-21 17:44:21 -03:00
Lukas Bixen
c0fe75bc67 Fix DEL character in generated random strings 
Apply suggestions from code review:
Use identical operator and improve comment

Signed-off-by: Lukas Bixen <lrb2_@outlook.com>
 2021-08-07 12:07:30 -05:00
William Desportes
d281dcc0bd
Fix #17026 - Handle possible invalid boolean values injected in SaveDir or UploadDir 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-22 12:59:54 +02:00
Maximilian Krög
c1c6b01195
Use correct min MySQL version for axis-order (8.0.1) 
There was no version 8.0.10
https://dev.mysql.com/doc/relnotes/mysql/8.0/en/news-8-0-1.html

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2021-07-20 01:28:29 +02:00
William Desportes
34acbcdc38
Fix calls to fetchRow using two parameters but function has only one parameter 
None of our fetchRow methods have more than one parameter

Thank you Psalm for catching this !

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-16 02:28:03 +02:00
William Desportes
6699fb1923
Fix 32-bit issues 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-05-24 22:03:41 +02:00
Saksham Gupta
43e39ab08b
Fix #16777 - Non-UTF8 Primary Key fix 
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
 2021-04-19 16:45:17 +02:00
William Desportes
a127061655
Fix #16773 - Do not use cast as binary for an empty text value 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-01 02:09:32 +02:00
Maurício Meneghini Fauth
5335b3feb8
Fix PHP 8.1 failing tests 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-27 14:51:33 -03:00
William Desportes
942a252b46
Fix #16694 - Do not escape _ for TABLE_NAME in information schema 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-03-22 23:20:23 +01:00
Sven Strickroth
965c124d96
Fix #16698 - Wrong Absolute Links In Navigation ("/" instead of "./") 
Fixes: #16698

Signed-off-by: Sven Strickroth <email@cs-ware.de>
 2021-03-05 14:33:11 +01:00
Sven Strickroth
0754a34411
Fix #16713 - Add backward compatibility for DefaultTabServer, DefaultTabDatabase, DefaultTabTable, NavigationTreeDefaultTabTable and NavigationTreeDefaultTabTable2 
Fixes: #16713

Signed-off-by: Sven Strickroth <email@cs-ware.de>
 2021-03-05 14:31:57 +01:00
William Desportes
2e63d8f99b
Fix breadcrumbs urls 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-02-17 14:18:21 +01:00
William Desportes
fb53951a2d
Cover Util::handleDisableFKCheckInit and Util::handleDisableFKCheckCleanup 
Ref: #16353

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-02-09 17:22:58 +01:00
Saksham Gupta
8e8b7df450 Fixes: https://github.com/phpmyadmin/phpmyadmin/issues/15389 
Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Add Unit Test

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Fix Lint

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Add comment

Signed-off-by: Saksham Gupta <shucon01@gmail.com>
 2021-01-28 16:37:07 +05:30
William Desportes
b4f1e14e80
fix or ignore phpstan 0.12.63 errors 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-12-18 22:17:18 +01:00
William Desportes
d402c0fd6b
Ref #16429 - PHP 8 error TypeError: Unsupported operand types: string / int 
1) PhpMyAdmin\Tests\Engines\PbxtTest::testResolveTypeSize with data set #2 ('A4', array('0', 'B'))
TypeError: Unsupported operand types: string / int

libraries/classes/Util.php:528
libraries/classes/Engines/Pbxt.php:156
test/classes/Engines/PbxtTest.php:175
vendor/phpunit/phpunit/phpunit:61

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-11-20 00:07:38 +01:00
Maurício Meneghini Fauth
ef62d7a9f5 Remove is_system_schema PHP global variable 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-11-02 18:48:23 -03:00
Maurício Meneghini Fauth
71c2f2d99a Remove is_show_stats PHP global variable 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-11-02 18:48:23 -03:00
William Desportes
5abcae9255
Fixed some typos in the code base 
I used code spell checker and did all the libraries/classes/*.php files one by one.
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-11-01 22:46:01 +01:00
Maurício Meneghini Fauth
e4e274976e Extract cache methods from Util to SessionCache class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-25 22:45:56 -03:00
Maurício Meneghini Fauth
db3da81056 Remove some useless comments 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-13 19:56:56 -03:00
William Desportes
0d97b16d16
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-10-13 14:13:03 +02:00
Saksham Gupta
280188f1fb
Fix #16326 - Latitude and Longitudes swap 
Fixes: #16326

Signed-off-by: Saksham Gupta <shucon01@gmail.com>
 2020-10-13 13:38:28 +02:00
Maurício Meneghini Fauth
ac9bccf67d Replace $GLOBALS['dbi'] with global $dbi 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-11 09:24:21 -03:00
Maurício Meneghini Fauth
bb32ba6d9c Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-04 12:31:43 -03:00
Maurício Meneghini Fauth
e7c8e20edb Fix some type errors detected by PHPStan 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-02 00:37:23 -03:00
Maurício Meneghini Fauth
d36d9437a1 Fix some errors detected by Psalm 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-09-16 21:03:53 -03:00
Maurício Meneghini Fauth
5aa2856f7f Remove Util::buildActionTitles and the titles global 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-09-12 22:50:08 -03:00
Maurício Meneghini Fauth
03d8314bba Create the PhpMyAdmin\Profiling class 
Extracts Profiling related methods to the Profiling class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-08-26 16:02:30 -03:00
William Desportes
bcf21c4081
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-07-28 18:12:30 +02:00
William Desportes
0e344b6a50
Fix #16256 - Warning: error_reporting() has been disabled for security reasons on php 7.x 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-07-25 19:49:52 +02:00
Maurício Meneghini Fauth
3b285ff17e Use identical operator for non-empty strings 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-10 18:06:29 -03:00
Maurício Meneghini Fauth
e81146e4b3 Remove useless return annotations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-07 10:30:27 -03:00
Maurício Meneghini Fauth
a22f7b1b7a Fix some PHPStan errors 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-04 00:00:59 -03:00
Maurício Meneghini Fauth
337585249b Fix some PHPStan erros in Util.php 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-03 20:40:57 -03:00
Maurício Meneghini Fauth
05c62ad1a8 Fix some PHPStan errors 
Fixes "Cannot access offset on array" errors.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-02 16:12:07 -03:00
Maurício Meneghini Fauth
887f531a4d Use Expression[] in Util::getUniqueCondition 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-06-05 16:06:55 -03:00
Maurício Meneghini Fauth
9d18234581 Refactor Util::getUniqueCondition method 
Passes the Statement instance directly instead of the
$analyzed_sql_results array.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-06-05 13:49:44 -03:00
charliewindred
ca3c5e17b0 Remove underscore prefix from method names 
Removed underscore from method names for PSR-12 compliance.
Signed-off-by: charliewindred <charliewindred@gmail.com>
 2020-06-02 16:44:16 +01:00
William Desportes
761045bcc9
Move getSystemSchemas and isSystemSchema to Query\Utilities 
If you think the class name could be better, feel free to improve it.
Everybody know naming classes is difficult ^^
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-31 01:42:53 +02:00
CommanderRoot
5a1c5acccc
Fix #16147 
Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
 2020-05-30 03:26:45 +02:00
Maurício Meneghini Fauth
199e3d9813 Fix coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-27 21:08:55 -03:00
William Desportes
aff8b646aa
Extract Util::getConditionValue from Util:getUniqueCondition 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-27 21:48:42 +02:00
William Desportes
aba5e27a82
Some code fixes and improvements 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-27 18:55:58 +02:00
Maurício Meneghini Fauth
f4582e083e Use early exit when possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
bd979dd1ff Remove useless elseif with if 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-26 22:53:44 -03:00
Maurício Meneghini Fauth
94955f187a Fix function call signatures indentation 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-26 04:22:02 -03:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
9269d75fb4 Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-25 20:22:18 -03:00