Commit Graph

96 Commits

Author SHA1 Message Date
William Desportes
d26739ec64
Ref #16982 - Add a test for removeRelation drop FK
And fix PHP 7.1 function syntax call

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-06-27 17:25:28 +02:00
William Desportes
962d33a4aa
Ref #16982 - Add tests for removeRelation
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-06-27 16:42:34 +02:00
Maurício Meneghini Fauth
db3da81056 Remove some useless comments
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-13 19:56:56 -03:00
Maurício Meneghini Fauth
ea163ffcae Move CentralColumns to the Database namespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-30 10:14:22 -03:00
Maurício Meneghini Fauth
ceac762e09 Remove pmaThemePath and pmaThemeImage PHP globals
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-02 10:57:57 -03:00
Maurício Meneghini Fauth
2358b9c4f9 Fix missing property type hints
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-22 21:42:22 -03:00
William Desportes
0340f66740
Fix some tests having wrong typehints
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-07-17 23:55:49 +02:00
William Desportes
a80153a633
Add typehints using phpcbf on test/*
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-07-17 22:52:42 +02:00
Maurício Meneghini Fauth
47f0960dce Add return type declaration to test methods
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-07 11:31:33 -03:00
Maurício Meneghini Fauth
dfa5f92c31 Add return type declaration to fetch row methods
DatabaseInterface's fetchArray, fetchAssoc, fetchRow and fetchSingleRow
methods.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-06-29 20:32:04 -03:00
William Desportes
a13e5d1c16
Fix tests documentation after removing _ from private methods
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-03 00:01:57 +02:00
charliewindred
7d792e88f6
Removed underscores from unit test methods
Removed underscore prefixes from unit test method calls.

Signed-off-by: charliewindred <charliewindred@gmail.com>
2020-06-02 23:52:32 +02:00
charliewindred
ca3c5e17b0 Remove underscore prefix from method names
Removed underscore from method names for PSR-12 compliance.
Signed-off-by: charliewindred <charliewindred@gmail.com>
2020-06-02 16:44:16 +01:00
Maurício Meneghini Fauth
f4582e083e Use early exit when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 00:35:24 -03:00
William Desportes
a300a25319
Replace assertEquals({false,true} by assert{false,true}
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-26 13:13:15 +02:00
Maurício Meneghini Fauth
3ae05c785d Use short list syntax and single line arrays
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 03:32:59 -03:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
9269d75fb4 Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 20:22:18 -03:00
William Desportes
45898139c7
Type fixes for EventsTest
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-24 01:36:56 +02:00
William Desportes
49a6d6e8d0
Use AbstractTestCase instead of PmaTestCase for all tests not needing mockResponse
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-22 01:45:50 +02:00
William Desportes
7b6cf8a1b9
Fix bad mocking cleanup of Response::_instance
Seed: 1590097033

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-22 01:40:59 +02:00
William Desportes
7e81b0b3d7
Merge callProtectedMethod and callPrivateFunction into callFunction
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 22:59:29 +02:00
William Desportes
5c270d863d
Move callProtectedFunction to abstract class
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 21:58:41 +02:00
William Desportes
ae575ffb14
Fix running tests in --process-isolation
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 16:21:20 +02:00
William Desportes
f89f4c9f2c
Fix failing tests after tear down cleans everything
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 13:19:23 +02:00
William Desportes
0964470643
Use parent::setGlobalConfig();
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 13:19:23 +02:00
William Desportes
8f7d3d1fa7
Fix test cases after backupGlobals = false
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 02:07:45 +02:00
William Desportes
a7490fcb6c
Make AbstractTestCase manage GLOBALS cleanup and config loading
Signed-off-by: William Desportes <williamdes@wdes.fr>
Some minor improvements

Signed-off-by: William Desportes <williamdes@wdes.fr>

Force sql-parser to reload the new language

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 02:07:45 +02:00
William Desportes
6eaa55e805
Call parent's setUp and tearDown
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 21:31:13 +02:00
William Desportes
8ef5143901
Use AbstractTestCase on all unit tests
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 21:15:06 +02:00
William Desportes
f063c553f2
Fix some tests executed in random order
Using: ./vendor/bin/phpunit --order-by=random --random-order-seed=1589977275 --exclude=selenium --no-coverage --filter=FormDisplayTest

Seeds: 1590000479, 1589977275, 1589998302, x1590001040, x1590001183

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 21:10:32 +02:00
William Desportes
0b2c24ee26
Use ::class in tests
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 12:15:40 +02:00
Maurício Meneghini Fauth
80a45fa0ae Break too long lines
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-16 18:08:20 -03:00
William Desportes
f2d349df40
Split part of the logic of getQueryFromRequest into processParamsAndBuild
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-16 14:06:36 +02:00
Maurício Meneghini Fauth
a64393e7f5 Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-13 00:23:28 -03:00
Maurício Meneghini Fauth
e9eff7bd25 Extract HTML from Database\Events::getEditorForm
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-14 19:51:16 -03:00
Maurício Meneghini Fauth
367df7b0a1 Remove Database\Routines::setGlobals method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-13 21:53:51 -03:00
Maurício Meneghini Fauth
bc8ca12027 Remove Database\Triggers::setGlobals method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-13 20:37:45 -03:00
Maurício Meneghini Fauth
f2c8257ab1 Remove Database\Events::setGlobals method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-13 20:08:43 -03:00
Maurício Meneghini Fauth
1102bdfdb7 Move Rte classes to the Database namespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-13 18:26:47 -03:00
Maurício Meneghini Fauth
f4fda0cf2f Extract HTML from QBE table header
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-03 00:30:26 -03:00
Maurício Meneghini Fauth
3127eff3af Extract HTML from Qbe::_getTableFooters method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-02 22:56:30 -03:00
Maurício Meneghini Fauth
e9f9c27d7e Extract HTML from Qbe::_getInsDelAndOrCell method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-02 18:33:54 -03:00
Maurício Meneghini Fauth
da815fbbcc Remove radio fields HTML generator
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-30 16:44:46 -03:00
William Desportes
0455dab6bb
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-15 11:40:12 +01:00
William Desportes
a865a641b0
Fix CR vs CRLF issue for testGetSQLQuery on Windows
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-15 01:32:35 +01:00
William Desportes
14b1fdf9a7
Fix tests for PR #15884 - Fix #15880 Change "Show Query" link to a button
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-13 23:35:46 +01:00
Maurício Meneghini Fauth
206199105e Remove useless return type annotations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf Use one line for comments with a single line
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 16:04:09 -03:00