Commit Graph

17 Commits

Author SHA1 Message Date
Kamil Tekiela
1c285464e0 Add error message instead of casting
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-03-16 23:17:15 +00:00
Kamil Tekiela
01721f6c18 Remove unused functionality
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-03-16 23:17:15 +00:00
Kamil Tekiela
ae203ed56d Change return type of detectCompression
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-03-16 23:17:15 +00:00
Kamil Tekiela
ceba692247 Remove private methods
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-03-16 23:17:15 +00:00
Kamil Tekiela
ccaa56b8ba Make name non-nullable and close class
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-03-16 23:17:12 +00:00
Kamil Tekiela
7db0e7c682 Remove File::isError() method
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-03-08 00:21:40 +00:00
Kamil Tekiela
98b3db158a Make protected properties private
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-03-08 00:08:45 +00:00
Maurício Meneghini Fauth
a15c6d6a47
Extract dependency from Util::userDir()
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2026-01-30 15:58:55 -03:00
Kamil Tekiela
ccedadae8e Convert settings to config
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-01-09 00:31:24 +00:00
Kamil Tekiela
829f0f2140 Convert settings to config
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2026-01-09 00:16:37 +00:00
Maurício Meneghini Fauth
e7765efd63
Make some comparisons stricter
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-07-06 15:44:31 -03:00
Kamil Tekiela
32a054c3e3 Remove fetchUploadedFromTblChangeRequestMultiple
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-02-04 23:45:22 +00:00
Kamil Tekiela
8e4443b17b
Applying suggestions from static analysis tools (#19013)
* Drop array keys from lists

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Import UrlTest

When it doesn't exist in Prod, the code will still work the same.
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Drop redundant return [];

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix object access checks

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use strict comparison

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Int keys should be specified as integers

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use empty string check instead of strlen

Potential null deprecations are replaced with loose condition.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use stripos instead of *substr

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify substr's 3rd param

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove unnecessary defaults

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace isZeroBasedArray with array_is_list

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify texEscape()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify exportZeroBasedArray()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace for loop with array_diff

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace for with foreach

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove nullable param in backquoteCompat

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use null-coalescing operator

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Inline $result variable

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Turn $event into a constant

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Move selectDb outside the loop

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix code style order of operation

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove unnecessary isset argument

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove line break

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use foreach instead of for

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-02-27 12:29:02 -03:00
Maurício Meneghini Fauth
fa68771d07
Extract Config to a class property for some classes
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-02-13 22:02:55 -03:00
Kamil Tekiela
79a68a4349
Add type hints instead of mixed (#18976)
* Remove some empty() statements

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix docbloc

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type hint to getHtmlForOneKey()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to buildColumnCreationStatement()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add return type to fetchByMode()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getCompatibilities()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getDirContent

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getCharLists()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to executeSqlQuery()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to findLineNumberAndColumn

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to lint()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getHtmlForNewTables3NF()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getViewsAndCreateSqlViewStandIn()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getPossibleRowFormat()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getTableAltersArray()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getValuesForColumn()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getAvailableMimeTypes()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add types to TwigLintCommand

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to isRowCountApproximated

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getReplicationStatus()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type in formatVariable()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to fetchSingleRow()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getPages()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to CentralColumns::getParams()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to removeRelation()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getWarnings()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getTableCommentsArray()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix docbloc comment

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to sanitizeUrl()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to uploadProgressSetup()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to explodeMarkup()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add types in Table

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getHtmlForDataStatements()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-02-07 19:19:12 -03:00
Kamil Tekiela
f150ed40a9 Update PHPDoc comments
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-01-12 14:57:46 +01:00
Maurício Meneghini Fauth
c2955cc2b2
Rename the directory libraries/classes/ to src/
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-08-30 15:59:28 -03:00