gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
130,785 Commits 12 Branches 481 Tags 2.4 GiB
b30e585d1c
Commit Graph

51 Commits

Author SHA1 Message Date
Kamil Tekiela
42b066be6c Remove unnecessary assignment 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-24 17:13:54 +00:00
Kamil Tekiela
b462cc7090 Remove Config::get() method 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-24 17:13:54 +00:00
Kamil Tekiela
a25527ef8d Refactor loadAndCheck() 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-24 17:12:24 +00:00
Kamil Tekiela
1c5249ab59 Remove OBGzip 
Functionality was removed in 54a080c15d

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-24 17:12:24 +00:00
Kamil Tekiela
410b84ce33 Change PMA_IS_GD2 isGd2Available() method 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-24 17:12:24 +00:00
Kamil Tekiela
6f9cd76f01 Change enable_upload to isUploadEnabled() 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-24 17:12:24 +00:00
Kamil Tekiela
1af9a6ca13 Create Util::getUploadSizeInBytes() 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-24 17:12:24 +00:00
Kamil Tekiela
2fd793f53a Create UserAgentParser class 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-24 17:12:24 +00:00
Kamil Tekiela
ed2d66a6ca Convert CheckConfigurationPermissions to $config 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-24 17:12:24 +00:00
Kamil Tekiela
346f7705f8 Convert GD2Available to $config 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-24 17:12:23 +00:00
Kamil Tekiela
f45080b091 Change PMA_IS_WINDOWS to isWindows() method 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-24 17:12:23 +00:00
Kamil Tekiela
9a96816168 Convert CookieSameSite to $config 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-24 17:12:23 +00:00
Kamil Tekiela
0301790369 Convert TempDir to $config 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-24 17:12:23 +00:00
Kamil Tekiela
5ae628088e Convert PmaAbsoluteUri to $config 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-24 17:12:23 +00:00
Kamil Tekiela
017cdd92cd Untangle $isHttps 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-24 17:12:23 +00:00
Kamil Tekiela
0c7529fa54 Create userPreferences property 
This is not part of the config.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-24 17:12:23 +00:00
Kamil Tekiela
6e8388eb15 Convert DefaultConnectionCollation 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-24 17:12:23 +00:00
Kamil Tekiela
ca4490323d Convert OBGzip to $config 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-24 17:12:23 +00:00
Kamil Tekiela
6905d9175d Avoid array_replace_recursive when no config was loaded 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-24 17:12:23 +00:00
Kamil Tekiela
0a6389c5af Improve performance in setUserValue 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-24 17:12:23 +00:00
Kamil Tekiela
aadd4a2d9a Move renderFooter & renderHeader to more appropriate classes 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-24 17:12:23 +00:00
Kamil Tekiela
2965b821c0 Improve getTempDir() 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-24 17:12:23 +00:00
Kamil Tekiela
afb806b181 Untangle $source 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-24 17:12:23 +00:00
Kamil Tekiela
9a6fef7e65 Remove $this->sourceMtime = 0; 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-24 17:12:23 +00:00
Kamil Tekiela
35b50c73e4 Rename checkConfigSource 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-24 17:12:23 +00:00
Kamil Tekiela
e994e2db58 Refactor config file loading 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-24 17:12:23 +00:00
Kamil Tekiela
4b97cdd1b9 Refactor ThemeManager 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-03 18:52:11 +00:00
Maurício Meneghini Fauth
5548f8fe5b
Replace lang global var with Current::$lang prop 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2024-12-24 12:01:03 -03:00
Kamil Tekiela
8015e4de72 Move DatabaseInterface to Dbal 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-12-22 18:34:53 +00:00
Kamil Tekiela
2756f27249 Add dedicated methods for is_setup 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-12-04 23:16:15 +00:00
Kamil Tekiela
17de1bdf93 Add a type cast to match tested expectation 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-12-03 17:27:13 +00:00
Maurício Meneghini Fauth
57104b4a3a
Move Language::active() to LanguageManager class 
This method does not belong to the Language value object.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2024-11-02 13:29:03 -03:00
Maurício Meneghini Fauth
c2b1e312b7
Move Language and LanguageManager into I18n namespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2024-10-31 18:52:01 -03:00
Kamil Tekiela
70f7682425 Add native true type 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-08-16 11:56:22 +02:00
Maurício Meneghini Fauth
dc1bd60dd1
Fix boolean usage of the return value of preg_match() 
preg_match() and preg_match_all() returns the number of pattern matches
(which might be zero), or false on failure. However, preg_match() always
returns 1 when a pattern is matched as it stops searching after the
first match.

- https://www.php.net/manual/en/function.preg-match.php
- https://www.php.net/manual/en/function.preg-match-all.php

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2024-07-13 14:43:05 -03:00
Maurício Meneghini Fauth
ad5d50d840
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2024-06-16 20:22:38 -03:00
Kamil Tekiela
54b5464ec2 Replace function casts with normal casts 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-03-03 15:07:57 +01:00
Kamil Tekiela
8e4443b17b
Applying suggestions from static analysis tools (#19013) 
* Drop array keys from lists

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Import UrlTest

When it doesn't exist in Prod, the code will still work the same.
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Drop redundant return [];

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix object access checks

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use strict comparison

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Int keys should be specified as integers

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use empty string check instead of strlen

Potential null deprecations are replaced with loose condition.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use stripos instead of *substr

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify substr's 3rd param

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove unnecessary defaults

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace isZeroBasedArray with array_is_list

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify texEscape()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify exportZeroBasedArray()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace for loop with array_diff

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace for with foreach

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove nullable param in backquoteCompat

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use null-coalescing operator

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Inline $result variable

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Turn $event into a constant

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Move selectDb outside the loop

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix code style order of operation

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove unnecessary isset argument

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove line break

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use foreach instead of for

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-02-27 12:29:02 -03:00
Maurício Meneghini Fauth
3353b47721
Create ConnectionType enum 
Replaces Connection::TYPE_* constants with ConnectionType enum.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2024-01-29 12:47:15 -03:00
Kamil Tekiela
822ebbfe59 Remove unnecessary parentheses 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-01-12 15:26:31 +01:00
Kamil Tekiela
f150ed40a9 Update PHPDoc comments 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-01-12 14:57:46 +01:00
Kamil Tekiela
bccbda7249 Small code quality fixes 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-01-12 14:57:46 +01:00
Kamil Tekiela
349ae8de27 Replace mb_strstr 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-01-11 23:43:58 +01:00
Maurício Meneghini Fauth
e41f3110fe Add unit test for ChangeLogController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2024-01-04 12:46:03 -03:00
Maurício Meneghini Fauth
1129750eee
Replace server global with Current::$server 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-12-24 02:08:50 -03:00
Kamil Tekiela
1995c4f312 Revert commit 0e344b6 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-12-07 02:15:44 +01:00
Kamil Tekiela
e90cfe584f Change method name 
This method doesn't sanitize anything. While it does format the message into HTML, it doesn't remove or clean anything. What it does is replace BB codes into HTML.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-12-02 00:10:16 +01:00
Kamil Tekiela
d3ee2d07b8 Remove dead code 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-11-28 13:17:01 +01:00
Maurício Meneghini Fauth
1ae995b9f1
Refactor the Core::getenv() method 
Renames it to getEnv() and adds unit tests for it.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-09-28 16:09:46 -03:00
Maurício Meneghini Fauth
f7a82ce698
Deprecate Config::getInstance() method 
Dependency injection should be used instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-09-02 12:30:28 -03:00