gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
125,615 Commits 12 Branches 481 Tags 2.4 GiB
b4f9063ceb
Commit Graph

82 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
4ff3724c3f
Use union with null instead of short nullable type 
Since union type are now possible, using union with null makes more
clear that it is a union type.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-20 21:48:19 -03:00
Maurício Meneghini Fauth
785f8c1c00
Use constructor property promotion where possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-20 19:39:02 -03:00
Maurício Meneghini Fauth
613678f8f5
Replace assignments with null coalesce equal operator 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-20 17:03:05 -03:00
Kamil Tekiela
8a1d6f1eaa Convert var annotations to typed properties 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-12 21:31:04 +00:00
Kamil Tekiela
f7524fd3b9
Minor code refactoring of Privileges.php (#17993) 
* Small fixes
* Replace escapeString with quoteString
This also fixes bug with $_POST['old_username'].
* Add userExists() method
* Merge if statements
* Use ServerRequest for $initial
* Extract getExportPageTitle from getExportUserDefinitionTextarea
* Update baselines
* Complete redesign of getCurrentAuthenticationPlugin()
* Add method getEmptyUserNotice()
* Remove redundant variable sets and unsets
* Add method checkStructureOfPrivilegeTable()
* Remove testGetHtmlForViewUsersError()
* Privatize getAddUserHtmlFieldset
* Improve tests for mysql.user table checks

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-01-28 20:40:30 -03:00
Kamil Tekiela
7a22334167
Designer controller globals (#17985) 
* Remove globals from DesignerController
* Remove $GLOBALS['params'] in ManageController
* Remove $GLOBALS['params']
* Remove $GLOBALS['total_num_tables']
* Remove $GLOBALS['tooltip_truename']
* Remove $GLOBALS['tooltip_aliasname']
* Remove $GLOBALS['pos']
* Remove $GLOBALS['tables'] (partially)
* Remove $GLOBALS['num_tables'] (partially)
* Remove redundant calls to Util::getDbInfo()
* Move unrelated functionality out of getDbInfo()
* Extract new method getTableListPosition()
* Code style changes
* Update phpstan-baseline.neon

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-01-26 22:58:24 -03:00
Kamil Tekiela
55a6f09ce8
Server privileges controller globals removal (#17986) 
* $GLOBALS['url_dbname']
* $GLOBALS['grants'], $GLOBALS['one_grant']
* $GLOBALS['export']
* $GLOBALS['title']
* $GLOBALS['itemType']
* $GLOBALS['_add_user_error']
* $GLOBALS['queries_for_display']
* $GLOBALS['ret_queries']
* $GLOBALS['ret_message']
* $GLOBALS['queries']
* Remove redundant code
* $GLOBALS['password']
* $GLOBALS['dbname_is_wildcard']
* $GLOBALS['db_and_table']
* $GLOBALS['routinename']
* $GLOBALS['tablename']
* $GLOBALS['post_patterns']
* Update psalm-baseline.xml

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-01-26 11:46:20 -03:00
Maurício Meneghini Fauth
1d37607132
Update PHPStan/Psalm baselines 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-01-11 00:22:48 -03:00
ru-asdx
3663fed7ad
Ref #17769 - Replace superglobals with serverrequest in PrivilegesController (#17977) 
* replace superglobals with serverrequest

Signed-off-by: Evgeny Skorlov <eugene@skorlov.name>
 2023-01-10 21:15:39 -03:00
Kamil Tekiela
dd699f348d Clean up LIKE escaping 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-11-25 00:06:52 +00:00
Maurício Meneghini Fauth
97aac39a40
Remove the sub_part global variable 
It's only used inside Util::getDbInfo() for pagination when not
exporting.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-07 22:06:59 -03:00
Maurício Meneghini Fauth
eb3703882b
Move Routing::getCurrentRoute to ServerRequest 
The route is retrieved from the request, so it makes sense to move the
method to the Http\ServerRequest class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-06-06 23:36:57 -03:00
Maurício Meneghini Fauth
d58057daec
Extract Database\PrivilegesController from Server\PrivilegesController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-27 17:13:23 -03:00
Maurício Meneghini Fauth
dc5bf0074c
Extract Table\PrivilegesController from Server\PrivilegesController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-27 16:25:39 -03:00
Maurício Meneghini Fauth
6201c7f2ba
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-27 13:27:59 -03:00
Maurício Meneghini Fauth
229d99bb81
Fix checking db and table privileges when case is sensitive 
Fixes https://github.com/phpmyadmin/phpmyadmin/issues/17558

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-05-26 16:05:58 -03:00
Maurício Meneghini Fauth
5950693fb3
Fix possible undefined globals 
Related to https://github.com/phpmyadmin/phpmyadmin/pull/17427.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-10 18:05:21 -03:00
Maurício Meneghini Fauth
1438cb211e
Replace global keyword with $GLOBALS 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-07 17:31:11 -03:00
Maurício Meneghini Fauth
5a34a3bb04
Remove db and table properties from controllers 
Replaces them with their respective globals.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-02-02 14:48:43 -03:00
Maurício Meneghini Fauth
d84af02945
Create VO classes for each RelationParameters features 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-26 19:17:58 -03:00
Maurício Meneghini Fauth
c411121fd8
Move Relation classes into the ConfigStorage namespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-17 12:09:13 -03:00
Maurício Meneghini Fauth
c4575fd48b
Add methods to check for RelationParameters features 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-11 08:10:40 -03:00
Kamil Tekiela
253b08330d Make $subPart non-nullable and remove redundant ?? when it's not null 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-03 19:36:06 +00:00
Kamil Tekiela
9245cec290 Fix type issues in PrivilegesController 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-01 13:20:08 +00:00
Maurício Meneghini Fauth
b2a51c4d84
Create the RelationParameters value object 
Replaces the $cfgRelation array with the RelationParameters value
object.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-11-14 18:22:36 -03:00
Maurício Meneghini Fauth
f00d70cccb
Remove useless whitespaces 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-15 17:05:40 -03:00
Maurício Meneghini Fauth
3531775b7c
Add type declarations to the controllers contructors 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-11 17:32:22 -03:00
Maurício Meneghini Fauth
a2ed4dfe68
Make controllers callable 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-08-30 13:16:29 -03:00
William Desportes
8aa4e30512
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-29 03:16:09 +02:00
William Desportes
4b9a9628f3
Merge #17045 - Fix #11834 - Fixing the issues regarding granting/showing priv from priv tab 
Pull-request: #17045
Fixes: #11834

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-29 02:52:09 +02:00
Fawzi E. Abdulfattah
3f985e2124 Fixing the issues regarding granting and showing the privileges from the privileges tab 
Signed-off-by: Fawzi E. Abdulfattah <iifawzie@gmail.com>
 2021-07-28 17:26:01 +02:00
Fawzi E. Abdulfattah
84e9b611a6 fixing the links when granting privileges on tables or routines 
Signed-off-by: Fawzi E. Abdulfattah <iifawzie@gmail.com>
 2021-07-28 03:42:02 +02:00
William Desportes
c5a1dd2ec7
Merge #16925 - Replace Export privileges group dialog with a modal 
Pull-request: #16925

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-27 03:26:32 +02:00
William Desportes
ab2e5358f7
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-21 18:49:19 +02:00
Fawzi E. Abdulfattah
68981b78d7 Fixing all the issues related to assigning privileges 
Signed-off-by: Fawzi E. Abdulfattah <iifawzie@gmail.com>
 2021-07-17 02:49:07 +02:00
William Desportes
c830c1e93a
Merge branch 'origin/QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-15 02:34:29 +02:00
William Desportes
f490ee8867
Fix a coding standard mistake 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-15 00:49:21 +02:00
William Desportes
8500a6c5a1
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-13 22:43:26 +02:00
William Desportes
7c17889d78
Ref #17010 - Fix #16994 - Be sure to always pass a string value 
Pull-request: #17010
Ref: #16994

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-13 22:29:47 +02:00
Fawzi E. Abdulfattah
5005c38d9d Fixing the issue when assigning database to user with '_' 
Signed-off-by: Fawzi E. Abdulfattah <iifawzie@gmail.com>
 2021-07-13 21:25:15 +02:00
Maurício Meneghini Fauth
9adaa912e1
Rename Response class to ResponseRenderer 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-30 12:35:22 -03:00
Guileas
135b116f2f
Replace zxcvbn by zxcvbn-ts 
Signed-off-by: Gwénola ETHEVE <git@etheve.eu>

Update package.json

Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-23 23:49:24 +02:00
Maurício Meneghini Fauth
1c084de30b
Fix coding standard errors 
Related to 62f142c9fa.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-03 16:50:33 -03:00
Saksham Gupta
25005d30e8 Replace Export privileges group dialog with a modal 
Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Add functionality for table and database

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Add line

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Code fix

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Code fix 2

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Convert export priviliege user specific

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Cleanup reused code

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Fix lint

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Add parameter types

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Remove $ from $msgbox variable

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Comment fix

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Remove redundant functions

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Remove else condition

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Fix race condition

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Fix race condition

Signed-off-by: Saksham Gupta <shucon01@gmail.com>
 2021-06-01 19:52:13 +05:30
Maurício Meneghini Fauth
cd1b8a9b77
Fix some errors found by PHPStan and Psalm 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-05-22 15:14:24 -03:00
Maurício Meneghini Fauth
5750dfb1bb
Extract method to get edit user group modal form 
Creates a new route: /server/user-groups/edit-form

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-04-26 22:59:09 -03:00
William Desportes
8fbb01a684
Merge branch 'origin/QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-19 21:51:45 +02:00
William Desportes
f741d7b6c1
Merge #16809 - Fix #16404 - Password generation fix after new user creation failure 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-19 21:11:55 +02:00
Saksham Gupta
9a9b7ad335 Fix #16404 Password generation fix after new user creation failure 
Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Check error on SQL query

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Lint fix

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Add comments

Signed-off-by: Saksham Gupta <shucon01@gmail.com>
 2021-04-15 20:34:35 +05:30
Maurício Meneghini Fauth
4273634c17
Extract getActiveAuthPlugins method to Plugins class 
Extracts the getActiveAuthPlugins method from the
PhpMyAdmin\Server\Privileges class to the PhpMyAdmin\Server\Plugins
class, rename it to getAuthentication and adds tests.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-04-14 16:07:40 -03:00