Commit Graph

91 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
4ff3724c3f
Use union with null instead of short nullable type
Since union type are now possible, using union with null makes more
clear that it is a union type.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-20 21:48:19 -03:00
Maurício Meneghini Fauth
48f671d956
Replace get_class() with ::class constant
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-20 18:58:13 -03:00
Kamil Tekiela
80c4db7253 Use strict check when type is known
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-02-19 23:19:54 +00:00
Kamil Tekiela
b6f0da1c09 Convert to first class callables
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-02-14 14:18:23 +00:00
Kamil Tekiela
8a1d6f1eaa Convert var annotations to typed properties
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-02-12 21:31:04 +00:00
Maurício Meneghini Fauth
930f8826d3
Remove dead code for old PHP versions
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-12 13:59:40 -03:00
Maurício Meneghini Fauth
729b21b911
Extract Functions.ignorePhpErrors() into a module
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-10 19:24:20 -03:00
Maurício Meneghini Fauth
3bc3c7de4d
Extract Functions.ajaxShowMessage() into ajax-messages.js
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-12-06 08:21:58 -03:00
Kamil Tekiela
0e59b1a2c0 Redundant $error instanceof Error
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-15 21:16:04 +01:00
Maurício Meneghini Fauth
6a5cb9f66e
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-26 17:30:39 -03:00
Maurício Meneghini Fauth
9d7582a2c0
Hide deprecation notices
Do not show deprecation notices when not in a development environment.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-26 16:27:00 -03:00
Maurício Meneghini Fauth
e4ea2308c0
Assign Messages global var to the window object
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-02 11:23:07 -03:00
Maurício Meneghini Fauth
a4f8c18808
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-05-20 14:48:45 -03:00
Maurício Meneghini Fauth
827e32a92e
Improve ErrorHandler::handleException to show errors
It doesn't shows a blank page when not in development environment
anymore.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-05-19 20:56:24 -03:00
Maurício Meneghini Fauth
2c5143feda Remove ResponseRenderer::getFooter method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-04-09 12:32:14 -03:00
Maurício Meneghini Fauth
1438cb211e
Replace global keyword with $GLOBALS
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-07 17:31:11 -03:00
Maurício Meneghini Fauth
d1b99c4a15 Fix merge conflicts
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-11 10:07:02 -03:00
Isaac Bennetch
5127b31144 Fix merge conflicts
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2022-02-10 23:38:23 -05:00
Maurício Meneghini Fauth
c04f85f2bb Fix path disclosure on misconfigured servers
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-10 20:59:06 -06:00
Maurício Meneghini Fauth
f00d70cccb
Remove useless whitespaces
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-15 17:05:40 -03:00
Maurício Meneghini Fauth
9f3510d11a
Add bool return type where possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-14 20:11:51 -03:00
William Desportes
8d19bef81d
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-08-22 23:19:15 +02:00
William Desportes
38c263359e
Ref #17084 - comment the code and add a new test case
And fix the modified test

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-08-20 02:30:02 +02:00
Craig McNeill
af835bc52c Fix ErrorHandler sliceErrors not returning errors
Signed-off-by: Craig McNeill <craig@mmddata.ca>
2021-08-18 14:40:52 -04:00
Maurício Meneghini Fauth
04d3c83559
Fix some errors found by PHPStan/Psalm
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-08-05 16:09:08 -03:00
Maurício Meneghini Fauth
9adaa912e1
Rename Response class to ResponseRenderer
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-30 12:35:22 -03:00
Maurício Meneghini Fauth
1c084de30b
Fix coding standard errors
Related to 62f142c9fa.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-03 16:50:33 -03:00
Maurício Meneghini Fauth
9c32a55def
Turn errors into exceptions when in development env
Changes error messages into ErrorException when using
`$cfg['environment'] = 'development';`.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-03 11:53:54 -03:00
Maurício Meneghini Fauth
3d539b78e6
Merge branch 'QA_5_1'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-27 16:07:09 -03:00
Maurício Meneghini Fauth
6b0a10d8ca
Rename the error_handler global to use camel case
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-16 12:11:51 -03:00
William Desportes
8992ef095f
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-14 11:54:03 +01:00
William Desportes
c4c32c374d
Fix #16729 - fix silencing code for PHP >= 8.0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-12 19:23:03 +01:00
Maurício Meneghini Fauth
d83abf63e7
Use PSR-12 for control structures spacing
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 15:27:03 -03:00
Maurício Meneghini Fauth
0b8edc5bde
Use PSR-12 for namespace use statements
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 14:18:35 -03:00
Maurício Meneghini Fauth
4f574e53c3
Replace error report jquery-ui's dialog with a modal
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-12 17:28:23 -03:00
Maurício Meneghini Fauth
00151b5f1c
Remove some custom CSS utilities
Uses Bootstrap equivalents instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-12-22 13:18:58 -03:00
Maurício Meneghini Fauth
db3da81056 Remove some useless comments
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-13 19:56:56 -03:00
Maurício Meneghini Fauth
e66be179ca Use camel case naming for class members
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-05 10:37:07 -03:00
William Desportes
bcf21c4081
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-07-28 18:12:30 +02:00
William Desportes
0e344b6a50
Fix #16256 - Warning: error_reporting() has been disabled for security reasons on php 7.x
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-07-25 19:49:52 +02:00
Maurício Meneghini Fauth
3f01cd8c13 Remove Message::display method
Related to https://github.com/phpmyadmin/phpmyadmin/issues/16258.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-20 19:43:46 -03:00
Maurício Meneghini Fauth
3b285ff17e Use identical operator for non-empty strings
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-10 18:06:29 -03:00
Maurício Meneghini Fauth
f4582e083e Use early exit when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
bd979dd1ff Remove useless elseif with if
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 22:53:44 -03:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
a64393e7f5 Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-13 00:23:28 -03:00
William Desportes
0cbba2aef2
Add some properties typehints
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-02 01:41:59 +02:00
Isaac Bennetch
6efdd77483 Merge branch 'QA_5_0' 2020-03-20 22:50:16 -04:00
Isaac Bennetch
0d4c7c66a5 Merge branch 'QA_4_9' into QA_5_0 2020-03-20 22:01:14 -04:00
Maurício Meneghini Fauth
13e6a01838 Add support for E_USER_DEPRECATED in the error handler
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-17 19:37:31 -03:00