Commit Graph

69 Commits

Author SHA1 Message Date
Michal Čihař
b82e706dcb Share post connect code between DBIs
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 10:12:55 +02:00
Michal Čihař
9e8505ff5e Factor out socket/port parsing for connecting database
Almost same code was used in three DBIs, so let's share it.

Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 10:01:35 +02:00
Michal Čihař
4443209707 Do not call DBI->postConnect for control link
It used to just return, so there is no sense in calling it at all.

Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 09:41:56 +02:00
Michal Čihař
69a9cb1e58 Share logic for calling postConnect method
This should be called on success, when we're creating primary
connection.

Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 09:41:56 +02:00
Michal Čihař
510825c97e Share implementation of insertId among DBIs
There is no need to have the method implemented three times.

Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 09:21:11 +02:00
Hugues Peccatte
5306fcc9c6 Minor coding style fixes.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-05-08 21:51:24 +02:00
Michal Čihař
eb29ddeba8 Remove never used parameter of cacheSet
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-08 17:37:40 +02:00
Michal Čihař
283ee59316 Remove never used parameter of cacheExists
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-08 17:37:40 +02:00
Michal Čihař
79bcd54610 Remove never used parameter of cacheGet
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-08 17:37:40 +02:00
Michal Čihař
8a731a80cb Do not hardcode mysqli in the interface library
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-08 17:37:40 +02:00
Michal Čihař
dc0905a0c4 Check whether we got valid result before trying to use it
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-08 17:03:40 +02:00
Michal Čihař
c869983f11 Remove unused support for fetchResult getting MySQL result
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-08 15:28:49 +02:00
Michal Čihař
98c7ac94db Remove unused support for fetchSingleRow getting MySQL result
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-08 15:27:07 +02:00
Michal Čihař
862541d000 Remove unused support for fetchValue getting MySQL result
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-08 15:24:27 +02:00
Michal Čihař
e47566f9fd Fix code docblocks
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-08 15:22:21 +02:00
Hugues Peccatte
9d059ee7a8 Minor PHPCS corrections.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-02-01 17:30:13 +01:00
Marc Delisle
964ea23fa0 Unused parameter
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-01-27 09:17:36 -05:00
Marc Delisle
2df3184d3a Fix coding style
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-01-26 09:25:31 -05:00
Marc Delisle
3d72b1cc87 Fix typos
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-01-24 08:24:14 -05:00
Marc Delisle
2881877f87 Refactor: new _cacheTableData()
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-01-18 07:58:58 -05:00
Marc Delisle
5a64dfe092 Refactor: new _getSqlForTablesFull()
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-01-13 10:40:44 -05:00
Chanaka Indrajith
d2bb285390 Fixed long line
Signed-off-by: Chanaka Indrajith <pe.chanaka.ck@gmail.com>
2014-01-11 22:59:55 +05:30
Marc Delisle
3e011150fd Refactor: new _getTableCondition()
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-01-10 08:47:22 -05:00
Marc Delisle
f1bc750a88 Merge branch 'QA_4_1' 2014-01-09 08:11:51 -05:00
Madhura Jayaratne
09b0f9e60f bug #4224 Empty table names when a table is "inuse"
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-01-09 16:58:46 +05:30
Madhura Jayaratne
6335b10574 Fix coding style
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-01-08 14:35:15 +05:30
Marc Delisle
e8b9296a78 Merge branch 'QA_4_1' 2014-01-07 08:42:01 -05:00
Ben Walter
fb4ba11d14 bug #4215 MariaDB 5.5: error in Drizzle detection
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-01-07 08:22:51 -05:00
Hugues Peccatte
8665639bb0 Review of modifications
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-01-05 11:05:32 +01:00
Hugues Peccatte
6b01f835cb Rename too short variables.
Remove useless initializations.
Rename too long variables.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-01-04 20:46:18 +01:00
Madhura Jayaratne
53c72f42cb Merge branch 'QA_4_1' 2014-01-04 15:10:39 +05:30
Madhura Jayaratne
8bab3325b3 Size = Data_length + Index_length
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-01-04 15:00:01 +05:30
Hugues Peccatte
37f90df60d Fix PHPCS errors.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2013-12-20 23:34:52 +01:00
Hugues Peccatte
7bd1bf23d3 Fix PHPCS errors.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2013-12-11 22:13:10 +01:00
Marc Delisle
f7b99962bb bug #2983 unknown table status: TABLE_TYPE 2013-11-14 09:21:22 -05:00
Hugues Peccatte
464ec23ad8 Huge PHPDoc update. 2013-11-10 23:04:58 +01:00
Marc Delisle
4905240aed The DisableIS directive is being deprecated 2013-11-03 07:00:00 -05:00
Marc Delisle
60938c67fa The DisableIS directive is being deprecated 2013-11-03 06:27:02 -05:00
Marc Delisle
3065a3edcf The DisableIS directive is being deprecated 2013-11-01 12:49:54 -04:00
Marc Delisle
b0962e8fd8 The DisableIS directive is being deprecated 2013-11-01 08:24:54 -04:00
Marc Delisle
d2b697ec02 Fix typo 2013-10-17 06:32:41 -04:00
Marc Delisle
bb923e6fb4 Fix typo 2013-10-03 11:25:09 -04:00
Madhura Jayaratne
91d91828fe Generate correct TableIndexesSql for Drizzle 2013-10-02 22:28:04 +05:30
Madhura Jayaratne
9129a60210 Drizzle compatibility 2013-09-28 20:11:53 +05:30
Madhura Jayaratne
e848b29a88 selecting tables by comment does not seem to be used anywhere. If you need to get the list of views, use new $tble_type parameter. 2013-09-22 22:09:38 +05:30
Madhura Jayaratne
190725ce27 Clicking on 'Tables' links in navigation tree should show only tables 2013-09-22 21:29:52 +05:30
Madhura Jayaratne
f3edd98a15 Use type hinting 2013-08-27 22:07:43 +05:30
Madhura Jayaratne
e72bcb697f Add type 2013-08-27 21:37:19 +05:30
Michal Čihař
81869b6b54 Automatic switch to utf8mb4 collation 2013-08-15 11:56:04 +02:00
Michal Čihař
fb30c148f2 Default to utf8mb4 for new MySQL versions 2013-08-15 11:49:13 +02:00