Commit Graph

122 Commits

Author SHA1 Message Date
William Desportes
8992ef095f
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-14 11:54:03 +01:00
William Desportes
c62e27d650
Fix #16724 - Remove old unstable code to make column order work
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-13 01:19:58 +01:00
Maurício Meneghini Fauth
33d711215d
Remove the PMA_VERSION constant
Uses the PhpMyAdmin\Version::VERSION constant instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-08 22:22:55 -03:00
Maurício Meneghini Fauth
7e33d227f5
Rename the PMA_Config global variable to config
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-08 15:03:12 -03:00
Maurício Meneghini Fauth
0b8edc5bde
Use PSR-12 for namespace use statements
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 14:18:35 -03:00
William Desportes
c5155ecae9
Refactor field flags to use an object an not strpos
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-24 23:56:33 +01:00
Maurício Meneghini Fauth
ac4bfaebe7
Remove some custom CSS utilities
Uses Bootstrap equivalents.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-12-26 20:05:03 -03:00
Maurício Meneghini Fauth
d3c31fabd4
Remove some custom CSS utilities
Uses Bootstrap equivalents.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-12-23 19:06:38 -03:00
William Desportes
bc45a05dcd
Typo fixes in the JS codebase with VS code "code spell checker"
And coding standard issues from pull-request #16364
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-11-12 23:27:57 +01:00
Petr Duda
eeaf18cfb3
Fix #16095 - Add test cases for displaying results in non-numeric columns
Signed-off-by: Petr Duda <petrduda@seznam.cz>
2020-11-02 09:28:22 +01:00
Petr Duda
2c7b7046e2
Fix #16095 - Leading space not shown in a CHAR column
Signed-off-by: Petr Duda <petrduda@seznam.cz>
2020-11-02 09:28:04 +01:00
Maurício Meneghini Fauth
db3da81056 Remove some useless comments
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-13 19:56:56 -03:00
Maurício Meneghini Fauth
75397c913d Refactor Display\Export class
- Uses template inheritance for the export templates.
- Renames Display\Export to Export\Options.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-03 23:56:20 -03:00
Maurício Meneghini Fauth
4cbf018db3 Merge Display\Export::getDisplay templates
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-03 18:21:53 -03:00
Maurício Meneghini Fauth
3a84b184b3 Extract HTML from Display\Export::getDisplay
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-03 16:47:04 -03:00
Maurício Meneghini Fauth
d9dc188592 Merge templates for Display\Export::getHtmlForOptions
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-31 20:30:21 -03:00
Maurício Meneghini Fauth
0e3a82bd86 Remove Display\Error class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-29 23:08:29 -03:00
Maurício Meneghini Fauth
d0716e9d31 Remove Display\CreateTable::getHtml
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-29 21:49:55 -03:00
Maurício Meneghini Fauth
c92663adbb Move ChangePassword::getHtml to Server\Privileges class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-29 19:12:35 -03:00
Maurício Meneghini Fauth
904d8f99c6 Merge Display\ChangePassword template files
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-29 17:57:55 -03:00
Maurício Meneghini Fauth
2358b9c4f9 Fix missing property type hints
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-22 21:42:22 -03:00
William Desportes
ce6a12bf56
Remove more typehints as object for php 7.1
Ref: a80153a633
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-07-18 00:44:06 +02:00
William Desportes
0340f66740
Fix some tests having wrong typehints
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-07-17 23:55:49 +02:00
William Desportes
a80153a633
Add typehints using phpcbf on test/*
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-07-17 22:52:42 +02:00
Maurício Meneghini Fauth
0d7aab823c Remove __get and __set magic methods from Results
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-11 02:25:18 -03:00
Maurício Meneghini Fauth
47f0960dce Add return type declaration to test methods
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-07 11:31:33 -03:00
William Desportes
bd4d353d63
Fix coding-standard issues after the merge of #16192
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-15 13:59:32 +02:00
William Desportes
7e5dd8eba0
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-15 13:15:31 +02:00
William Desportes
14211e6118
Fix twig imports using old PSR-1 style
Ref: 273b666a71
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-14 22:55:55 +02:00
Maurício Meneghini Fauth
2937e9796d Remove underscore prefix from some method names
Related to #16149

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-30 17:20:43 -03:00
William Desportes
4d61ef2313
Split some code out of DatabaseInterface
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-26 13:18:01 +02:00
Maurício Meneghini Fauth
3ae05c785d Use short list syntax and single line arrays
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 03:32:59 -03:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
9269d75fb4 Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 20:22:18 -03:00
William Desportes
49a6d6e8d0
Use AbstractTestCase instead of PmaTestCase for all tests not needing mockResponse
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-22 01:45:50 +02:00
William Desportes
7e81b0b3d7
Merge callProtectedMethod and callPrivateFunction into callFunction
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 22:59:29 +02:00
William Desportes
ae575ffb14
Fix running tests in --process-isolation
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 16:21:20 +02:00
William Desportes
0964470643
Use parent::setGlobalConfig();
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 13:19:23 +02:00
William Desportes
8f7d3d1fa7
Fix test cases after backupGlobals = false
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 02:07:45 +02:00
William Desportes
6eaa55e805
Call parent's setUp and tearDown
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 21:31:13 +02:00
William Desportes
8ef5143901
Use AbstractTestCase on all unit tests
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 21:15:06 +02:00
William Desportes
0b2c24ee26
Use ::class in tests
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 12:15:40 +02:00
William Desportes
f2ac6644b0
Fix ResultsTest::testGetTableNavigationButton
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-16 00:29:54 +02:00
Maurício Meneghini Fauth
a64393e7f5 Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-13 00:23:28 -03:00
Maurício Meneghini Fauth
ec7d53af55 Extract HTML from table rows checkbox and links
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-23 20:26:26 -03:00
Maurício Meneghini Fauth
19406efd89 Extract HTML from results bulk action checkbox
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-23 16:04:04 -03:00
Maurício Meneghini Fauth
22ee68b163
Fix Display\ResultsTest test on Windows
Cherry-picked-from: b2d1615176

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-28 11:37:04 +01:00
Maurício Meneghini Fauth
b2d1615176 Fix Display\ResultsTest test on Windows
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-25 17:30:03 -03:00
William Desportes
191a0a06ec
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-03-24 22:53:35 +01:00
Isaac Bennetch
095cb4d5a2 Fix phpcs test errors
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2020-03-22 23:08:22 -04:00