Maurício Meneghini Fauth
17dfe02004
Merge branch 'QA_5_1'
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-02-11 23:00:27 -03:00
Maurício Meneghini Fauth
eb2d865740
Set MySQLi error reporting mode
...
Explicitly sets the MySQLi error reporting mode to the current default
to avoid possibly future changes.
Fixes https://github.com/phpmyadmin/phpmyadmin/issues/16589
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-02-11 09:53:27 -03:00
William Desportes
2bc0b80cb9
Fix a phpdoc block and a coding standard issue
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-01-31 01:23:46 +01:00
William Desportes
b9d5fc72d2
Merge branch 'QA_5_1'
...
The fix for #11505 is excluded
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-01-28 16:14:00 +01:00
William Desportes
dc14f7685b
Merge #16581 - Fix PHP Uncaught TypeError: htmlspecialchars()
...
Pull-request: #16581
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-01-28 15:57:58 +01:00
Tarjei Huse
21d7cc5575
Fix "PHP message: PHP Fatal error: Uncaught TypeError: htmlspecialchars() expects parameter 1 to be string, bool given in /usr/share/phpmyadmin/libraries/classes/Config/FormDisplayTemplate.php:306
...
"PHP message: PHP Fatal error: Uncaught TypeError: htmlspecialchars() expects parameter 1 to be string, bool given in /usr/share/phpmyadmin/libraries/classes/Config/FormDisplayTemplate.php:306"
Signed-off-by: Tarjei Huse <tarjei.huse@gmail.com>
2021-01-28 15:52:12 +01:00
William Desportes
98fb87a09a
Split Descriptions into 3 functions
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-01-28 15:37:30 +01:00
Maurício Meneghini Fauth
53f5247811
Merge FormDisplay::getDisplay templates
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-05 19:25:21 -03:00
Maurício Meneghini Fauth
1911ac6289
Remove Config\FormDisplay dep from Setup\HomeController
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-03 22:38:27 -03:00
Maurício Meneghini Fauth
d8c1d6e7a1
Extract HTML from FormDisplayTemplate::displayInput
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-03 18:25:14 -03:00
Maurício Meneghini Fauth
65dd7e8278
Wrap settings tabs with Bootstrap's cards
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-02 18:51:11 -03:00
Maurício Meneghini Fauth
c9ab66170a
Replace Settings page tabs with Bootstrap's tabs
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-12-30 23:20:40 -03:00
Maurício Meneghini Fauth
5178f76f95
Move fieldset CSS style to the .pma-fieldset class
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-12-28 19:46:40 -03:00
Allan Nordhøy
8e02b58f16
Correct language: reCAPTCHA, set up, Internet, URL
2020-11-25 14:24:48 +00:00
William Desportes
cf6f5d5055
Merge #16406 - Fix #16457 - Add config parameters to support third-party reCAPTCHA v2 compatible APIs
...
Fixes : #16457
Pull-request: #16406
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-11-05 00:04:29 +01:00
Saurabh Srivastava
5472b319eb
Fix #15001 - Login cookie validity in settings->features
...
Signed-off-by: Saurabh Srivastava <saurabhsrivastava312@gmail.com>
2020-11-04 23:39:15 +01:00
James Renken
ecbe0dd6d3
Add config parameters to support third-party reCAPTCHA v2 compatible APIs
...
Signed-off-by: James Renken <james@renken.is>
2020-10-23 10:55:00 +02:00
Maurício Meneghini Fauth
e66be179ca
Use camel case naming for class members
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-05 10:37:07 -03:00
Maurício Meneghini Fauth
f2e49a92c6
Fix some type errors detected by PHPStan
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-30 19:23:01 -03:00
Maurício Meneghini Fauth
461cc87521
Remove list templates
...
- templates/list/item.twig
- templates/list/unordered.twig
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-12 20:43:55 -03:00
William Desportes
d63a72ad51
Fixes #16278 - Remove underscore prefix from property names
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-08-06 15:46:39 +02:00
Maurício Meneghini Fauth
2358b9c4f9
Fix missing property type hints
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-22 21:42:22 -03:00
Maurício Meneghini Fauth
652c55a5ef
Remove Config\PageSettings::getNaviSettings method
...
Related to https://github.com/phpmyadmin/phpmyadmin/issues/16258 .
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-12 17:40:19 -03:00
Maurício Meneghini Fauth
f8320956ee
Remove Config\PageSettings::showGroup method
...
Related to https://github.com/phpmyadmin/phpmyadmin/issues/16258 .
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-12 16:01:18 -03:00
Maurício Meneghini Fauth
3b285ff17e
Use identical operator for non-empty strings
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-10 18:06:29 -03:00
Maurício Meneghini Fauth
e81146e4b3
Remove useless return annotations
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-07 10:30:27 -03:00
Maurício Meneghini Fauth
b30f06455c
Remove the blacklist/whitelist terminology
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-06-15 17:51:24 -03:00
Maurício Meneghini Fauth
2529824c23
Extract change column action from table structure index method
...
Related to #16136
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-06-08 18:20:48 -03:00
charliewindred
ca3c5e17b0
Remove underscore prefix from method names
...
Removed underscore from method names for PSR-12 compliance.
Signed-off-by: charliewindred <charliewindred@gmail.com>
2020-06-02 16:44:16 +01:00
Petr Duda
37b22a5c71
Fix #16102 - Broken error message
...
Signed-off-by: Petr Duda <petrduda@seznam.cz>
2020-05-31 17:41:49 +02:00
Maurício Meneghini Fauth
e2eac49ad2
Use closures to call private methods as callback
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-30 13:14:06 -03:00
Maurício Meneghini Fauth
199e3d9813
Fix coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 21:08:55 -03:00
Maurício Meneghini Fauth
f4582e083e
Use early exit when possible
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
82c2964bb8
Remove useless elses
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 22:27:45 -03:00
Maurício Meneghini Fauth
3ae05c785d
Use short list syntax and single line arrays
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 03:32:59 -03:00
Maurício Meneghini Fauth
3baad2eb1c
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
9269d75fb4
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 20:22:18 -03:00
William Desportes
6d123fe452
Some minor codebase fixes and improvements
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-24 15:25:56 +02:00
William Desportes
5195520883
Coding standard fixes
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 02:18:05 +02:00
William Desportes
f063c553f2
Fix some tests executed in random order
...
Using: ./vendor/bin/phpunit --order-by=random --random-order-seed=1589977275 --exclude=selenium --no-coverage --filter=FormDisplayTest
Seeds: 1590000479, 1589977275, 1589998302, x1590001040, x1590001183
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 21:10:32 +02:00
William Desportes
cdb3629da2
Fix some outdated documentation in our codebase and improve it
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 02:06:31 +02:00
William Desportes
73290bcdcf
Merge branch 'QA_5_0'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-19 00:10:11 +02:00
William Desportes
70329729e4
Fix #15996 - local setup doc links are broken, us the right links in FormDisplay
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-18 23:51:19 +02:00
William Desportes
dfa718c1c6
Merge branch 'QA_5_0'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-17 16:48:09 +02:00
William Desportes
db02eea620
Fix #15996 - local setup doc links are broken
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-17 16:03:13 +02:00
Maurício Meneghini Fauth
80a45fa0ae
Break too long lines
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-16 18:08:20 -03:00
William Desportes
cc981860a7
Coding standard fixes and baselines updates
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-15 23:20:14 +02:00
William Desportes
fcd41f6c85
Remove some mysql extension assertions
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-15 22:17:58 +02:00
Allan Nordhøy
7e98f44dea
Change eg. to e.g.
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-14 13:28:56 +02:00
Maurício Meneghini Fauth
84139f4d51
Remove some useless variables
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-13 16:15:37 -03:00