Commit Graph

198 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
1e5fbd57fc
Create Twig\AssetExtension and image Twig function
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-28 16:09:17 -03:00
Maurício Meneghini Fauth
dbaa031971
Remove jquery.sortableTable.js from js/vendor dir
It is not a vendor file, but a internal file.
Added by commit 1c6a388ca0.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-12-08 21:37:11 -03:00
William Desportes
d860597375
#16418 - Make MariaDBMySQLKBS optional
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-11-10 12:12:56 +01:00
Maurício Meneghini Fauth
ef62d7a9f5 Remove is_system_schema PHP global variable
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-02 18:48:23 -03:00
Maurício Meneghini Fauth
71c2f2d99a Remove is_show_stats PHP global variable
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-02 18:48:23 -03:00
Maurício Meneghini Fauth
6b81080127 Remove Common::server method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-02 18:48:23 -03:00
Maurício Meneghini Fauth
a83ec78ebf Make DatabaseInterface::isUserType method private
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-24 00:40:03 -03:00
Maurício Meneghini Fauth
71d9a8f760 Remove is_grantuser and is_createuser PHP globals
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-23 22:58:49 -03:00
Maurício Meneghini Fauth
db3da81056 Remove some useless comments
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-13 19:56:56 -03:00
Maurício Meneghini Fauth
601ed4649e Remove DBI dep from Table\AbstractController
Moves the DatabaseInterface class dependency to the classes that use it.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-12 12:53:03 -03:00
Maurício Meneghini Fauth
4badaca6d3 Remove DBI dep from Server\Status\AbstractController
Moves the DatabaseInterface class dependency to the classes that use it.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-12 11:15:43 -03:00
Maurício Meneghini Fauth
e7bdd39ae6 Remove DBI dep from Database\AbstractController
Moves the DatabaseInterface class dependency to the classes that use it.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-12 10:46:27 -03:00
Maurício Meneghini Fauth
e6ec9df84e Remove DBI dep from Controllers/AbstractController
Moves the DatabaseInterface class dependency to the classes that use it.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-11 22:48:44 -03:00
Maurício Meneghini Fauth
e66be179ca Use camel case naming for class members
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-05 10:37:07 -03:00
Maurício Meneghini Fauth
f2e49a92c6 Fix some type errors detected by PHPStan
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-30 19:23:01 -03:00
Maurício Meneghini Fauth
40d2a1c605
Merge pull request #16338 from mauriciofauth/replication
Refactor the ReplicationInfo class
2020-09-12 09:07:33 -03:00
Maurício Meneghini Fauth
cd862d4f00 Remove replication_info global variable
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-12 09:04:44 -03:00
Maurício Meneghini Fauth
34dd2a61f8 Remove strPrivDesc* global variables
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-11 17:22:30 -03:00
Maurício Meneghini Fauth
952e2f9ee8 Remove replication_types PHP global
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-08 15:54:02 -03:00
Maurício Meneghini Fauth
3c21cf1853 Remove url_query PHP global
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-08 13:32:25 -03:00
William Desportes
4d7c00a4ce
Merge branch 'QA_5_0'
Closes: #16335
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-09-07 12:25:09 +02:00
Maurício Meneghini Fauth
ceac762e09 Remove pmaThemePath and pmaThemeImage PHP globals
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-02 10:57:57 -03:00
Maurício Meneghini Fauth
55c5c80d37 Rename Display\ImportAjax class
Renames to Import\Ajax.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-20 12:07:54 -03:00
Maurício Meneghini Fauth
fa67657b1a Remove Display\Import class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-20 00:21:26 -03:00
Maurício Meneghini Fauth
28436399dd Extract exit from Display\Import class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-19 02:28:02 -03:00
Maurício Meneghini Fauth
65b79af29e Refactor Plugins::getPlugins method
Replaces parameters with explicit methods.
 - Plugins::getExport
 - Plugins::getImport
 - Plugins::getSchema

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-19 01:40:27 -03:00
Maurício Meneghini Fauth
75397c913d Refactor Display\Export class
- Uses template inheritance for the export templates.
- Renames Display\Export to Export\Options.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-03 23:56:20 -03:00
Maurício Meneghini Fauth
879ae32edc Extract HTML from server, db and table export controllers
- Controllers\Server\ExportController::index
- Controllers\Database\ExportController::index
- Controllers\Table\ExportController::index

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-01 14:08:51 -03:00
Maurício Meneghini Fauth
ae975e594e Remove Privileges::getHtmlForUserGroupDialog method
Related to https://github.com/phpmyadmin/phpmyadmin/issues/16258.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-17 12:42:58 -03:00
Maurício Meneghini Fauth
1dccc10493 Extract method for adding script files
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-12 16:58:33 -03:00
Maurício Meneghini Fauth
f8320956ee Remove Config\PageSettings::showGroup method
Related to https://github.com/phpmyadmin/phpmyadmin/issues/16258.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-12 16:01:18 -03:00
Maurício Meneghini Fauth
3b285ff17e Use identical operator for non-empty strings
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-10 18:06:29 -03:00
Maurício Meneghini Fauth
b30f06455c Remove the blacklist/whitelist terminology
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-06-15 17:51:24 -03:00
William Desportes
14211e6118
Fix twig imports using old PSR-1 style
Ref: 273b666a71
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-14 22:55:55 +02:00
William Desportes
761045bcc9
Move getSystemSchemas and isSystemSchema to Query\Utilities
If you think the class name could be better, feel free to improve it.
Everybody know naming classes is difficult ^^
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-31 01:42:53 +02:00
William Desportes
aba5e27a82
Some code fixes and improvements
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-27 18:55:58 +02:00
Maurício Meneghini Fauth
f4582e083e Use early exit when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
82c2964bb8 Remove useless elses
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 22:27:45 -03:00
Maurício Meneghini Fauth
94955f187a Fix function call signatures indentation
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 04:22:02 -03:00
Maurício Meneghini Fauth
3ae05c785d Use short list syntax and single line arrays
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 03:32:59 -03:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00
William Desportes
6d123fe452
Some minor codebase fixes and improvements
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-24 15:25:56 +02:00
William Desportes
a72203c514
Remove some unused code
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-16 23:51:43 +02:00
Maurício Meneghini Fauth
80a45fa0ae Break too long lines
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-16 18:08:20 -03:00
William Desportes
9bc55b2bc9
Remove some unused variable assignements
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-15 22:44:50 +02:00
Maurício Meneghini Fauth
a64393e7f5 Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-13 00:23:28 -03:00
William Desportes
7db0debd05
Fix some failing tests
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-02 01:51:51 +02:00
William Desportes
0cbba2aef2
Add some properties typehints
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-02 01:41:59 +02:00
Maurício Meneghini Fauth
ae0d7127e0 Extract the drop_db action from mult_submits
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-20 20:00:52 -03:00
Maurício Meneghini Fauth
9b7c4931d3 Add AbstractController::render method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-16 20:15:42 -03:00