William Desportes
005b40ce99
Do not remove a non existing cookie
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-01-24 23:55:38 +01:00
William Desportes
5abcae9255
Fixed some typos in the code base
...
I used code spell checker and did all the libraries/classes/*.php files one by one.
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-11-01 22:46:01 +01:00
Maurício Meneghini Fauth
ac9bccf67d
Replace $GLOBALS['dbi'] with global $dbi
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-11 09:24:21 -03:00
Maurício Meneghini Fauth
bb32ba6d9c
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-04 12:31:43 -03:00
Maurício Meneghini Fauth
cbaa67ea6c
Fix some type errors detected by PHPStan
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-02 14:11:58 -03:00
Maurício Meneghini Fauth
f2e49a92c6
Fix some type errors detected by PHPStan
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-30 19:23:01 -03:00
Maurício Meneghini Fauth
03d8314bba
Create the PhpMyAdmin\Profiling class
...
Extracts Profiling related methods to the Profiling class.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-26 16:02:30 -03:00
Maurício Meneghini Fauth
0e3a82bd86
Remove Display\Error class
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-29 23:08:29 -03:00
Maurício Meneghini Fauth
b4301b4c17
Extract method for check profiling
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-25 01:22:06 -03:00
Maurício Meneghini Fauth
bc59c148f3
Extract method for database connection
...
Core::connectToDatabaseServer
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-25 00:40:45 -03:00
Maurício Meneghini Fauth
3b285ff17e
Use identical operator for non-empty strings
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-10 18:06:29 -03:00
Maurício Meneghini Fauth
a3147c26e1
Extract exit; from Core::previewSQL method
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-09 16:20:41 -03:00
Maurício Meneghini Fauth
f67aacd669
Extract goto and back setup from common.inc.php
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-04 19:00:32 -03:00
Maurício Meneghini Fauth
41622c7dfb
Extract method for token checking from common.inc.php
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-04 16:34:24 -03:00
Maurício Meneghini Fauth
05c62ad1a8
Fix some PHPStan errors
...
Fixes "Cannot access offset on array" errors.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-02 16:12:07 -03:00
Maurício Meneghini Fauth
0612f0ce98
Remove the PhpMyAdmin\Di\Migration class
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-06-26 00:58:36 -03:00
Maurício Meneghini Fauth
1e1ae014d2
Remove conditional param from Core::setGlobalDbOrTable
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-06-26 00:02:32 -03:00
Maurício Meneghini Fauth
b30f06455c
Remove the blacklist/whitelist terminology
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-06-15 17:51:24 -03:00
Maurício Meneghini Fauth
f4582e083e
Use early exit when possible
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
2d02a15de3
Add static to closures that don't use $this
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 18:30:57 -03:00
Maurício Meneghini Fauth
3baad2eb1c
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
a64393e7f5
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-13 00:23:28 -03:00
William Desportes
cc82f092ce
Fix MissingClosureParamType errors
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-04-29 01:08:40 +02:00
William Desportes
0634198297
Merge branch 'QA_5_0'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-22 19:19:41 +01:00
William Desportes
0da6ad6ff4
Fix #15982 - php notice Undefined index HMAC_secret
...
Fixes : #15401
Fixes : #15982
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-22 19:15:40 +01:00
William Desportes
0032dff0d3
Merge branch 'QA_5_0'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-10 09:09:02 +01:00
Max Base
efb5bfdc89
Fix #15926 - PhpMyAdmin\Core::getRealSize
...
Signed-off-by: Seyyed Ali Mohammadieh <Max@Asrez.com>
2020-02-10 08:34:24 +01:00
William Desportes
fa8bada085
Merge branch 'QA_5_0'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-09 18:07:24 +01:00
William Desportes
612e501086
Fix php notice when global lang does not exist
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-09 16:25:14 +01:00
William Desportes
ed48153e7b
Fix Uncaught TypeError: Argument 4 passed to PhpMyAdmin\ErrorHandler::addError() must be of the type int
...
Uncaught TypeError: Argument 4 passed to PhpMyAdmin\ErrorHandler::addError() must be of the type int
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-09 16:24:36 +01:00
Maurício Meneghini Fauth
206199105e
Remove useless return type annotations
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
6584b01824
Use short versions of scalar types in PHP docs
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 12:20:04 -03:00
Maurício Meneghini Fauth
6b7af13f8f
Reference global funcs and consts via use statement
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 00:33:24 -03:00
Maurício Meneghini Fauth
676f48349a
Reference global funcs and consts via use statement
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
5e0f539d2f
Fix invalid @var php doc annotations
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 13:19:08 -03:00
Maurício Meneghini Fauth
f80d3e3bd4
Remove unnecessary annotations
...
@package, @subpackage and others.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
285907991e
Add coding standard rules for whitespace
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-19 22:29:54 -03:00
William Desportes
249ee4dbd2
Improve JS and phpdoc by removing useless spaces
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-16 18:39:42 +01:00
William Desportes
51f292beab
Improve some params and return types marked as mixed
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-29 14:33:49 +01:00
Maurício Meneghini Fauth
4a79e27e10
Remove js/whitelist.js
...
Removes the GotoWhitelist global.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-17 21:09:54 -03:00
Maurício Meneghini Fauth
39f42f848b
Remove some useless docblock comments
...
Fixes docblock spacing
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-13 21:15:00 -03:00
Maurício Meneghini Fauth
80a3c50bf5
Remove some useless if conditions
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-11 20:43:57 -03:00
Maurício Meneghini Fauth
f6a17433a2
Use null coalesce operator when possible
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-11 20:16:58 -03:00
Maurício Meneghini Fauth
dd06cd38f8
Defines rules for double quote usage
...
Makes sure that any use of double quotes strings are warranted.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-01 14:10:07 -03:00
Hugues Peccatte
3255e4ad7b
Split Util class regarding the responsabilities ( #15567 )
...
PhpMyAdmin\Util is a very huge class with a lot of responsabilities.
There is a lot of work to split it, but this may be just a small start, waiting for a more normalized code.
* Split Util class regarding the responsabilities
* Split the buttonOrImage function
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-11-21 20:20:05 -03:00
Maurício Meneghini Fauth
1a14b3e4d3
Remove vim modelines
...
These settings are no longer required as they are guaranteed through
other coding standard tools.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-02 09:43:21 -03:00
Maurício Meneghini Fauth
632a774de2
Use the router for transformation_wrapper.php
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-21 00:11:04 -03:00
Maurício Meneghini Fauth
2ca7148f6a
Use the router for transformation_overview.php
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-21 00:11:04 -03:00
Maurício Meneghini Fauth
e779a72ce5
Use the router for the import entry point
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-19 19:20:39 -03:00
Maurício Meneghini Fauth
87c16c569c
Use the router for the table import page
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-19 18:36:32 -03:00