Maurício Meneghini Fauth
e66be179ca
Use camel case naming for class members
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-05 10:37:07 -03:00
Maurício Meneghini Fauth
bb32ba6d9c
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-04 12:31:43 -03:00
William Desportes
ae86b0aa67
Fixes #16278 - Remove underscore prefix from property names of Qbe class
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-08-06 15:25:21 +02:00
Maurício Meneghini Fauth
3f01cd8c13
Remove Message::display method
...
Related to https://github.com/phpmyadmin/phpmyadmin/issues/16258 .
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-20 19:43:46 -03:00
Maurício Meneghini Fauth
5afb266763
Merge branch 'QA_5_0'
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-15 19:49:29 -03:00
Maurício Meneghini Fauth
59b71dc299
Fix type errors when using saved searches
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-15 19:29:55 -03:00
Maurício Meneghini Fauth
3b285ff17e
Use identical operator for non-empty strings
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-10 18:06:29 -03:00
charliewindred
ca3c5e17b0
Remove underscore prefix from method names
...
Removed underscore from method names for PSR-12 compliance.
Signed-off-by: charliewindred <charliewindred@gmail.com>
2020-06-02 16:44:16 +01:00
Maurício Meneghini Fauth
f4582e083e
Use early exit when possible
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
bd979dd1ff
Remove useless elseif with if
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 22:53:44 -03:00
Maurício Meneghini Fauth
3baad2eb1c
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
a64393e7f5
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-13 00:23:28 -03:00
William Desportes
913afd30a8
Fix criteria escaping in QBE
...
Introduced-by: 250d598181
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-12 14:24:26 +02:00
Maurício Meneghini Fauth
f4fda0cf2f
Extract HTML from QBE table header
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-03 00:30:26 -03:00
Maurício Meneghini Fauth
3127eff3af
Extract HTML from Qbe::_getTableFooters method
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-02 22:56:30 -03:00
Maurício Meneghini Fauth
3381f385a9
Extract HTML from Qbe::getTablesList method
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-02 22:15:30 -03:00
Maurício Meneghini Fauth
250d598181
Extract HTML from Qbe::getSelectionForm method
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-02 20:28:03 -03:00
Maurício Meneghini Fauth
e9f9c27d7e
Extract HTML from Qbe::_getInsDelAndOrCell method
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-02 18:33:54 -03:00
Maurício Meneghini Fauth
6584b01824
Use short versions of scalar types in PHP docs
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 12:20:04 -03:00
Maurício Meneghini Fauth
6b7af13f8f
Reference global funcs and consts via use statement
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 00:33:24 -03:00
Maurício Meneghini Fauth
676f48349a
Reference global funcs and consts via use statement
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
f80d3e3bd4
Remove unnecessary annotations
...
@package, @subpackage and others.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf
Use one line for comments with a single line
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
c231652c67
Remove useless comments in PHP docs
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 14:38:49 -03:00
Maurício Meneghini Fauth
8ec4209002
Fix some coding standard issues
...
- Inverts yoda comparisons
- Removes parentheses from return
- Removes useless ternary operators
- Adds paretheses to new instances
- Adds trailing array comma
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 00:38:34 -03:00
Maurício Meneghini Fauth
285907991e
Add coding standard rules for whitespace
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-19 22:29:54 -03:00
Maurício Meneghini Fauth
f6a17433a2
Use null coalesce operator when possible
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-11 20:16:58 -03:00
Maurício Meneghini Fauth
dd06cd38f8
Defines rules for double quote usage
...
Makes sure that any use of double quotes strings are warranted.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-01 14:10:07 -03:00
Hugues Peccatte
3255e4ad7b
Split Util class regarding the responsabilities ( #15567 )
...
PhpMyAdmin\Util is a very huge class with a lot of responsabilities.
There is a lot of work to split it, but this may be just a small start, waiting for a more normalized code.
* Split Util class regarding the responsabilities
* Split the buttonOrImage function
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-11-21 20:20:05 -03:00
Maurício Meneghini Fauth
8a0aa251fe
Replace some custom CSS utilities with Bootstrap equivalents
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-11-12 19:35:37 -03:00
Maurício Meneghini Fauth
9b6cd02d61
Merge pull request #15509 from mauriciofauth/neutral-pronouns
...
Use gender-neutral pronouns
2019-10-18 09:13:52 -03:00
Maurício Meneghini Fauth
441f8daa1a
Use gender-neutral pronouns
...
Replaces gender-specific pronouns with gender-neutral pronouns.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-18 09:13:08 -03:00
William Desportes
343adb694f
Merge branch 'QA_5_0'
2019-10-18 00:14:04 +02:00
William Desportes
5698fb221f
Merge branch 'QA_4_9' into QA_5_0
2019-10-18 00:13:07 +02:00
Sergi L
602cf50e52
Text-area-overflows-parent-element
...
Signed-off-by: Sergi Linares <sergi_linares@outlook.com>
2019-10-17 23:21:24 +02:00
Maurício Meneghini Fauth
6ea135a0d0
Merge branch 'QA_5_0'
2019-09-21 17:31:48 -03:00
Maurício Meneghini Fauth
3e330fd403
Merge branch 'QA_4_9' into QA_5_0
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-21 17:30:44 -03:00
Maurício Meneghini Fauth
0a8fc4446b
Fix some invalid array accesses with PHP 7.4
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-21 17:22:52 -03:00
Maurício Meneghini Fauth
1a14b3e4d3
Remove vim modelines
...
These settings are no longer required as they are guaranteed through
other coding standard tools.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-02 09:43:21 -03:00
Maurício Meneghini Fauth
c3c58e6cd4
Use the router for the database QBE page
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-07 23:43:44 -03:00
Hugues Peccatte
0d8f6a3a93
Merge isset and unset calls
...
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-07-16 23:21:25 -03:00
William Desportes
a2268169ae
Use strict compare for count function
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 17:44:49 +02:00
Maurício Meneghini Fauth
e1f9ae00cd
Add a trailing comma in multi-line arrays
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-14 14:09:26 -03:00
Maurício Meneghini Fauth
c9129e9bd8
Remove unnecessary string concatenation
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 17:47:33 -03:00
Hugues Peccatte
9abd308837
Inject dependencies ( #15271 )
...
Inject dependencies instead of building them.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-06-01 15:13:41 -03:00
Maurício Meneghini Fauth
422cd3ade2
Merge pull request #15258 from Tithugues/feature/use-strpos-instead-of-strstr
...
Use "strpos" instead of "strstr" to improve performances
2019-05-08 14:20:45 -03:00
Hugues Peccatte
69895e4bb1
Use "strpos" instead of "strstr" to improve performances
...
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-07 23:58:05 +02:00
Hugues Peccatte
4b628b6553
Replace class name as string by ":class"
...
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-07 22:56:59 +02:00
Maurício Meneghini Fauth
21e2ca4c4c
Fix some PHPStan and phpcs errors
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-03-19 15:17:41 -03:00
Hugues Peccatte
f06883d2a7
Remove useless parenthesis
...
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-20 01:23:53 +01:00