Commit Graph

54 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
7994eb3ac6
Fix some errors found by Psalm
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-02-10 17:12:11 -03:00
Maurício Meneghini Fauth
a83959b3aa
Extract methods from Navigation\Nodes\Node::getData
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-20 17:44:32 -03:00
Maurício Meneghini Fauth
40c4f07de6
Use sprintf for Navigation\Nodes\Node::getData query strings
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-19 22:28:26 -03:00
Maurício Meneghini Fauth
ac9bccf67d Replace $GLOBALS['dbi'] with global $dbi
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-11 09:24:21 -03:00
William Desportes
466ff06b3b
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-09-15 14:22:24 +02:00
William Desportes
62b9d8ca92
Merge #16354 - Fixes #14698 - Database named as 'New' causes PHP fatal error
Pull-request: #16354
Fixes: #14698

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-09-15 14:18:56 +02:00
Nina Pypchenko
de168edc59 Fixes #14698. Navigation tree no longer breaks on encountering a database named 'New'
Signed-off-by: Nina Pypchenko <22447785+nina-py@users.noreply.github.com>
2020-09-15 20:53:02 +10:00
William Desportes
7623fed14a
Fix all found errors and add typehints if possible on NavigationTree class
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-02 23:50:49 +02:00
William Desportes
62baf0b8ea
Change Node::getChild return to ?Node
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-02 23:10:35 +02:00
Maurício Meneghini Fauth
f4582e083e Use early exit when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
bd979dd1ff Remove useless elseif with if
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 22:53:44 -03:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
80a45fa0ae Break too long lines
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-16 18:08:20 -03:00
William Desportes
9a95abd05f
Use declaration of global $dbi
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-16 12:03:29 +02:00
Maurício Meneghini Fauth
84139f4d51 Remove some useless variables
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-13 16:15:37 -03:00
Maurício Meneghini Fauth
206199105e Remove useless return type annotations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
6584b01824 Use short versions of scalar types in PHP docs
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 12:20:04 -03:00
Maurício Meneghini Fauth
6b7af13f8f Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 00:33:24 -03:00
Maurício Meneghini Fauth
676f48349a Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf Use one line for comments with a single line
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
3f7204beb7 Add coding standard rule for self reference
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-19 23:31:20 -03:00
William Desportes
ba1e22c92b
Fix some primitive types not in lower case and add some return type hints
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-29 13:49:03 +01:00
Maurício Meneghini Fauth
dd06cd38f8 Defines rules for double quote usage
Makes sure that any use of double quotes strings are warranted.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-01 14:10:07 -03:00
Hugues Peccatte
3255e4ad7b Split Util class regarding the responsabilities (#15567)
PhpMyAdmin\Util is a very huge class with a lot of responsabilities.

There is a lot of work to split it, but this may be just a small start, waiting for a more normalized code.

* Split Util class regarding the responsabilities
* Split the buttonOrImage function

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-11-21 20:20:05 -03:00
Maurício Meneghini Fauth
1a14b3e4d3 Remove vim modelines
These settings are no longer required as they are guaranteed through
other coding standard tools.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-02 09:43:21 -03:00
William Desportes
6cc352ac12
phpstan level 3 fixes
21 errors left

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 14:37:38 +02:00
Maurício Meneghini Fauth
2906fb0e26 Replace sizeof function alias with count
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 13:48:59 -03:00
Maurício Meneghini Fauth
c8f84fc748 Replace is_null with identical comparison with null
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 13:28:22 -03:00
Maurício Meneghini Fauth
990f801123 Use camel case names in Navigation classes
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-11 20:55:34 -03:00
Maurício Meneghini Fauth
defd6761ba Add ChangeLog entry for #14890
Display column details in navigation bar

- Fix coding standard errors

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-01 15:20:55 -03:00
William Desportes
42e1a333a3
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-02 00:22:38 +01:00
saurass
88bb10d329 reduce elseif(s)
Signed-off-by: saurass <saurabhsrivastava312@gmail.com>
2019-01-25 14:21:22 +05:30
saurass
25ca73de64 fixes #14896 - [QA_4_8] Expanded DB, refresh, plus/minus icon
Signed-off-by: saurass <saurabhsrivastava312@gmail.com>
2019-01-24 12:30:03 +05:30
Maurício Meneghini Fauth
4cee0cbc12 Adds space after not (!) and type cast
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-05 21:56:34 -02:00
Tomas Votruba
637fe6de06 [cs] remove unused brackets, clean unused property assign
Signed-off-by: Tomas Votruba <tomas.vot@gmail.com>
2018-11-26 17:54:40 +01:00
Tomas Votruba
bf720bad29 remove unused and fix @param, @var and @return annotation values
Signed-off-by: Tomas Votruba <tomas.vot@gmail.com>
2018-11-24 21:47:26 +01:00
Maurício Meneghini Fauth
b5c9c63789 Fix some uncaught type errors
Fixes #14394

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-12 23:14:05 -02:00
Isaac Bennetch
fab796bda9 Fixing some Uncaught TypeErrors, related to #14608
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2018-09-06 13:43:47 -04:00
Isaac Bennetch
5130b3da1a Fixing some Uncaught TypeError, related to #14608
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2018-09-06 10:50:09 -04:00
Maurício Meneghini Fauth
d4b4124a5e Remove $GLOBALS['dbi'] from Relation class
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-08-30 19:05:09 -03:00
William Desportes
3dce65d913 phpstan level 1 (#14472)
* level +1
* Install sami/sami globaly to avoid dependency clash

Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-08-18 14:37:41 -03:00
Isaac Bennetch
4baab5c7a3 Fix Uncaught TypeError when logging in
Fixes bug #14380

Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2018-06-10 11:37:09 -04:00
Maurício Meneghini Fauth
2005cca77f Fix methods and properties visibility issues
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 21:02:26 -03:00
Maurício Meneghini Fauth
b9c0463d96 Use short array syntax instead of long array syntax
Replaces array() with [].

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 01:42:21 -03:00
Maurício Meneghini Fauth
9dbae0a9ed Enable strict mode in Navigation classes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-16 01:09:16 -03:00
Maurício Meneghini Fauth
d98658187a Replace PhpMyAdmin\Relation static calls
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-03-25 19:32:13 -03:00
Gabriel Caruso
6ff73257e2 Simplify returns
Signed-off-by: Gabriel Caruso <carusogabriel34@gmail.com>
2018-01-16 10:16:56 -02:00
Gabriel Caruso
a8bd364e02 Clean elses
Signed-off-by: Gabriel Caruso <carusogabriel34@gmail.com>
2017-12-14 22:02:17 -02:00
Michal Čihař
bed6fb4ebd Avois passing extension to Util::getImage
We do not use it anyway for quite some time and this way it's less
processing to generate the img tag.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-27 14:24:42 +01:00