Commit Graph

83 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
db3da81056 Remove some useless comments
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-13 19:56:56 -03:00
Maurício Meneghini Fauth
7936909dbd Move Operations::getMaintenanceActions to the view
Uses Table\MaintenanceController to handle the maintenance actions in
the table operations page.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-28 15:25:14 -03:00
Maurício Meneghini Fauth
e5328434bf Extract response from Operations class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-14 20:18:03 -03:00
Maurício Meneghini Fauth
3b285ff17e Use identical operator for non-empty strings
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-10 18:06:29 -03:00
Maurício Meneghini Fauth
f4582e083e Use early exit when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
3ae05c785d Use short list syntax and single line arrays
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 03:32:59 -03:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00
William Desportes
cfc17e56ea
Fix some potential bugs after my last commit
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 01:43:57 +02:00
Maurício Meneghini Fauth
80a45fa0ae Break too long lines
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-16 18:08:20 -03:00
Maurício Meneghini Fauth
a64393e7f5 Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-13 00:23:28 -03:00
William Desportes
0032dff0d3
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-10 09:09:02 +01:00
Yash Bothra
3d57b5eb79 #15410 added hidden field for Auto-Increment
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
2020-02-06 03:15:07 +05:30
Maurício Meneghini Fauth
adadd49a44 Extract HTML from ViewOperationsController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-05 01:40:45 -03:00
Maurício Meneghini Fauth
30b5fc46d2 Extract HTML from table operations page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-24 20:00:13 -03:00
Maurício Meneghini Fauth
aa0f8a6efe Extract HTML from the database operations page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 22:56:29 -03:00
Maurício Meneghini Fauth
6584b01824 Use short versions of scalar types in PHP docs
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 12:20:04 -03:00
Maurício Meneghini Fauth
676f48349a Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf Use one line for comments with a single line
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
8ec4209002 Fix some coding standard issues
- Inverts yoda comparisons
- Removes parentheses from return
- Removes useless ternary operators
- Adds paretheses to new instances
- Adds trailing array comma

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 00:38:34 -03:00
Maurício Meneghini Fauth
39f42f848b Remove some useless docblock comments
Fixes docblock spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-13 21:15:00 -03:00
Maurício Meneghini Fauth
dd2b05330a Remove useless parentheses
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-12 00:18:01 -03:00
Maurício Meneghini Fauth
f6a17433a2 Use null coalesce operator when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-11 20:16:58 -03:00
Maurício Meneghini Fauth
dd06cd38f8 Defines rules for double quote usage
Makes sure that any use of double quotes strings are warranted.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-01 14:10:07 -03:00
Hugues Peccatte
3255e4ad7b Split Util class regarding the responsabilities (#15567)
PhpMyAdmin\Util is a very huge class with a lot of responsabilities.

There is a lot of work to split it, but this may be just a small start, waiting for a more normalized code.

* Split Util class regarding the responsabilities
* Split the buttonOrImage function

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-11-21 20:20:05 -03:00
William Desportes
eda044cbac
Improve code after Scrutinizer report
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-11 21:33:25 +01:00
William Desportes
1fb7e78183
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-10-21 20:55:19 +02:00
William Desportes
67a37881c3
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-10-21 20:53:51 +02:00
William Desportes
157582c335
Fix #15311 - Adjust Privileges on copy database fails with MariaDB
Co-authored-by: Harro Verton <@>
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-10-21 20:39:29 +02:00
William Desportes
66bd7fb596
Merge branch 'QA_5_0'
Sign-off: fc393eac39

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-10-21 13:36:44 +02:00
William Desportes
fc393eac39
Fix phpcs and ignore PSR2.Methods.FunctionCallSignature.Indent 2019-10-21 13:30:38 +02:00
William Desportes
14d73c1da0
Merge branch 'QA_5_0' into master
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-10-21 13:03:33 +02:00
Isaac Bennetch
8183b5e854 Merge commit '2d558e45bf' into QA_5_0 2019-10-20 23:10:27 -04:00
William Desportes
e87c6b822d
Fix #14598 - check referencial integrity show table-content
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-10-20 11:42:30 +02:00
Maurício Meneghini Fauth
1a14b3e4d3 Remove vim modelines
These settings are no longer required as they are guaranteed through
other coding standard tools.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-02 09:43:21 -03:00
Maurício Meneghini Fauth
dd95a34b3a Add route parameter to index.php links
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-26 17:37:53 -03:00
Maurício Meneghini Fauth
ea3599194e Use the router for table operations page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-14 13:57:33 -03:00
Maurício Meneghini Fauth
208b0e25e1 Use the router for the sql pages
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-03 21:25:27 -03:00
Maurício Meneghini Fauth
469fd5c05c Use the router for the database operations page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-24 02:12:15 -03:00
Maurício Meneghini Fauth
4fe624fa93 Remove Charsets::getCollationDropdownBox method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-25 03:32:01 -03:00
Maurício Meneghini Fauth
e1f9ae00cd Add a trailing comma in multi-line arrays
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-14 14:09:26 -03:00
Maurício Meneghini Fauth
c8f84fc748 Replace is_null with identical comparison with null
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 13:28:22 -03:00
Maurício Meneghini Fauth
ce71901de5 Refactor js/functions.js to use a module
Adds Functions module in js/functions.js to reduce the number of global variables.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-22 17:44:21 -03:00
Hugues Peccatte
7b00f5d35a Update PHPDoc
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-14 21:59:57 +02:00
William Desportes
65b619c5a8
Merge branch 'QA_4_8'
[ci skip]
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-12 00:41:11 +02:00
William Desportes
47bd88dffa
Add support for auto-increment on ROCKSDB
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-11 23:53:07 +02:00
William Desportes
76dca69460
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-01 22:29:25 +02:00
Nugroho Latifolia
ad6fe25878
Fix #14673 - innodb & MySQL 8: DYNAMIC & COMPRESSED ROW_FORMAT missing
Fixes: #14673

Newer MySQL/MariaDB always return empty a.k.a '' on $innodb_file_format otherwise
        old versions of MySQL/MariaDB must be returning something or not empty.
        This patch is to support newer MySQL/MariaDB while also for backward compatibilities.

Signed-off-by: Nugroho Latifolia <nugroho.latifolia@gmail.com>
2019-04-01 22:17:07 +02:00
Maurício Meneghini Fauth
23c3579804 Format array declarations
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-07 14:31:39 -02:00
Maurício Meneghini Fauth
4cee0cbc12 Adds space after not (!) and type cast
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-05 21:56:34 -02:00