Commit Graph

276 Commits

Author SHA1 Message Date
William Desportes
c8360eaf8b
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-18 02:07:49 +01:00
William Desportes
b9ee5c708f
Fix "Undefined index: selected_usr" when the user tried to delete no selected user
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-17 20:25:01 +01:00
Maurício Meneghini Fauth
1e5fbd57fc
Create Twig\AssetExtension and image Twig function
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-28 16:09:17 -03:00
William Desportes
9abf4cb109
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-01-22 00:37:51 +01:00
Prashant Tholia
ebff28171c
Fix #16463 - 'REFERENCES' privilege checkbox's title
Set different title messages depending on database and database version for 'REFERENCES' field in user 'Edit Preferences' form.

Co-Authored-By: William Desportes <williamdes@wdes.fr>
Signed-off-by: Prashant Tholia <prashant.tholia@gmail.com>
2021-01-22 00:05:43 +01:00
Maurício Meneghini Fauth
443e4289c3
Replace user groups jQuery UI's dialog with a modal
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-12 17:28:22 -03:00
Maurício Meneghini Fauth
4ad6e2ea4e
Use Bootstrap's pagination for user accounts page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-12-29 17:59:59 -03:00
Maurício Meneghini Fauth
5178f76f95
Move fieldset CSS style to the .pma-fieldset class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-12-28 19:46:40 -03:00
Maurício Meneghini Fauth
d23be36126
Fix some errors found by PHPStan and Psalm
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-26 15:20:44 -03:00
Saksham Gupta
be3905944f Fixes: https://github.com/phpmyadmin/phpmyadmin/issues/16477
Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Fix db Edit privileges

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Fix conflict

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Add missing bracket

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Fix Lint

Signed-off-by: Saksham Gupta <shucon01@gmail.com>
2020-11-16 02:09:54 +05:30
Isaac Bennetch
4d99680147 Force BINARY comparison when looking at privileges.
Otherwise, a mismatch between the "Server connection collation" dropdown
and the system tables/views causes an error message.

Fixes: #15463

Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2020-10-29 09:23:38 -04:00
Maurício Meneghini Fauth
a83ec78ebf Make DatabaseInterface::isUserType method private
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-24 00:40:03 -03:00
Maurício Meneghini Fauth
71d9a8f760 Remove is_grantuser and is_createuser PHP globals
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-23 22:58:49 -03:00
Maurício Meneghini Fauth
ac9bccf67d Replace $GLOBALS['dbi'] with global $dbi
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-11 09:24:21 -03:00
Maurício Meneghini Fauth
e66be179ca Use camel case naming for class members
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-05 10:37:07 -03:00
Maurício Meneghini Fauth
bb32ba6d9c Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-04 12:31:43 -03:00
Maurício Meneghini Fauth
e7c8e20edb Fix some type errors detected by PHPStan
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-02 00:37:23 -03:00
Maurício Meneghini Fauth
f2e49a92c6 Fix some type errors detected by PHPStan
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-30 19:23:01 -03:00
Maurício Meneghini Fauth
d36d9437a1 Fix some errors detected by Psalm
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-16 21:03:53 -03:00
Maurício Meneghini Fauth
40d2a1c605
Merge pull request #16338 from mauriciofauth/replication
Refactor the ReplicationInfo class
2020-09-12 09:07:33 -03:00
Maurício Meneghini Fauth
cd862d4f00 Remove replication_info global variable
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-12 09:04:44 -03:00
Maurício Meneghini Fauth
34dd2a61f8 Remove strPrivDesc* global variables
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-11 17:22:30 -03:00
Maurício Meneghini Fauth
ceac762e09 Remove pmaThemePath and pmaThemeImage PHP globals
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-02 10:57:57 -03:00
Maurício Meneghini Fauth
03d8314bba Create the PhpMyAdmin\Profiling class
Extracts Profiling related methods to the Profiling class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-26 16:02:30 -03:00
William Desportes
d63a72ad51
Fixes #16278 - Remove underscore prefix from property names
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-08-06 15:46:39 +02:00
Maurício Meneghini Fauth
c92663adbb Move ChangePassword::getHtml to Server\Privileges class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-29 19:12:35 -03:00
Maurício Meneghini Fauth
2358b9c4f9 Fix missing property type hints
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-22 21:42:22 -03:00
Maurício Meneghini Fauth
2bf9d2bf68 Ignore too long lines warn in Server\Privileges class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-22 18:26:53 -03:00
William Desportes
9e39713b5a
Document "DELETE HISTORY" for translators
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-07-22 21:45:02 +02:00
Maurício Meneghini Fauth
ae975e594e Remove Privileges::getHtmlForUserGroupDialog method
Related to https://github.com/phpmyadmin/phpmyadmin/issues/16258.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-17 12:42:58 -03:00
Maurício Meneghini Fauth
3b285ff17e Use identical operator for non-empty strings
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-10 18:06:29 -03:00
Maurício Meneghini Fauth
05c62ad1a8 Fix some PHPStan errors
Fixes "Cannot access offset on array" errors.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-02 16:12:07 -03:00
Maurício Meneghini Fauth
b30f06455c Remove the blacklist/whitelist terminology
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-06-15 17:51:24 -03:00
William Desportes
fd775cb9f9
Split some code from Privileges::updatePrivileges into Privileges::generateQueriesForUpdatePrivileges
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-07 19:23:46 +02:00
William Desportes
42e5ccda77
Improve Privileges::wildcardEscapeForGrant
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-07 18:58:06 +02:00
William Desportes
076d7b1a7f
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-07 18:27:18 +02:00
William Desportes
5164bea16a
Fix #16166 - Make the alter user privileges MySQL 8.0.11+ compatible
Ref: #14217
Ref: #14788

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-07 18:08:50 +02:00
charliewindred
ca3c5e17b0 Remove underscore prefix from method names
Removed underscore from method names for PSR-12 compliance.
Signed-off-by: charliewindred <charliewindred@gmail.com>
2020-06-02 16:44:16 +01:00
Maurício Meneghini Fauth
f4582e083e Use early exit when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
bd979dd1ff Remove useless elseif with if
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 22:53:44 -03:00
Maurício Meneghini Fauth
82c2964bb8 Remove useless elses
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 22:27:45 -03:00
Maurício Meneghini Fauth
2d02a15de3 Add static to closures that don't use $this
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 18:30:57 -03:00
Maurício Meneghini Fauth
3ae05c785d Use short list syntax and single line arrays
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 03:32:59 -03:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
80a45fa0ae Break too long lines
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-16 18:08:20 -03:00
William Desportes
821441f0cd
Remove some useless lines in test files and remove an else
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-16 20:16:00 +02:00
Maurício Meneghini Fauth
8dd310fb6a Remove assignments in if conditions
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-16 01:35:19 -03:00
Maurício Meneghini Fauth
84139f4d51 Remove some useless variables
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-13 16:15:37 -03:00
Maurício Meneghini Fauth
a64393e7f5 Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-13 00:23:28 -03:00
William Desportes
7db0debd05
Fix some failing tests
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-02 01:51:51 +02:00