Commit Graph

36 Commits

Author SHA1 Message Date
William Desportes
5abcae9255
Fixed some typos in the code base
I used code spell checker and did all the libraries/classes/*.php files one by one.
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-11-01 22:46:01 +01:00
Maurício Meneghini Fauth
e7c8e20edb Fix some type errors detected by PHPStan
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-02 00:37:23 -03:00
Maurício Meneghini Fauth
f2e49a92c6 Fix some type errors detected by PHPStan
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-30 19:23:01 -03:00
Maurício Meneghini Fauth
9d6bc6f641 Merge branch 'QA_5_0'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-16 22:09:53 -03:00
Maurício Meneghini Fauth
3b285ddc3a Fix PHP error when exporting without php-zip
Fixes #14326 (Export database with zip compression: Class 'ZipArchive'
not found error).

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-16 21:36:54 -03:00
Maurício Meneghini Fauth
f4582e083e Use early exit when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
a64393e7f5 Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-13 00:23:28 -03:00
Maurício Meneghini Fauth
6584b01824 Use short versions of scalar types in PHP docs
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 12:20:04 -03:00
Maurício Meneghini Fauth
6b7af13f8f Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 00:33:24 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf Use one line for comments with a single line
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
c231652c67 Remove useless comments in PHP docs
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 14:38:49 -03:00
Maurício Meneghini Fauth
dd2b05330a Remove useless parentheses
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-12 00:18:01 -03:00
Maurício Meneghini Fauth
1a14b3e4d3 Remove vim modelines
These settings are no longer required as they are guaranteed through
other coding standard tools.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-02 09:43:21 -03:00
William Desportes
6cc352ac12
phpstan level 3 fixes
21 errors left

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 14:37:38 +02:00
Maurício Meneghini Fauth
2906fb0e26 Replace sizeof function alias with count
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 13:48:59 -03:00
William Desportes
1ee4074de8
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-02 20:24:02 +01:00
Kartik Kathuria
f26ff98c92 Replaced with Appropriate Comment
Signed-off-by: Kartik Kathuria <kathuriakartik0@gmail.com>
2019-03-01 15:07:28 +05:30
Kartik Kathuria
b1f4a5ecb9 FixError#14870 Now Zip files display correct date and time
Signed-off-by: Kartik Kathuria <kathuriakartik0@gmail.com>
2019-02-18 23:02:52 +05:30
Hugues Peccatte
4321120b80 Fix PHPCS issue
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-21 12:27:26 +01:00
Hugues Peccatte
f06883d2a7 Remove useless parenthesis
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-20 01:23:53 +01:00
Maurício Meneghini Fauth
4cee0cbc12 Adds space after not (!) and type cast
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-05 21:56:34 -02:00
Maurício Meneghini Fauth
6cf8ee0831 Enable strict mode in some classes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-15 01:03:57 -03:00
Maurício Meneghini Fauth
69def191d3 Fix cases where $name is an array in createFile
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-03-30 17:03:39 -03:00
Lakshay arora
8e48a0c4f2 Fix for "Export tables as seperate files", #14080
Applied code sniffer.

Fix #14080
Close #14115

Signed-off-by: Lakshay arora <carefreelakshay97@gmail.com>
2018-03-30 03:26:47 -03:00
Maurício Meneghini Fauth
bae0431dfb Refactor PhpMyAdmin\ZipExtension class
Replace static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-14 01:58:58 -02:00
Maurício Meneghini Fauth
3d44419cbd Use lowercase for PHP booleans and null
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-12-04 13:14:40 -02:00
Michal Čihař
3c7362c739 Stricten typechecking of parameters
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-08-01 13:46:00 +02:00
Michal Čihař
46e82fef4f Optimize zip creation a bit
Avoid constructing temporary strings and concatenating them, create each
record at once.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-08-01 13:26:33 +02:00
Michal Čihař
c67e83a57c Fixed creating zip file with single entry
And add tests to cover that.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-08-01 13:26:26 +02:00
Michal Čihař
1c166aef3a Fix creating single file zip
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-08-01 13:05:06 +02:00
Michal Čihař
b3cd03d4f9 Fix handling of string parameter
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-08-01 09:37:56 +02:00
Maurício Meneghini Fauth
95a409c4f2 Move controllers to PhpMyAdmin namespace
- Move base controllers to PhpMyAdmin namespace
- Move database controllers to PhpMyAdmin namespace
- Move server controllers to PhpMyAdmin namespace
- Move table controllers to PhpMyAdmin namespace

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-07-14 11:18:48 -03:00
Aron Bergman
dd73e321e3 Refractor ZipExtension to use ZipArchive
ZipExtension is now using ZipArchive instead of zip_* functions.
Replaced getError with ZipArchive::getStatusString.
The documentation for the file has been refractored.
ZipExtension now includes ZipFile functionality, and thus ZipFile is removed.

See issue #13365

Signed-off-by: Aron Bergman <bathingrad@gmail.com>
2017-07-10 09:39:37 +02:00
Maurício Meneghini Fauth
42bfa9c42d Move classes to PhpMyAdmin namespace
- Move ZipExtension to PhpMyAdmin namespace
- Move ZipFile to PhpMyAdmin namespace

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-07-01 10:49:53 -03:00