Commit Graph

2906 Commits

Author SHA1 Message Date
William Desportes
b889d5e57a
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-23 16:00:23 +01:00
William Desportes
0a55b43adc
Merge #16584 - Improve the version handling
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-23 15:51:56 +01:00
Maurício Meneghini Fauth
6f97180b6d
Remove Plugins\Export\Helpers\Pdf::setAttributes method
Signed-off-by: Maurício Meneghini Fauth <mauricio@php.net>
2021-02-22 22:25:30 -03:00
William Desportes
02679bb133
Skip Console test for releases and packaging people
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-22 00:18:24 +01:00
William Desportes
cde808888c
Add tests for the Version class
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-22 00:18:24 +01:00
William Desportes
6e2459f57a
Add tests to generate the version file
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-22 00:18:24 +01:00
Maurício Meneghini Fauth
2b830ea256
Bump PHP minimum version to 7.2
PHP officially ended support for PHP 7.2 on 2020-11-30. So it is safe to
bump the minimum version to PHP 7.2 for phpMyAdmin 5.2, which is likely
to be released only in the second half of 2021.

Related to #15607

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-02-18 12:33:03 -03:00
William Desportes
e17be10766
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-16 18:02:29 +01:00
William Desportes
9754d165fc
Ref #16575 - Add tests to cover the DEFAULT timestamp support
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-16 15:36:28 +01:00
William Desportes
287d743eb7
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-09 17:41:54 +01:00
William Desportes
fb53951a2d
Cover Util::handleDisableFKCheckInit and Util::handleDisableFKCheckCleanup
Ref: #16353

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-09 17:22:58 +01:00
William Desportes
471d104852
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-09 15:49:46 +01:00
William Desportes
e71102a455
Merge #16597 - Fix #15389 - reset current page indicator after deleting all rows to current page and not page 1
Pull-request: #16597
Fixes: #15389

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-09 15:47:05 +01:00
Maurício Meneghini Fauth
f807ba1d27
Merge branch 'QA_5_1'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-02-08 14:35:48 -03:00
Maurício Meneghini Fauth
235a79483d
Fix Advisor formatting incorrect for long_query_time notice
Fixes #16622

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-02-08 14:31:17 -03:00
William Desportes
f16757a9b6
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-08 01:00:41 +01:00
Maurício Meneghini Fauth
0f463b71f9
Fix link HTML messed up in Advisor
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-02-07 13:32:45 -03:00
Maurício Meneghini Fauth
12d662baa3
Replace themes preview popup with a modal
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-02-04 23:21:31 -03:00
William Desportes
31a94061dc
Add an assert for the HTTP tests in case the request fails
Fix "Argument 2 passed to PHPUnit\Framework\Assert::assertStringContainsString() must be of the type string, null given"

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-01-31 01:43:32 +01:00
William Desportes
2acea7d4c0
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-01-31 01:39:50 +01:00
William Desportes
8917e77bba
Fix #16595 - escape mysql wildcards on structure edit fields
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-01-31 01:30:56 +01:00
William Desportes
0a1d09b282
Add tests for #16595 - underscore structure edit
I removed the escape because it is already escaped afterwards.

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-01-31 01:25:34 +01:00
William Desportes
4597ce50fa
Write tests for the Query\Generator class
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-01-31 01:21:46 +01:00
Maurício Meneghini Fauth
17a01d9d9d
Extract the HTML from ThemeManager::getHtmlSelectBox
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-28 22:34:01 -03:00
Maurício Meneghini Fauth
1e5fbd57fc
Create Twig\AssetExtension and image Twig function
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-28 16:09:17 -03:00
Saksham Gupta
8e8b7df450 Fixes: https://github.com/phpmyadmin/phpmyadmin/issues/15389
Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Add Unit Test

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Fix Lint

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Add comment

Signed-off-by: Saksham Gupta <shucon01@gmail.com>
2021-01-28 16:37:07 +05:30
Maurício Meneghini Fauth
57ffba8dd4
Refactor ThemeManager::loadThemes
Removes themesPath property.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-27 18:24:56 -03:00
William Desportes
c2420fb8f4
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-01-24 00:44:55 +01:00
William Desportes
9648775c94
Fix a coding standard mistake
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-01-23 17:09:08 +01:00
William Desportes
b859fb4f89
Url encode the PMA_VERSION because it could contain special chars
See: https://salsa.debian.org/phpmyadmin-team/phpmyadmin/-/blob/debian/4%255.0.4+dfsg2-1/debian/patches/Fix-test-for-Debian-versions-on-Debian-CI.patch

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-01-23 16:55:10 +01:00
William Desportes
d0a00efabc
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-01-20 00:44:21 +01:00
William Desportes
0d7ec7bbfe
Adjust php extensions and fix iconv patch and coverage names
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-01-19 22:44:24 +01:00
William Desportes
9b6cb9ce7d
Fix iconv failing test
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=854821#27

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-01-19 22:15:07 +01:00
Maurício Meneghini Fauth
4f574e53c3
Replace error report jquery-ui's dialog with a modal
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-12 17:28:23 -03:00
Maurício Meneghini Fauth
443e4289c3
Replace user groups jQuery UI's dialog with a modal
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-12 17:28:22 -03:00
Maurício Meneghini Fauth
65ca0c1b2c
Extract HTML from Database\Routines::getEditorForm method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-08 17:49:22 -03:00
Maurício Meneghini Fauth
53f5247811
Merge FormDisplay::getDisplay templates
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-05 19:25:21 -03:00
Maurício Meneghini Fauth
d042998f6a
Remove FormDisplayTemplate dep from Setup\ConfigController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-04 14:04:32 -03:00
Maurício Meneghini Fauth
d8c1d6e7a1
Extract HTML from FormDisplayTemplate::displayInput
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-03 18:25:14 -03:00
Maurício Meneghini Fauth
65dd7e8278
Wrap settings tabs with Bootstrap's cards
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-02 18:51:11 -03:00
Maurício Meneghini Fauth
9a2989f3ac
Add Bootstrap for Setup pages
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-12-31 17:52:16 -03:00
Maurício Meneghini Fauth
c9ab66170a
Replace Settings page tabs with Bootstrap's tabs
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-12-30 23:20:40 -03:00
Maurício Meneghini Fauth
4ad6e2ea4e
Use Bootstrap's pagination for user accounts page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-12-29 17:59:59 -03:00
Maurício Meneghini Fauth
5178f76f95
Move fieldset CSS style to the .pma-fieldset class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-12-28 19:46:40 -03:00
Maurício Meneghini Fauth
ac4bfaebe7
Remove some custom CSS utilities
Uses Bootstrap equivalents.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-12-26 20:05:03 -03:00
Maurício Meneghini Fauth
2625e0e1f6
Replace .caution and .success CSS classes
Replaces with .text-danger and .text-success.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-12-23 19:37:52 -03:00
Maurício Meneghini Fauth
d3c31fabd4
Remove some custom CSS utilities
Uses Bootstrap equivalents.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-12-23 19:06:38 -03:00
Maurício Meneghini Fauth
6408b7179a
Fix renamed Bootstrap 5 classes
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-12-21 15:28:39 -03:00
CommanderRoot
63d2e7735a
Fix failing theme test
Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
2020-12-20 04:22:50 +01:00
William Desportes
b4f1e14e80
fix or ignore phpstan 0.12.63 errors
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-12-18 22:17:18 +01:00