Commit Graph

96 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
1e5fbd57fc
Create Twig\AssetExtension and image Twig function
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-28 16:09:17 -03:00
Maurício Meneghini Fauth
4ad6e2ea4e
Use Bootstrap's pagination for user accounts page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-12-29 17:59:59 -03:00
Maurício Meneghini Fauth
5178f76f95
Move fieldset CSS style to the .pma-fieldset class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-12-28 19:46:40 -03:00
William Desportes
1b5781f825
Fix #16477 - Fix failing unit test
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-11-15 22:54:05 +01:00
Saksham Gupta
be3905944f Fixes: https://github.com/phpmyadmin/phpmyadmin/issues/16477
Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Fix db Edit privileges

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Fix conflict

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Add missing bracket

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Fix Lint

Signed-off-by: Saksham Gupta <shucon01@gmail.com>
2020-11-16 02:09:54 +05:30
Maurício Meneghini Fauth
4873c32273 Remove DatabaseInterface::isUserType method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-25 20:53:50 -03:00
Maurício Meneghini Fauth
71d9a8f760 Remove is_grantuser and is_createuser PHP globals
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-23 22:58:49 -03:00
Maurício Meneghini Fauth
db3da81056 Remove some useless comments
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-13 19:56:56 -03:00
Maurício Meneghini Fauth
34dd2a61f8 Remove strPrivDesc* global variables
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-11 17:22:30 -03:00
Maurício Meneghini Fauth
ceac762e09 Remove pmaThemePath and pmaThemeImage PHP globals
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-02 10:57:57 -03:00
Maurício Meneghini Fauth
ba09c84a05 Fix PHPStan errors for PHPUnit assert methods
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-10 16:20:53 -03:00
Maurício Meneghini Fauth
c92663adbb Move ChangePassword::getHtml to Server\Privileges class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-29 19:12:35 -03:00
Maurício Meneghini Fauth
ae975e594e Remove Privileges::getHtmlForUserGroupDialog method
Related to https://github.com/phpmyadmin/phpmyadmin/issues/16258.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-17 12:42:58 -03:00
Maurício Meneghini Fauth
47f0960dce Add return type declaration to test methods
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-07 11:31:33 -03:00
Maurício Meneghini Fauth
e81146e4b3 Remove useless return annotations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-07 10:30:27 -03:00
Maurício Meneghini Fauth
dfa5f92c31 Add return type declaration to fetch row methods
DatabaseInterface's fetchArray, fetchAssoc, fetchRow and fetchSingleRow
methods.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-06-29 20:32:04 -03:00
William Desportes
076d7b1a7f
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-07 18:27:18 +02:00
William Desportes
5164bea16a
Fix #16166 - Make the alter user privileges MySQL 8.0.11+ compatible
Ref: #14217
Ref: #14788

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-07 18:08:50 +02:00
William Desportes
a300a25319
Replace assertEquals({false,true} by assert{false,true}
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-26 13:13:15 +02:00
Maurício Meneghini Fauth
3ae05c785d Use short list syntax and single line arrays
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 03:32:59 -03:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
9269d75fb4 Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 20:22:18 -03:00
William Desportes
0964470643
Use parent::setGlobalConfig();
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 13:19:23 +02:00
William Desportes
8f7d3d1fa7
Fix test cases after backupGlobals = false
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 02:07:45 +02:00
William Desportes
6eaa55e805
Call parent's setUp and tearDown
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 21:31:13 +02:00
William Desportes
8ef5143901
Use AbstractTestCase on all unit tests
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 21:15:06 +02:00
William Desportes
f063c553f2
Fix some tests executed in random order
Using: ./vendor/bin/phpunit --order-by=random --random-order-seed=1589977275 --exclude=selenium --no-coverage --filter=FormDisplayTest

Seeds: 1590000479, 1589977275, 1589998302, x1590001040, x1590001183

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 21:10:32 +02:00
William Desportes
0b2c24ee26
Use ::class in tests
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 12:15:40 +02:00
Maurício Meneghini Fauth
a64393e7f5 Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-13 00:23:28 -03:00
William Desportes
7db0debd05
Fix some failing tests
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-02 01:51:51 +02:00
William Desportes
b8b5c026a9
Remove MissingReturnType psalm ignore
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-04-28 23:30:00 +02:00
Maurício Meneghini Fauth
d612215aab Remove dropdown field generator
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-30 01:59:03 -03:00
William Desportes
966e9277a6
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-23 00:47:55 +01:00
William Desportes
e671ee3ebb
Fix #15282 - MySQL 8.0 password syntax error when creating a replication user
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-23 00:39:06 +01:00
Maurício Meneghini Fauth
206199105e Remove useless return type annotations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
676f48349a Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf Use one line for comments with a single line
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
285907991e Add coding standard rules for whitespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-19 22:29:54 -03:00
Maurício Meneghini Fauth
39f42f848b Remove some useless docblock comments
Fixes docblock spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-13 21:15:00 -03:00
Maurício Meneghini Fauth
dd06cd38f8 Defines rules for double quote usage
Makes sure that any use of double quotes strings are warranted.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-01 14:10:07 -03:00
Hugues Peccatte
3255e4ad7b Split Util class regarding the responsabilities (#15567)
PhpMyAdmin\Util is a very huge class with a lot of responsabilities.

There is a lot of work to split it, but this may be just a small start, waiting for a more normalized code.

* Split Util class regarding the responsabilities
* Split the buttonOrImage function

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-11-21 20:20:05 -03:00
Maurício Meneghini Fauth
d7bc90fa2c Extract HTML from db and table links line
Server\Privileges::getLinkToDbAndTable

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-05 20:07:38 -03:00
Maurício Meneghini Fauth
cc44bd9e67 Move change login info to user properties template
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-05 16:37:08 -03:00
Maurício Meneghini Fauth
672aee2d8a Create Database\PrivilegesController
Extracts Server\Privileges::getHtmlForSpecificDbPrivileges method to a
controller.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-29 21:09:24 -03:00
Maurício Meneghini Fauth
600079f0f0 Create Table\PrivilegesController
Extract Server\Privileges::getHtmlForSpecificTablePrivileges to a
controller.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-29 16:32:07 -03:00
Maurício Meneghini Fauth
9b36c0116d Extract method to get all db and table privileges
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-29 00:38:48 -03:00
Maurício Meneghini Fauth
b24c2fb7f8 Refactor db and table privileges code
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-25 16:15:17 -03:00
Maurício Meneghini Fauth
10003ee263 Extract HTML from Privileges::getUsersOverview
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-07 18:18:09 -03:00
Maurício Meneghini Fauth
3221ebb7cc Refactor routine specific privileges method
Refactors Server\Privileges::getHtmlForRoutineSpecificPrivileges

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-05 20:31:58 -03:00