gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
117,525 Commits 12 Branches 481 Tags 2.4 GiB
bc89e83869
Commit Graph

49 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
206199105e Remove useless return type annotations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
676f48349a Reference global funcs and consts via use statement 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations 
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
63dbcd01d9 Remove or ignore side effects in PHP files 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-19 20:22:37 -03:00
Maurício Meneghini Fauth
693bf67b1c Refactor Database\CentralColumnsController class 
Moves the central columns entry point logic to the controller and
removes the entry point file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-26 12:51:35 -03:00
Maurício Meneghini Fauth
dd06cd38f8 Defines rules for double quote usage 
Makes sure that any use of double quotes strings are warranted.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-01 14:10:07 -03:00
Hugues Peccatte
3255e4ad7b Split Util class regarding the responsabilities (#15567) 
PhpMyAdmin\Util is a very huge class with a lot of responsabilities.

There is a lot of work to split it, but this may be just a small start, waiting for a more normalized code.

* Split Util class regarding the responsabilities
* Split the buttonOrImage function

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-11-21 20:20:05 -03:00
Maurício Meneghini Fauth
1a14b3e4d3 Remove vim modelines 
These settings are no longer required as they are guaranteed through
other coding standard tools.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-09-02 09:43:21 -03:00
Maurício Meneghini Fauth
c57e8540fc Use the router for the central columns page 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-08-05 18:19:04 -03:00
Maurício Meneghini Fauth
e1f9ae00cd Add a trailing comma in multi-line arrays 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-14 14:09:26 -03:00
Maurício Meneghini Fauth
50ec2c0e2b Create Controllers\Database\CentralColumnsController 
Moves db_central_columns.php logic to the controller

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-03-05 02:12:12 -03:00
Maurício Meneghini Fauth
92cc67fbf7 Replace assertContains() with assertStringContainsString() 
Using assertContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringContainsString() or assertStringContainsStringIgnoringCase() instead.
Using assertNotContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringNotContainsString() or assertStringNotContainsStringIgnoringCase() instead.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-02-24 16:32:28 -03:00
Maurício Meneghini Fauth
182491a73f Add void return type declaration for tests 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-02-22 21:33:55 -03:00
Maurício Meneghini Fauth
23c3579804 Format array declarations 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-01-07 14:31:39 -02:00
Maurício Meneghini Fauth
999b4d14f0 Fix some coding standard errors 
- Fixes array identation
- Removes empty statements

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-01-05 21:25:08 -02:00
Maurício Meneghini Fauth
ef5d7dd66b Use Bootstrap buttons component 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-12-21 01:01:12 -02:00
Maurício Meneghini Fauth
9eba565bf4 Remove unnecessary HTML closing tags 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-12-19 00:12:54 -02:00
Maurício Meneghini Fauth
76d8bfdafa Merge branch 'QA_4_8' 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-12-12 21:04:19 -02:00
Maurício Meneghini Fauth
77ea7024bf Retrieve parameters from $_POST in central columns page 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-11-10 20:48:58 -02:00
Gabriel Caruso
c1435d5b07
Use Null Coalesce Operator 
Signed-off-by: Gabriel Caruso <carusogabriel34@gmail.com>
 2018-09-07 22:59:37 -03:00
Piyush Vijay
229deb9be0
Add test for getHtmlForColumnDropdown. 
Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
 2018-07-28 21:29:19 +05:30
Maurício Meneghini Fauth
2d58411bee Some coding style fixes 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-06-18 21:30:06 -03:00
Leonardo Strozzi
be673f908d Refactor db central columns templates 
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
 2018-06-03 00:34:12 -03:00
Maurício Meneghini Fauth
2005cca77f Fix methods and properties visibility issues 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-30 21:02:26 -03:00
Maurício Meneghini Fauth
285e38e931 Fix some PSR-2 coding standard errors 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-30 09:07:56 -03:00
Maurício Meneghini Fauth
b9c0463d96 Use short array syntax instead of long array syntax 
Replaces array() with [].

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-30 01:42:21 -03:00
Maurício Meneghini Fauth
dc8c92bfd8 Enable strict mode in test files 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-16 04:36:04 -03:00
Maurício Meneghini Fauth
d1cf17d2d7 Add type declarations to PhpMyAdmin\CentralColumns 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-04-14 07:00:21 -03:00
Leonardo Strozzi
eb6e40f053 Addapt getHtmlForTableNavigation to twig template 
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
 2018-03-23 00:34:26 -03:00
Leonardo Strozzi
2c7f3613ee Addapt getHtmlForAddColumn to use twig template 
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
 2018-03-21 21:50:24 -03:00
Maurício Meneghini Fauth
87056ca57c Move DisableIS setting to constructor 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-02-04 16:37:28 -02:00
Maurício Meneghini Fauth
78b3ac810f Move CharEditing setting to constructor 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-02-04 16:37:28 -02:00
Maurício Meneghini Fauth
763e161355 Move MaxRows setting to constructor 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-02-04 16:37:27 -02:00
Maurício Meneghini Fauth
4c661bd1fd Move current server user global to constructor 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-02-04 16:37:27 -02:00
Maurício Meneghini Fauth
e2a648881c Move DatabaseInterface object to constructor 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-02-04 16:37:27 -02:00
Maurício Meneghini Fauth
fbab1101c0 Refactor CentralColumnsTest method names 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-02-04 16:37:27 -02:00
Maurício Meneghini Fauth
e9bc3e0cd5 Fix visibility of the methods 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-02-04 16:37:27 -02:00
Maurício Meneghini Fauth
dc2b2d4f6c Replace static methods with instance methods 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-02-04 16:37:27 -02:00
Maurício Meneghini Fauth
42cc8ece2c Replace globals with DI in CentralColumns class 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-09 11:53:28 -02:00
Gabriel Caruso
45828153b6 Use PSR-1 for PHPUnit TestCase 
Signed-off-by: Gabriel Caruso <carusogabriel34@gmail.com>
 2017-11-06 06:29:04 -02:00
Maurício Meneghini Fauth
5a70c1d895 Replace globals with DI in CentralColumns class 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-05 22:21:58 -02:00
Michal Čihař
4fe87fb592 Remove usage of $GLOBALS['controllink'] 
This is now stored internally inside DatabaseInterface instance.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-10-25 10:21:18 +02:00
Scrutinizer Auto-Fixer
40f56c0a95 Remove not needed use statements 
This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-10-23 18:49:37 +02:00
Michal Čihař
d574aede08 Bind Types to DatabaseInterface 
This wayt it's automatically passed with DBI.

Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-10-10 12:05:02 +02:00
Michal Čihař
b5e391f006 Merge Types and TypesMySQL classes 
These were separate from time we've supported Drizzle, but this no
longer makes sense.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-10-10 11:33:45 +02:00
Maurício Meneghini Fauth
433c2725be Add namespace to plugins tests 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-09-20 13:03:50 -03:00
Maurício Meneghini Fauth
df30240015 Add namespace to test classes 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-09-20 13:03:50 -03:00
Michal Čihař
a82f8fc768 Move databaase interface load to static method 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-09-06 14:46:56 +02:00
Maurício Meneghini Fauth
5b0ba627d3 Refactor central_columns functions to static methods 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-08-28 13:31:47 -03:00