Maurício Meneghini Fauth
206199105e
Remove useless return type annotations
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
676f48349a
Reference global funcs and consts via use statement
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
f80d3e3bd4
Remove unnecessary annotations
...
@package, @subpackage and others.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf
Use one line for comments with a single line
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
50bc4ab37f
Remove useless PHP docs for functions
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 13:20:01 -03:00
Maurício Meneghini Fauth
285907991e
Add coding standard rules for whitespace
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-19 22:29:54 -03:00
Maurício Meneghini Fauth
b1328c7ad6
Create Server\UserGroupsController controller
...
Moves the user groups entry point logic to the controller and removes
the entry point file.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-22 11:54:34 -03:00
Maurício Meneghini Fauth
39f42f848b
Remove some useless docblock comments
...
Fixes docblock spacing
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-13 21:15:00 -03:00
Maurício Meneghini Fauth
77518d341e
Remove unused use statements
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-11 21:20:58 -03:00
Maurício Meneghini Fauth
dd06cd38f8
Defines rules for double quote usage
...
Makes sure that any use of double quotes strings are warranted.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-01 14:10:07 -03:00
Hugues Peccatte
3255e4ad7b
Split Util class regarding the responsabilities ( #15567 )
...
PhpMyAdmin\Util is a very huge class with a lot of responsabilities.
There is a lot of work to split it, but this may be just a small start, waiting for a more normalized code.
* Split Util class regarding the responsabilities
* Split the buttonOrImage function
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-11-21 20:20:05 -03:00
Maurício Meneghini Fauth
d7bc90fa2c
Extract HTML from db and table links line
...
Server\Privileges::getLinkToDbAndTable
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-05 20:07:38 -03:00
Maurício Meneghini Fauth
cc44bd9e67
Move change login info to user properties template
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-05 16:37:08 -03:00
Maurício Meneghini Fauth
672aee2d8a
Create Database\PrivilegesController
...
Extracts Server\Privileges::getHtmlForSpecificDbPrivileges method to a
controller.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-29 21:09:24 -03:00
Maurício Meneghini Fauth
600079f0f0
Create Table\PrivilegesController
...
Extract Server\Privileges::getHtmlForSpecificTablePrivileges to a
controller.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-29 16:32:07 -03:00
Maurício Meneghini Fauth
9b36c0116d
Extract method to get all db and table privileges
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-29 00:38:48 -03:00
Maurício Meneghini Fauth
b24c2fb7f8
Refactor db and table privileges code
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-25 16:15:17 -03:00
Maurício Meneghini Fauth
10003ee263
Extract HTML from Privileges::getUsersOverview
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-07 18:18:09 -03:00
Maurício Meneghini Fauth
3221ebb7cc
Refactor routine specific privileges method
...
Refactors Server\Privileges::getHtmlForRoutineSpecificPrivileges
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-05 20:31:58 -03:00
Maurício Meneghini Fauth
1a14b3e4d3
Remove vim modelines
...
These settings are no longer required as they are guaranteed through
other coding standard tools.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-02 09:43:21 -03:00
Maurício Meneghini Fauth
f2b2c51ea8
Move table specific privs logic to privs table
...
Moves getHtmlForTableSpecificPrivileges logic to
getHtmlToDisplayPrivilegesTable
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-31 20:41:12 -03:00
Maurício Meneghini Fauth
b7250665c2
Move some table privileges view logic to template
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-31 15:05:55 -03:00
Maurício Meneghini Fauth
7eca9d8e2b
Extract HTML from global/database specific privs
...
Server\Privileges::getHtmlForGlobalOrDbSpecificPrivs
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-28 16:29:13 -03:00
Maurício Meneghini Fauth
d3fb94a674
Extract HTML from table specific privileges
...
Server\Privileges::getHtmlForTableSpecificPrivileges
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-28 00:51:35 -03:00
Maurício Meneghini Fauth
542059eca0
Use the router for the user groups page
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-12 18:26:07 -03:00
Maurício Meneghini Fauth
c9cfd5f373
Extract HTML from Server\Privileges::getHtmlForAddUser
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-29 22:46:11 -03:00
Maurício Meneghini Fauth
0f23a622bc
Use the router for the server privileges page
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-23 02:48:02 -03:00
Maurício Meneghini Fauth
dc7372fb99
Fix URL query issues with Util::getScriptNameForOption
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-22 17:30:18 -03:00
Maurício Meneghini Fauth
21a747cfbe
Add tests for Server\Plugin and Server\Plugins
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-03 20:19:00 -03:00
Maurício Meneghini Fauth
e1f9ae00cd
Add a trailing comma in multi-line arrays
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-14 14:09:26 -03:00
Maurício Meneghini Fauth
c049dfa7a6
Replace alias functions with their respective functions
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 14:49:47 -03:00
Maurício Meneghini Fauth
7be0f6bfae
Reference class names in use statements
...
Sort use statements
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 00:14:26 -03:00
William Desportes
e453ad1320
Merge branch 'QA_4_8'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-27 19:15:57 +02:00
William Desportes
646668b52d
Fix Unit tests for #15229
...
See: 91c758aae4
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-27 19:01:59 +02:00
Maurício Meneghini Fauth
3ac708ab32
Remove PhpMyAdmin\Server\Status\Data::getMenuHtml()
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-25 19:07:15 -03:00
Maurício Meneghini Fauth
2074be7eab
Create Server\Status\VariablesController
...
Extracts server_status_variables.php and Server\Status\Variables logic
to the controller.
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-25 19:02:54 -03:00
Maurício Meneghini Fauth
e149a6188f
Create Server\Status\QueriesController
...
Extracts server_status_queries.php and Server\Status\Queries logic to
the controller.
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-25 00:53:57 -03:00
Maurício Meneghini Fauth
92cc67fbf7
Replace assertContains() with assertStringContainsString()
...
Using assertContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringContainsString() or assertStringContainsStringIgnoringCase() instead.
Using assertNotContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringNotContainsString() or assertStringNotContainsStringIgnoringCase() instead.
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-24 16:32:28 -03:00
Maurício Meneghini Fauth
182491a73f
Add void return type declaration for tests
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-22 21:33:55 -03:00
Maurício Meneghini Fauth
c485c311aa
Create Server\Status\ProcessesController
...
Extracts server_status_processes.php and Server\Status\Processes logic
to controller.
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-21 23:25:30 -03:00
Maurício Meneghini Fauth
12ae5553a6
Create Server\Status\MonitorController
...
Moves server_status_monitor.php logic to controller
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-21 02:23:23 -03:00
Maurício Meneghini Fauth
5368c151b4
Create Server\Status\StatusController
...
- Extracts Server\Status and server_status.php logic to controller
- Extracts HTML to server/status/status/index template
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-18 15:59:59 -03:00
Maurício Meneghini Fauth
4bf6ad1952
Create Server\Status\AdvisorController
...
- Moves PhpMyAdmin\Server\Status\Advisor and server_status_advisor.php
logic to the controller.
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-17 16:03:09 -03:00
Maurício Meneghini Fauth
23c3579804
Format array declarations
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-07 14:31:39 -02:00
Maurício Meneghini Fauth
4cee0cbc12
Adds space after not (!) and type cast
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-05 21:56:34 -02:00
Maurício Meneghini Fauth
2edd97a62b
Merge branch 'QA_4_8'
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-21 01:55:50 -02:00
Maurício Meneghini Fauth
12f898d871
Fix issue when adding user on MySQL 8.0.11
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-19 22:23:46 -02:00
Maurício Meneghini Fauth
9eba565bf4
Remove unnecessary HTML closing tags
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-19 00:12:54 -02:00
Maurício Meneghini Fauth
76d8bfdafa
Merge branch 'QA_4_8'
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-12 21:04:19 -02:00
William Desportes
f0b51c144f
Remove unused code in tests
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-11-29 19:15:41 +01:00