gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
136,171 Commits 12 Branches 481 Tags 2.4 GiB
bcaf89c19f
Commit Graph

33 Commits

Author SHA1 Message Date
Kamil Tekiela
90caa57986 Remove all unnecessary tearDown 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2026-02-19 22:24:48 +00:00
Kamil Tekiela
6aed3a134e Remove duplicate 'Server' element 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2026-02-17 18:31:37 +00:00
Kamil Tekiela
4c2a4b4cd4
Move $default to UserPreferencesHandler 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2026-02-03 09:59:13 -03:00
Kamil Tekiela
977cf11caf
Remove unnecessary Config::$instance assignments 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2026-02-03 09:59:13 -03:00
Kamil Tekiela
244bde1a9a
Move createConfig to ConfigTest 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2026-02-03 09:59:13 -03:00
Maurício Meneghini Fauth
cad4c6fc1e
Extract user preferences handling from Config class 
This removes the Config's circular dependency on DatabaseInterface
class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2026-01-09 11:27:47 -03:00
Kamil Tekiela
1e66018a6e
DataProvider types 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-10-12 20:06:00 -03:00
Hendrik Becker
abf7936acb avoid static constant evaluation in GD check; simplify test 
- Replace constant('GD_MAJOR_VERSION') >= 2 with runtime lookup to prevent PHPStan’s “2 >= 2 always true”.
- Remove redundant defined('GD_MAJOR_VERSION') branch; behavior unchanged (?? 0 covers missing constant).

Signed-off-by: Hendrik Becker <luckyfellow@object.earth>
 2025-08-23 12:27:55 -06:00
Hendrik Becker
74d38eeca7 Refactor GD2 availability check to use GD_MAJOR_VERSION 
Replaced fragile checks (`imagecreatetruecolor`, `gd_info`, phpinfo parsing)
with the GD_MAJOR_VERSION constant (available since PHP 5.2.4). This avoids
false positives (e.g. matching "2." in "3.2.0") and false negatives
(e.g. missing "3.0.0"), making detection precise.

Updated PHPUnit tests accordingly.

Signed-off-by: Hendrik Becker <luckyfellow@object.earth>
 2025-08-22 22:29:29 -06:00
Maximilian Krög
8286d5c555
Indent heredocs 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2025-08-18 21:09:05 +02:00
Kamil Tekiela
b462cc7090 Remove Config::get() method 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-24 17:13:54 +00:00
Kamil Tekiela
a25527ef8d Refactor loadAndCheck() 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-24 17:12:24 +00:00
Kamil Tekiela
1c5249ab59 Remove OBGzip 
Functionality was removed in 54a080c15d

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-24 17:12:24 +00:00
Kamil Tekiela
410b84ce33 Change PMA_IS_GD2 isGd2Available() method 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-24 17:12:24 +00:00
Kamil Tekiela
2fd793f53a Create UserAgentParser class 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-24 17:12:24 +00:00
Kamil Tekiela
f45080b091 Change PMA_IS_WINDOWS to isWindows() method 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-24 17:12:23 +00:00
Kamil Tekiela
017cdd92cd Untangle $isHttps 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-24 17:12:23 +00:00
Kamil Tekiela
ca4490323d Convert OBGzip to $config 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-24 17:12:23 +00:00
Kamil Tekiela
e045e7f910 Improve type hints 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-24 17:12:23 +00:00
Kamil Tekiela
b008be5570 Add one more condition to configPaths 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-24 17:12:23 +00:00
Kamil Tekiela
1aa8f7b182 Remove unhelpful testCheckPermissions 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-24 17:12:23 +00:00
Kamil Tekiela
afb806b181 Untangle $source 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-24 17:12:23 +00:00
Kamil Tekiela
9a6fef7e65 Remove $this->sourceMtime = 0; 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-24 17:12:23 +00:00
Kamil Tekiela
35b50c73e4 Rename checkConfigSource 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-24 17:12:23 +00:00
Kamil Tekiela
8015e4de72 Move DatabaseInterface to Dbal 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-12-22 18:34:53 +00:00
Kamil Tekiela
ee57b0c72f Use strict assertions 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-12-03 17:27:13 +00:00
Kamil Tekiela
17de1bdf93 Add a type cast to match tested expectation 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-12-03 17:27:13 +00:00
Maurício Meneghini Fauth
2c597e3f79
Fix compatibility with PHPUnit 11 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2024-08-29 13:51:46 -03:00
Maurício Meneghini Fauth
67a5c14e81
Remove TEST_PATH constant 
Replace the TEST_PATH constant with __DIR__ to make the tests more
portable.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2024-07-16 14:10:16 -03:00
Maurício Meneghini Fauth
dc1bd60dd1
Fix boolean usage of the return value of preg_match() 
preg_match() and preg_match_all() returns the number of pattern matches
(which might be zero), or false on failure. However, preg_match() always
returns 1 when a pattern is matched as it stops searching after the
first match.

- https://www.php.net/manual/en/function.preg-match.php
- https://www.php.net/manual/en/function.preg-match-all.php

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2024-07-13 14:43:05 -03:00
Kamil Tekiela
82c85d26c0
Clean up of tests (#19067) 
* Fix wrong type hint

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use $this instead of parent

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* setUp should be a protected method

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* onNotSuccessfulTest should be protected

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $command doesn't need to be a property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Give alertText() proper return type

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use null-safe operator

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Call Message static constructors statically

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Call StorageEngine methods statically

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add better type hints in PrivilegesController

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use packed (without keys) arrays in tests

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use type casts instead of function casts

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use const instead of private property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use const instead of private property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix testAuthFailsTooLongPass()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace loop with array_shift

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use ob_get_clean

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove duplicated code

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use assert instead of phpdoc

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-03-20 13:34:55 -03:00
Kamil Tekiela
6b4a77b073 Remove more unnecessary asserts 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-03-18 21:25:07 +01:00
Maurício Meneghini Fauth
606f66b5df
Rename tests/classes to tests/unit 
This directory is for unit tests only, so let's rename it to unit to be
more clear.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2024-02-23 13:29:07 -03:00