Commit Graph

65 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
244d4e8e81 Replace Template::get calls in libraries/classes
Uses Template::render() instead of Template::get().

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-18 18:18:24 -03:00
Maurício Meneghini Fauth
2f99429917 Fix coding style errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-09 16:57:05 -03:00
Maurício Meneghini Fauth
f24545e633 Refactor Config/FormDisplayTemplate
Replaces $GLOBALS['PMA_Config'] with DI

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-06 15:47:00 -03:00
Maurício Meneghini Fauth
8cad698ead Refactor FormDisplayTemplate
Uses a class member instead of a global.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-05 23:07:16 -03:00
Maurício Meneghini Fauth
b25be9ee75 Refactor Config/FormDisplayTemplate methods
Replaces static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-05 22:47:17 -03:00
Maurício Meneghini Fauth
010a72dc00 Use camelCase for variable names
PhpMyAdmin\Config\* classes

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-04 21:25:24 -03:00
Maurício Meneghini Fauth
b101167220 Refactor libraries/config.values.php
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-01 01:56:25 -03:00
Maurício Meneghini Fauth
285e38e931 Fix some PSR-2 coding standard errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 09:07:56 -03:00
Maurício Meneghini Fauth
b9c0463d96 Use short array syntax instead of long array syntax
Replaces array() with [].

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 01:42:21 -03:00
Isaac Bennetch
83f433695b Merge branch 'QA_4_8' 2018-05-20 21:20:07 -04:00
Isaac Bennetch
f2b068e1d3 Better fix for issue #14309
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2018-05-20 21:17:16 -04:00
Maurício Meneghini Fauth
447f7ae3d1 Merge branch 'QA_4_8'
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-19 16:33:10 -03:00
Maurício Meneghini Fauth
54eb5ffff8 Fix Config\FormDisplayTemplateTest failed test
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-19 16:29:17 -03:00
Phoenix Eve Aspacio
e84c7f60e3 fixes broken links to icons in the setup page
fixes broken links to icons in the setup page

Signed-off-by: Phoenix Eve Aspacio <aspaciop@phoenixpeca.xyz>
(cherry picked from commit bc1fee27be)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-19 14:56:08 -03:00
Maurício Meneghini Fauth
2dcf6615f5
Merge pull request #14272 from PhoenixPeca/patch-1
fixes broken links to icons in the setup page
2018-05-19 14:54:15 -03:00
Maurício Meneghini Fauth
baf0985e5f Fix phpcs errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-18 01:59:38 -03:00
Maurício Meneghini Fauth
b6435e9ed2 Enable strict mode in Config classes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-15 01:03:57 -03:00
Phoenix Eve Aspacio
bc1fee27be
fixes broken links to icons in the setup page
fixes broken links to icons in the setup page

Signed-off-by: Phoenix Eve Aspacio <aspaciop@phoenixpeca.xyz>
2018-05-09 23:09:57 +08:00
Piyush Vijay
4304a66995 Duplicate hidden token input field issue solved (#14211)
* Duplicate hidden token input fields: #14209 issue fixed
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>

* duplicate hidden input for token removed from error reporting form.
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
2018-05-03 21:47:05 -03:00
Saksham Gupta
d701f6f0af Remove font size feature (#13925)
Fix #13919

Signed-off-by: Saksham Gupta <shucon01@gmail.com>
2018-04-14 07:21:13 -03:00
Maurício Meneghini Fauth
35eb2da38a Remove @ operator from function_exists
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-03-01 22:36:35 -03:00
Maurício Meneghini Fauth
17bf8b7309 Replace static methods with instance methods
Replaces PhpMyAdmin\UserPreferences static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-23 15:26:02 -03:00
Michal Čihař
1ebf6c4953 Remove references to sourceforge.net issue trackers
We do not use it for years and all issues have been migrated.

Signed-off-by: Michal Čihař <michal@cihar.com>
2018-01-02 13:24:05 +01:00
Maurício Meneghini Fauth
01fd301003 Use 'elseif' keyword istead of 'else if'
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-12-04 13:31:25 -02:00
Michal Čihař
3b6a994dcd Move collation connection setting to user preferences
It is now handled same way as other user settings.

Issue #11688
Issue #13466

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-29 14:16:31 +01:00
Michal Čihař
48c0a1081d Remember state of navigation panel
The NavigationPanel width is now 0 when panel should be collapsed.

Issue #13466
Fixes #13397

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-28 16:07:08 +01:00
Michal Čihař
216f403c28 Store navigation width in user preferences
There is no need to have this separetely.

Issue #13466
Issue #11688

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-28 15:36:08 +01:00
Michal Čihař
f9c73c7b10 Remove special casing for font size
It is now stored in configuration in same way as any other setting.

Issue #13466
Issue #11688

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-28 15:16:01 +01:00
Michal Čihař
cbbf0d5ccf Integrate debug console settings into user preferences
Issue #13466
Issue #11688

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-28 13:52:07 +01:00
Michal Čihař
b30ab4af58 Generalize code for console preferences
We can reuse and better cache locally the operations to avoid additional
roundtrip to server when changing settings.

Issue #13466
Issue #11688

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-28 13:45:14 +01:00
Michal Čihař
a2fd98d9f1 Add console preferences
This will allow to use console preferences using normal userconfig
framework.

Issue #13466

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-28 13:08:49 +01:00
Michal Čihař
bed6fb4ebd Avois passing extension to Util::getImage
We do not use it anyway for quite some time and this way it's less
processing to generate the img tag.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-27 14:24:42 +01:00
Michal Čihař
22efbd263e Fix typo in transformation
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-14 10:48:43 +01:00
Maurício Meneghini Fauth
1f482ff6e7 Use template for displayFormBottom
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-10 19:19:43 -02:00
Maurício Meneghini Fauth
70b592ba61 Usa template for displayTabsBottom
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-10 19:19:43 -02:00
Maurício Meneghini Fauth
ed76f7cffd Remove displayFieldsetBottomSimple method
Can be replaced by displayFieldsetBottom(false)

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-10 19:19:43 -02:00
Maurício Meneghini Fauth
f64e0e1742 Use template for displayErrors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-10 19:19:43 -02:00
Maurício Meneghini Fauth
ce9902b5f5 Use template for displayGroupHeader
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-10 18:20:32 -02:00
Maurício Meneghini Fauth
729349d326 Use template for displayFieldsetTop
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-10 16:07:00 -02:00
Maurício Meneghini Fauth
72bcc1336f Use template for displayFieldsetBottom
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-10 15:08:28 -02:00
Maurício Meneghini Fauth
1d4125f15c Add array type declarations
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-24 23:49:59 -03:00
Maurício Meneghini Fauth
614b8a6978 Refactor setup/index functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-14 17:51:34 -03:00
Maurício Meneghini Fauth
695f51034d Refactor FormDisplay.tpl functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-14 11:53:56 -03:00
Maurício Meneghini Fauth
ce49e7f60f Refactor user_preferences functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-12 22:31:02 -03:00
Maurício Meneghini Fauth
711b462dea Automatic fixes by phpcbf
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-09 14:55:17 -03:00
Michal Čihař
35fca8e2d5 Remove not used BaseFormList::getDefault
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-06 12:00:17 +02:00
Michal Čihař
3559f7a8a5 Remove special casing for UserprefsDeveloperTab
- include it in user form only if allowed
- always include it in setup form

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-06 11:06:51 +02:00
Michal Čihař
e065793dc8 Fold validity check with getting class
There is no need to do this twice (once in ::get).

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-06 11:06:51 +02:00
Michal Čihař
5788613cbc Use form name for menu in user preferences
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-06 11:05:10 +02:00
Michal Čihař
953ef05b92 Use forms to define menu and titles on setup
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-06 11:05:10 +02:00