Commit Graph

4411 Commits

Author SHA1 Message Date
Isaac Bennetch
25e423ef09 Prepare for version 5.2.3-dev
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2025-01-21 15:40:30 -05:00
Isaac Bennetch
37b03ea30b Prepare for version 5.2.2
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2025-01-20 22:12:20 -05:00
Maurício Meneghini Fauth
e6f08a8682 Ignore ISO-2022-CN-EXT charset for iconv
Fixes possible glibc/iconv vulnerability (CVE-2024-2961).

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-01-20 14:14:17 -05:00
Maurício Meneghini Fauth
7355ddff8d Fix XSS vulnerability on Insert page
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-01-20 14:02:28 -05:00
Maurício Meneghini Fauth
23c13a8170 Fix unescaped table name when checking tables
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-01-20 13:54:12 -05:00
Maurício Meneghini Fauth
cf886df108 Ignore system databases when deleting using UI
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-01-20 13:08:55 -05:00
Maurício Meneghini Fauth
8aa2ca9108 Hide Error exception messages when not in dev env
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-01-20 13:07:34 -05:00
William Desportes
ded87e3301
Fix #16936 - Do not specify the collation when creating tables for imported data
Backport of https://github.com/phpmyadmin/phpmyadmin/pull/19035

Signed-off-by: William Desportes <williamdes@wdes.fr>
2025-01-16 11:52:16 +01:00
William Desportes
4d51855d67
Fix #18129 - PHP warning while editting a view definition
Signed-off-by: William Desportes <williamdes@wdes.fr>
2025-01-16 02:56:56 +01:00
Maurício Meneghini Fauth
8b38f49efa
Merge pull request #19520 from kamil-tekiela/Avoid-passing-null-to-synchronizeFavoriteTables
Avoid passing null to synchronizeFavoriteTables
2025-01-14 16:17:51 -03:00
Kamil Tekiela
5e1356f85f Avoid passing null to synchronizeFavoriteTables
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-14 17:22:39 +00:00
Maurício Meneghini Fauth
1da6aeb6c6
Merge pull request #19499 from liviuconcioiu/17730
Fix #17730 - Make LIKE %...% as default search operator
2025-01-13 17:31:16 -03:00
Maurício Meneghini Fauth
152509e8d7
Merge pull request #19490 from kamil-tekiela/warning-about-mysqlnd
Add warning about mysqlnd
2025-01-13 16:40:40 -03:00
Liviu-Mihail Concioiu
01013880df
Fix Undefined global variable $col_priv (#19511)
* Fix query

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>

* Fix Undefined global variable $col_priv

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>

* Fix test

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>

* Update libraries/classes/Normalization.php

Co-authored-by: Maurício Meneghini Fauth <mauricio@mfauth.net>

---------

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
Co-authored-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-01-13 14:49:00 -03:00
William Desportes
227a2f68c6
Merge #19498 - Fix #14542 - Show query if no results found
Pull-request: #19498
Fixes: #14542
Signed-off-by: William Desportes <williamdes@wdes.fr>
2025-01-13 02:48:56 +01:00
Maurício Meneghini Fauth
5ac0d3c6a4
Replace $GLOBALS['l'] with TCPDF::setLanguageArray()
The l global variable was not being used by TCPDF.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-01-11 17:57:45 -03:00
William Desportes
2baf6b33b8
Fix adding a blank row in "copy to clipboard" for each repeating header row
Signed-off-by: William Desportes <williamdes@wdes.fr>
2025-01-07 13:48:50 +01:00
William Desportes
71fb45ace5
Fix #19500 - Use KILL instead of CALL mysql.rds_kill for non super users
Fixes #19500

Signed-off-by: William Desportes <williamdes@wdes.fr>
2025-01-06 13:17:41 +01:00
Liviu-Mihail Concioiu
58bdf3994a Make LIKE %...% as default operator
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2025-01-04 19:55:13 +01:00
Liviu-Mihail Concioiu
db7b4bc583 Show query if no results found
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2025-01-04 18:58:48 +01:00
Kamil Tekiela
29e8f41875 Add warning about mysqlnd
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-02 12:30:15 +00:00
Maurício Meneghini Fauth
9ee8e20385
Merge pull request #19388 from MoonE/revert-query-stats-for-count
Revert "Show query stats for count(*) query"

Didn't manage to fix the duplicate query results, so this is reverts #19221 #19237 for now
Fixes #19245
Should reopen #16869
2024-12-25 12:12:58 -03:00
Maurício Meneghini Fauth
08b992a248
Merge pull request #19448 from liviuconcioiu/table
Fix table detected as view, when table is in use
2024-12-25 12:04:20 -03:00
Liviu-Mihail Concioiu
6c4f66147a Add double quotes for Windows
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2024-12-19 16:33:45 +01:00
William Desportes
18f8ae0da1
Ref #19455 - Move all the code for revision-info.php to the Git class
Pull-request: #19458
Ref: #19455

And add one more new line

Signed-off-by: William Desportes <williamdes@wdes.fr>
2024-12-19 02:08:35 +01:00
William Desportes
1497a1693e
Ensure quotes (') are escaped in revision-info.php files
Signed-off-by: William Desportes <williamdes@wdes.fr>
2024-12-19 02:08:27 +01:00
William Desportes
b950c49a77
Fix #19455 - Support reading all the commit info from revision-info.php
Signed-off-by: William Desportes <williamdes@wdes.fr>
2024-12-19 01:18:29 +01:00
Liviu-Mihail Concioiu
de4a193fe6 Fix table detected as view
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2024-12-15 15:08:57 +01:00
William Desportes
69909646d8
Merge #19428 - Fix #19426 - Extract only the column type into pma_type
Pull-request: #19428
Fixes: #19426
Signed-off-by: William Desportes <williamdes@wdes.fr>
2024-12-13 23:09:38 +01:00
Kamil Tekiela
88cd529519 Don't execute unnecessary queries
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-08 02:46:43 +00:00
Kamil Tekiela
2802fb32ad Better fix
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-06 23:39:35 +00:00
Kamil Tekiela
ea302e792d Extract only the column type into pma_type
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-06 21:17:16 +00:00
William Desportes
3f02e54b61
Merge #19392 - [PHP 8.4] str_getcsv: Fix $escape parameter deprecation
Pull-request: #19392
Signed-off-by: William Desportes <williamdes@wdes.fr>
2024-12-06 22:08:54 +01:00
Maximilian Krög
61b4f6739d Don't abuse name attribute of svg elements
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2024-11-28 09:49:39 -03:00
Maximilian Krög
ed552e83d4 Escape svg label
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2024-11-28 09:46:07 -03:00
Ayesh Karunaratne
8c54f472e6
[PHP 8.4] str_getcsv: Fix $escape parameter deprecation
In PHP 8.4, not passing the `$escape` parameter to the `str_getcsv`
function emits a deprecation error. This fixes the notice by passing
the identical default value for the `$escape` parameter.

 - [Initiating RFC](https://wiki.php.net/rfc/kill-csv-escaping)
 - [Deprecation RFC](https://wiki.php.net/rfc/deprecations_php_8_4#deprecate_proprietary_csv_escaping_mechanism)
 - [PHP 8.4: CSV: The `$escape` parameter must be provided](https://php.watch/versions/8.4/csv-functions-escape-parameter)

Signed-off-by: Ayesh Karunaratne <ayesh@aye.sh>
2024-11-17 13:55:28 +07:00
Maximilian Krög
759fe912a7 Fix error report generation with null context
context may be null, which transferred as post parameteris received
as empty string, but that wasn't handled when shortening the lines.

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2024-11-16 17:00:47 -03:00
Maximilian Krög
e9c3c282e4
Revert "Show query stats for count(*) query"
This reverts commit b9c793e7f8.
This reverts commit 2a4fb46391.

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2024-11-14 01:36:30 +01:00
Liviu-Mihail Concioiu
78f3ff4554 Remove padding around varchar textarea
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2024-11-13 19:29:07 -03:00
Maurício Meneghini Fauth
f6ce169290
Fix issue when updating privs for various databases
The sql_query global variable should be a string, and it can be a string
in this case, which will cause an error as the string will not be
converted to array.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-11-05 15:09:21 -03:00
Maurício Meneghini Fauth
12efd0a0fe
Replace replication statements with new terminology
SHOW MASTER LOGS was removed in MySQL 8.4.0 and SHOW BINARY LOGS is
available since MySQL 4.1.1.

As of MySQL 8.2.0, SHOW BINARY LOG STATUS is available.
As of MariaDB 10.5.2, SHOW BINLOG STATUS is available.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-10-31 13:50:11 -03:00
Liviu-Mihail Concioiu
f3c7a5eb14
Remove whitespace to avoid double whitespace (#19336)
* Remove whitespace to avoid double whitespace

---------

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2024-10-26 12:07:03 -03:00
Duane Morris
7280713fcb
Update to fix replication that broke with MySQL 8.4.0 removal of master and slave commands (#19153)
* Change to supported MySQL 8.4 commands

updated removed master and slave commands with the now supported commands

Signed-off-by: Duane Morris <duane.morris@cambiahealth.com>
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>

* Add backwards compatibility

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>

---------

Signed-off-by: Duane Morris <duane.morris@cambiahealth.com>
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
Co-authored-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-10-23 23:07:55 -03:00
Maurício Meneghini Fauth
0bf7c0fa18
Suppress deprecation message of E_STRICT constant
The E_STRICT constant was deprecated in PHP 8.4.

It's still a possible error level when using PHP 7.2 and PHP 7.3.

See:
https://wiki.php.net/rfc/deprecations_php_8_4#remove_e_strict_error_level_and_deprecate_e_strict_constant

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-10-15 17:18:30 -03:00
Liviu-Mihail Concioiu
1474bb1ad6 Fix input size for hexadecimal values
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2024-10-11 08:22:22 +02:00
Maurício Meneghini Fauth
2fb2477af5
Add phpstan/phpstan-deprecation-rules package
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-09-30 17:14:50 -03:00
Kamil Tekiela
8a8eab813d Fix charset in procedure's parameter type
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-09-24 01:08:10 +01:00
Liviu-Mihail Concioiu
43f114a08d Fix Unknown storage engine InnoDB
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2024-09-04 04:50:17 +02:00
Sachin Bahukhandi
b06651f968
Fixed the issue appearing on updating twig
Signed-off-by: Sachin Bahukhandi <sachinb0013@gmail.com>
(cherry picked from commit da6847dd0d)
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-08-30 20:26:03 -03:00
Maurício Meneghini Fauth
a522a9982f
Improve tests for WebAuthn
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-08-28 20:20:01 -03:00