gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
126,994 Commits 12 Branches 481 Tags 2.4 GiB
bed6a58c6c
Commit Graph

288 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
c57dda7315 Use DI for Sql class constructor 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-09-05 15:31:39 -03:00
Maurício Meneghini Fauth
ceac762e09 Remove pmaThemePath and pmaThemeImage PHP globals 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-09-02 10:57:57 -03:00
Maurício Meneghini Fauth
7936909dbd Move Operations::getMaintenanceActions to the view 
Uses Table\MaintenanceController to handle the maintenance actions in
the table operations page.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-08-28 15:25:14 -03:00
Maurício Meneghini Fauth
46f28b42c9 Extract the Table\MaintenanceController class 
Extracts the table maintenance action methods from
the Database\StructureController class to the
new Table\MaintenanceController class and adjust templates
and routes names.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-08-27 23:33:43 -03:00
Maurício Meneghini Fauth
620cb0a705 Create a dedicated page for Repair Table 
Instead of only showing the query results.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-08-27 22:38:24 -03:00
Maurício Meneghini Fauth
98a1943b35 Create a dedicated page for Optimize Table 
Instead of only showing the query results.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-08-27 22:26:19 -03:00
Maurício Meneghini Fauth
c1ad98f83d Create a dedicated page for Checksum Table 
Instead of only showings the query results.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-08-27 21:59:48 -03:00
Maurício Meneghini Fauth
5c06dede81 Create a dedicated page for Analyze Table 
Instead of only showing the query results.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-08-27 21:12:12 -03:00
Maurício Meneghini Fauth
c112bfd6d6 Create a new page for Check Table 
Instead of only showing the query results.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-08-27 14:22:22 -03:00
Maurício Meneghini Fauth
55c5c80d37 Rename Display\ImportAjax class 
Renames to Import\Ajax.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-08-20 12:07:54 -03:00
Maurício Meneghini Fauth
fa67657b1a Remove Display\Import class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-08-20 00:21:26 -03:00
Maurício Meneghini Fauth
28436399dd Extract exit from Display\Import class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-08-19 02:28:02 -03:00
Maurício Meneghini Fauth
65b79af29e Refactor Plugins::getPlugins method 
Replaces parameters with explicit methods.
 - Plugins::getExport
 - Plugins::getImport
 - Plugins::getSchema

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-08-19 01:40:27 -03:00
Maurício Meneghini Fauth
6cf316bde8 Use DI for Export\Options class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-08-04 15:43:06 -03:00
Maurício Meneghini Fauth
75397c913d Refactor Display\Export class 
- Uses template inheritance for the export templates.
- Renames Display\Export to Export\Options.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-08-03 23:56:20 -03:00
Maurício Meneghini Fauth
879ae32edc Extract HTML from server, db and table export controllers 
- Controllers\Server\ExportController::index
- Controllers\Database\ExportController::index
- Controllers\Table\ExportController::index

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-08-01 14:08:51 -03:00
Maurício Meneghini Fauth
d0716e9d31 Remove Display\CreateTable::getHtml 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-29 21:49:55 -03:00
Maurício Meneghini Fauth
3f01cd8c13 Remove Message::display method 
Related to https://github.com/phpmyadmin/phpmyadmin/issues/16258.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-20 19:43:46 -03:00
Maurício Meneghini Fauth
1dccc10493 Extract method for adding script files 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-12 16:58:33 -03:00
Maurício Meneghini Fauth
f8320956ee Remove Config\PageSettings::showGroup method 
Related to https://github.com/phpmyadmin/phpmyadmin/issues/16258.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-12 16:01:18 -03:00
Maurício Meneghini Fauth
918b1f38c6 Change return type of Sql::executeQueryAndSendQueryResponse 
Remove Response::addHTML call.

Related to https://github.com/phpmyadmin/phpmyadmin/issues/16258.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-12 15:22:57 -03:00
Maurício Meneghini Fauth
3b285ff17e Use identical operator for non-empty strings 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-10 18:06:29 -03:00
Maurício Meneghini Fauth
a22f7b1b7a Fix some PHPStan errors 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-04 00:00:59 -03:00
Maurício Meneghini Fauth
05c62ad1a8 Fix some PHPStan errors 
Fixes "Cannot access offset on array" errors.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-02 16:12:07 -03:00
Maurício Meneghini Fauth
2a981907d6 Extract copy action from db structure index method 
Fixes #16173.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-06-24 21:10:11 -03:00
Maurício Meneghini Fauth
a05557a273 Extract copy with prefix from db structure index method 
Related to #16173.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-06-24 20:55:22 -03:00
Maurício Meneghini Fauth
427bd8dfdf Extract replace prefix from db structure index method 
Related to #16173.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-06-21 18:54:14 -03:00
Maurício Meneghini Fauth
b91e9784ba Extract add prefix from db structure index method 
Related to #16173.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-06-21 02:34:55 -03:00
Maurício Meneghini Fauth
7ce0ae202d Fix missing message after dropping tables 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-06-21 01:54:48 -03:00
Maurício Meneghini Fauth
7cca45723e Extract empty action from db structure index method 
Related to #16173.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-06-21 01:40:24 -03:00
Maurício Meneghini Fauth
c9c17a2946 Extract drop action from db structure index method 
Related to #16173.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-06-21 00:08:25 -03:00
Maurício Meneghini Fauth
be5e055b9e Extract repair action from db structure index method 
Related to #16173.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-06-20 19:35:51 -03:00
Maurício Meneghini Fauth
d1e10a9158 Extract optimize action from db structure index method 
Related to #16173.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-06-20 15:09:10 -03:00
Maurício Meneghini Fauth
ec0c941dc8 Extract checksum action from db structure index method 
Related to #16173;

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-06-20 01:49:37 -03:00
Maurício Meneghini Fauth
4ee25bee29 Extract analyze action from db structure index method 
Related to #16173.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-06-17 20:36:43 -03:00
Maurício Meneghini Fauth
f3e5a30102 Extract check action from db structure index method 
Related to #16173.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-06-17 17:47:02 -03:00
Maurício Meneghini Fauth
b64e41fb8f Use early exit for db structure multiSubmitAction method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-06-17 14:54:47 -03:00
Maurício Meneghini Fauth
9b0173c207 Extract empty form action from db structure index method 
Related to #16173 and #15248.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-06-17 14:35:07 -03:00
Maurício Meneghini Fauth
0befcf6432 Extract drop action from db structure index method 
Related to #16173.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-06-16 19:46:19 -03:00
Maurício Meneghini Fauth
63a41eba87 Extract change prefix form from db structure index method 
Related to #16173.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-06-16 15:14:22 -03:00
Maurício Meneghini Fauth
11df26d9ab Extract add prefix form from db structure index method 
Related to #16173.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-06-13 23:28:04 -03:00
Maurício Meneghini Fauth
982914922b Extract make consistent action from db structure index 
Related to #16173.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-06-13 17:58:50 -03:00
Maurício Meneghini Fauth
e7a35f8e50 Extract central col remove from db structure index method 
Related to #16173.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-06-13 14:22:48 -03:00
Maurício Meneghini Fauth
0ec86b7b0f Extract central col add action from db structure index method 
Related to #16173.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-06-12 15:56:07 -03:00
Maurício Meneghini Fauth
058729db08 Extract copy form action from db structure index method 
Related to #16173 and #15248.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-06-12 14:39:29 -03:00
Maurício Meneghini Fauth
31e484ac75 Extract showCreate logic from templates 
Create the Database\StructureController::getShowCreateTables method.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-06-12 01:09:08 -03:00
Maurício Meneghini Fauth
d7bc1d9e4f Extract show-create action from db structure index method 
Related to #16173

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-06-11 23:35:27 -03:00
Maurício Meneghini Fauth
4e8484229a Extract export action from db structure index method 
Related to #16173

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-06-11 21:48:36 -03:00
William Desportes
761045bcc9
Move getSystemSchemas and isSystemSchema to Query\Utilities 
If you think the class name could be better, feel free to improve it.
Everybody know naming classes is difficult ^^
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-31 01:42:53 +02:00
Maurício Meneghini Fauth
58eee2e371 Use early exit when possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-27 21:46:12 -03:00
Maurício Meneghini Fauth
f4582e083e Use early exit when possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
bd979dd1ff Remove useless elseif with if 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-26 22:53:44 -03:00
Maurício Meneghini Fauth
94955f187a Fix function call signatures indentation 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-26 04:22:02 -03:00
Maurício Meneghini Fauth
3ae05c785d Use short list syntax and single line arrays 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-26 03:32:59 -03:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-25 22:42:37 -03:00
William Desportes
0138cb471f
Some minor code improvements 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-17 22:29:57 +02:00
Maurício Meneghini Fauth
80a45fa0ae Break too long lines 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-16 18:08:20 -03:00
William Desportes
9bc55b2bc9
Remove some unused variable assignements 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-15 22:44:50 +02:00
Maurício Meneghini Fauth
a64393e7f5 Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-13 00:23:28 -03:00
William Desportes
7db0debd05
Fix some failing tests 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-02 01:51:51 +02:00
Maurício Meneghini Fauth
4a0bce1d53 Extract db structure bulk actions from mult_submits 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-04-22 23:13:35 -03:00
William Desportes
8e9553e8d7
Merge #16082 - Fix #15995 - database export 
Pull-request: #16082
Fixes: #15995

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-04-18 00:40:18 +02:00
Maurício Meneghini Fauth
9b7c4931d3 Add AbstractController::render method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-04-16 20:15:42 -03:00
Maurício Meneghini Fauth
603c357d05 Refactor Database\EventsController::index method 
Moves Database\Events::main into index method.
Uses DI for Events instance.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-04-16 19:38:50 -03:00
Hugues Peccatte
b0460d3aa3 Fix #15995 database export 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2020-04-15 20:56:40 +02:00
Maurício Meneghini Fauth
1102bdfdb7 Move Rte classes to the Database namespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-04-13 18:26:47 -03:00
Maurício Meneghini Fauth
92bc73483e Remove the $_PMA_RTE global variable 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-04-13 17:23:51 -03:00
Maurício Meneghini Fauth
c1ca032da7 Use DI for RTE classes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-04-11 16:09:35 -03:00
Maurício Meneghini Fauth
8732435e64 Extract HTML from indexes table of data dict page 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-03-29 20:03:28 -03:00
Maurício Meneghini Fauth
f705e32a47 Replace fieldset with cards for db operations page 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-03-21 00:38:50 -03:00
Maurício Meneghini Fauth
a989348986 Extract HTML from QueryByExampleController::index 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-02-15 01:16:58 -03:00
William Desportes
01cd7dc33b
Some code improvements suggested by Scrutinizer 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-02-14 22:23:16 +01:00
Maurício Meneghini Fauth
d85cca09b2 Remove database and table from route names 
Database and table names may contain the slash char (/) which is the
route separator char.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-02-12 17:26:02 -03:00
Maurício Meneghini Fauth
64723d90da Rename the multi-table query route 
Renames the route name from /database/multi_table_query to
/database/multi-table-query.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-02-12 17:04:59 -03:00
Maurício Meneghini Fauth
8029ea9875 Move request handling from routes to controllers 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-02-12 15:00:02 -03:00
Maurício Meneghini Fauth
f5c970639c Move response handling from routes to controllers 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-02-12 14:59:42 -03:00
William Desportes
a7a7b73b55
Support return back from raw export 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-01-27 21:16:37 +01:00
Saurabh Srivastava
1b56c8e0ed
Fix 15064 - instead of using free_query parameter, now updating export_type to raw -- more modular approach 
Signed-off-by: Saurabh Srivastava <saurabhsrivastava312@gmail.com>
 2020-01-27 21:16:31 +01:00
Maurício Meneghini Fauth
aa0f8a6efe Extract HTML from the database operations page 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-23 22:56:29 -03:00
Maurício Meneghini Fauth
206199105e Remove useless return type annotations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
6584b01824 Use short versions of scalar types in PHP docs 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-23 12:20:04 -03:00
Maurício Meneghini Fauth
6b7af13f8f Reference global funcs and consts via use statement 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-23 00:33:24 -03:00
Maurício Meneghini Fauth
676f48349a Reference global funcs and consts via use statement 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations 
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf Use one line for comments with a single line 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
c231652c67 Remove useless comments in PHP docs 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 14:38:49 -03:00
Maurício Meneghini Fauth
50bc4ab37f Remove useless PHP docs for functions 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 13:20:01 -03:00
Maurício Meneghini Fauth
8ec4209002 Fix some coding standard issues 
- Inverts yoda comparisons
- Removes parentheses from return
- Removes useless ternary operators
- Adds paretheses to new instances
- Adds trailing array comma

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 00:38:34 -03:00
William Desportes
1af14d25f8
Fix coding standard issue issue introduced by #15432 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-01-15 19:51:26 +01:00
Maurício Meneghini Fauth
c5481acebf Merge branch 'QA_5_0' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-14 18:54:02 -03:00
William Desportes
0ae945f1f5
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-01-11 16:29:24 +01:00
Maurício Meneghini Fauth
d0f28cef30 Refactor table pages common code 
Extracts tbl_common.inc.php code to the Common::table() method and
removes the include file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-07 22:49:24 -03:00
Maurício Meneghini Fauth
385e7f86c0 Refactor database pages common code 
Extracts db_common.inc.php code to the Common::database() method and
removes the include file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-07 22:49:24 -03:00
Maurício Meneghini Fauth
08afb43653 Remove replication.inc.php file 
Extracts the replication.inc.php code to the ReplicationInfo class and
removes the file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-07 14:31:46 -03:00
Maurício Meneghini Fauth
aaab14284f Remove requires from the routes file 
Call the the controller directly instead of requiring the entry point
file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-06 11:02:41 -03:00
Maurício Meneghini Fauth
09daab7ba9 Refactor Database\SqlController controller 
Moves the database sql entry point logic to the controller.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-03 15:07:27 -03:00
Maurício Meneghini Fauth
e9216ad486 Create Database\ExportController controller 
Extracts the database export entry point logic to the controller.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-03 11:23:31 -03:00
William Desportes
666e06904d
Merge branch 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-12-30 17:38:28 +01:00
William Desportes
8033c15fe6
Fix #15722 - Get Database structure fails with PHP error on replicated server 
Fixes: #15722
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-12-30 17:37:49 +01:00
Maurício Meneghini Fauth
5debd00bd0 Create Database\ImportController class 
Moves the database import entry point logic to the controller and
removes the entry point file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-29 20:22:21 -03:00
Maurício Meneghini Fauth
693bf67b1c Refactor Database\CentralColumnsController class 
Moves the central columns entry point logic to the controller and
removes the entry point file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-26 12:51:35 -03:00
Maurício Meneghini Fauth
7112434f51 Create Database\TrackingController controller 
Moves the database tracking entry point logic to the
Database\TrackingController and removes the entry point file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-21 18:07:27 -03:00
Maurício Meneghini Fauth
8083de3a01 Create Database\SqlFormatController class 
Moves sql format entry point logic to the SqlFormatController controller
and removes the entry point file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-21 17:33:37 -03:00
Maurício Meneghini Fauth
39f42f848b Remove some useless docblock comments 
Fixes docblock spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-13 21:15:00 -03:00
Maurício Meneghini Fauth
77518d341e Remove unused use statements 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-11 21:20:58 -03:00
Maurício Meneghini Fauth
f6a17433a2 Use null coalesce operator when possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-11 20:16:58 -03:00
Maurício Meneghini Fauth
301835e9a6 Create SqlAutoCompleteController 
Moves database sql autocomplete entry point logic to the
Database\SqlAutoCompleteController and removes the entry point file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-11 18:22:52 -03:00
Maurício Meneghini Fauth
fa6fc404fe Create Table\TriggersController 
Moves database|table triggers entry point logic to
Database|Table\TriggersController and removes the entry point file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-11 17:53:18 -03:00
Maurício Meneghini Fauth
8a800070bd Moves db routines entry point logic to the controller 
Removes the database routines entry point file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-11 11:38:32 -03:00
Maurício Meneghini Fauth
958ba8822d Create Database\OperationsController 
Moves database operations entry point logic to the
Database\OperationsController controller and removes the entry point
file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-09 18:12:00 -03:00
Maurício Meneghini Fauth
2f3f768357 Refactor Controller\Database\EventsController 
Moves database events entry point logic to the Database\EventsController
controller and remove the entry point file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-08 16:57:07 -03:00
Maurício Meneghini Fauth
351e34ecf5 Upgrade PHPStan to version 0.12.0 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-07 20:26:39 -03:00
Maurício Meneghini Fauth
dd06cd38f8 Defines rules for double quote usage 
Makes sure that any use of double quotes strings are warranted.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-01 14:10:07 -03:00
Maurício Meneghini Fauth
a0a44fd01e Move db search entry point logic to a new controller 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-11-30 18:49:57 -03:00
Maurício Meneghini Fauth
fcde861b97 Move db qbe entry point logic to a new controller 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-11-28 20:43:56 -03:00
Maurício Meneghini Fauth
b3b3d5efd2 Move db designer entry point logic to a controller 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-11-26 20:57:50 -03:00
Hugues Peccatte
3255e4ad7b Split Util class regarding the responsabilities (#15567) 
PhpMyAdmin\Util is a very huge class with a lot of responsabilities.

There is a lot of work to split it, but this may be just a small start, waiting for a more normalized code.

* Split Util class regarding the responsabilities
* Split the buttonOrImage function

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-11-21 20:20:05 -03:00
Maurício Meneghini Fauth
acd62791b8 Move database structure entry point to routes file 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-11-03 21:01:00 -03:00
Maurício Meneghini Fauth
5227fbf26b Move database multi table query entry point to routes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-11-02 21:54:09 -03:00
Oleg Abrazhaev
43e1d4cade use twig in Structure and Variables controller and add missing tests #14801 (#15534) 
* use twig in Structure and Variables controller and add missing tests #14801

Signed-off-by: Oleg Abrazhaev <seyferseed@gmail.com>

* fix lint

Signed-off-by: Oleg Abrazhaev <seyferseed@gmail.com>

* Update templates/database/structure/overhead.twig

fix code review

Co-Authored-By: Maurício Meneghini Fauth <mauricio@fauth.dev>

* Update libraries/classes/Controllers/Database/StructureController.php

fix code review

Co-Authored-By: Maurício Meneghini Fauth <mauricio@fauth.dev>

* fix code review

Signed-off-by: Oleg Abrazhaev <seyferseed@gmail.com>
 2019-10-29 22:48:29 -03:00
Maurício Meneghini Fauth
998d833c0c Move database data dictionary to routes file 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-10-27 19:53:21 -03:00
Maurício Meneghini Fauth
672aee2d8a Create Database\PrivilegesController 
Extracts Server\Privileges::getHtmlForSpecificDbPrivileges method to a
controller.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-09-29 21:09:24 -03:00
Maurício Meneghini Fauth
1a14b3e4d3 Remove vim modelines 
These settings are no longer required as they are guaranteed through
other coding standard tools.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-09-02 09:43:21 -03:00
Maurício Meneghini Fauth
208b0e25e1 Use the router for the sql pages 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-08-03 21:25:27 -03:00
Maurício Meneghini Fauth
efe576cdc0 Fix double encoding in database struture page 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-07-22 23:24:52 -03:00
Maurício Meneghini Fauth
aec0402679 Use the router for table structure page 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-07-19 20:18:06 -03:00
Maurício Meneghini Fauth
682e7a160e Use the router for database structure page 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-07-18 14:33:43 -03:00
Maurício Meneghini Fauth
064e5eef0a Use Collation value object when possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-28 23:01:30 -03:00
Maurício Meneghini Fauth
e1f9ae00cd Add a trailing comma in multi-line arrays 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-14 14:09:26 -03:00
Maurício Meneghini Fauth
0feae32056 Rename Sanitize::sanitize to Sanitize::sanitizeMessage 
...to avoid the PHP 4 constructor format

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-12 15:21:48 -03:00
Maurício Meneghini Fauth
7be0f6bfae Reference class names in use statements 
Sort use statements

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-12 00:14:26 -03:00
William Desportes
96fc4d45af
Merge branch 'QA_4_8' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-06-03 21:29:07 +02:00
Hugues Peccatte
9abd308837 Inject dependencies (#15271) 
Inject dependencies instead of building them.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-06-01 15:13:41 -03:00
Eugene Kazakov
9edcc5e43a Bug #10846 TypeError: Cannot read property 'substring' of undefined 
Signed-off-by: Eugene Kazakov <ekazakov@plesk.com>
 2019-05-31 18:21:30 +02:00
Maurício Meneghini Fauth
dfd49d16b8 Fix ESLint warnings in js/functions.js 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-05-30 17:30:16 -03:00
Hugues Peccatte
380707fbcd Define controllers as services in an external configuration file 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-05-19 01:54:44 +02:00
Hugues Peccatte
3243a9158d Remove use of unexisting variables 
Remove useless variables

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-05-11 00:34:57 +02:00
Nitish Bahl
2b0a36eb21 Fix #14926 - Filling existing fields form while editing a view 
Fix: #14926
See: #14916
Signed-off-by: Nitish Bahl <nitishbahl24@gmail.com>
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-03-25 22:31:29 +01:00
Maurício Meneghini Fauth
4d9da96469 Create server, database and table SqlControllers 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-03-23 22:41:29 -03:00
Maurício Meneghini Fauth
f1f109ac26 Create Database\MultiTableQueryController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-03-22 12:22:27 -03:00
Maurício Meneghini Fauth
a9115725b2 Create database RTE controllers 
- Create PhpMyAdmin\Controllers\Database\RoutinesController
- Create PhpMyAdmin\Controllers\Database\TriggersController
- Create PhpMyAdmin\Controllers\Database\EventsController
- Remove libraries/rte/rte_main.inc.php

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-03-22 02:35:45 -03:00
Maurício Meneghini Fauth
c9371d3a91 Rename Controller to AbstractController 
Rename PhpMyAdmin\Controllers\Controller to
PhpMyAdmin\Controllers\AbstractController.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-03-11 15:57:14 -03:00
Maurício Meneghini Fauth
0305c0a2c2 Rename Database\Controller to Database\AbstractController 
Rename PhpMyAdmin\Controllers\Database\Controller to PhpMyAdmin\Controllers\Database\AbstractController

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-03-11 15:04:28 -03:00
Maurício Meneghini Fauth
50ec2c0e2b Create Controllers\Database\CentralColumnsController 
Moves db_central_columns.php logic to the controller

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-03-05 02:12:12 -03:00
Maurício Meneghini Fauth
e700760685 Refactor Controllers\Database\StructureController 
Move request and response handling to db_structure.php

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-03-03 23:20:48 -03:00
Maurício Meneghini Fauth
35fafd773a Create Controllers\Database\DataDictionaryController 
- Extracts db_datadict.php logic to the controller
- Extracts HTML to database/data_dictionary/index template

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-03-01 23:06:13 -03:00
Maurício Meneghini Fauth
4c93203904 Rename DatabaseController and TableController 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-02-27 22:52:36 -03:00
Maurício Meneghini Fauth
067a6bfa0b Rename DatabaseStructureController to StructureController 
Renames PhpMyAdmin\Controllers\Database\DatabaseStructureController to
PhpMyAdmin\Controllers\Database\StructureController.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-02-13 21:58:47 -02:00
Hugues Peccatte
f06883d2a7 Remove useless parenthesis 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-01-20 01:23:53 +01:00
Maurício Meneghini Fauth
76fbe019da
Merge pull request #14856 from Tithugues/fix/escape-also-delimiter 
Escape also delimiter
 2019-01-16 02:19:24 -03:00