Commit Graph

436 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
e6f08a8682 Ignore ISO-2022-CN-EXT charset for iconv
Fixes possible glibc/iconv vulnerability (CVE-2024-2961).

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-01-20 14:14:17 -05:00
Maurício Meneghini Fauth
cf886df108 Ignore system databases when deleting using UI
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-01-20 13:08:55 -05:00
William Desportes
efe22817d0
Update the phpstan baseline
Signed-off-by: William Desportes <williamdes@wdes.fr>
2025-01-16 01:40:48 +01:00
Maurício Meneghini Fauth
8b38f49efa
Merge pull request #19520 from kamil-tekiela/Avoid-passing-null-to-synchronizeFavoriteTables
Avoid passing null to synchronizeFavoriteTables
2025-01-14 16:17:51 -03:00
Kamil Tekiela
5e1356f85f Avoid passing null to synchronizeFavoriteTables
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-14 17:22:39 +00:00
Maurício Meneghini Fauth
5ac0d3c6a4
Replace $GLOBALS['l'] with TCPDF::setLanguageArray()
The l global variable was not being used by TCPDF.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-01-11 17:57:45 -03:00
Maurício Meneghini Fauth
348b3fc380
Update PHPStan and Psalm baselines
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-12-25 17:50:21 -03:00
William Desportes
18f8ae0da1
Ref #19455 - Move all the code for revision-info.php to the Git class
Pull-request: #19458
Ref: #19455

And add one more new line

Signed-off-by: William Desportes <williamdes@wdes.fr>
2024-12-19 02:08:35 +01:00
William Desportes
a6642254f8
Update the phpstan and psalm baselines
Signed-off-by: William Desportes <williamdes@wdes.fr>
2024-12-19 01:18:31 +01:00
Maurício Meneghini Fauth
6f876508a6
Ignore config files for PHPStan
Related to
https://github.com/phpmyadmin/phpmyadmin/pull/19416#issuecomment-2511733161

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-12-03 16:15:27 -03:00
Maurício Meneghini Fauth
54278b5920 Add PHPStan stricter rules
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-12-02 11:16:30 -03:00
Maurício Meneghini Fauth
9ca232c45e
Update PHPStan and Psalm baselines
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-11-10 01:56:49 -03:00
Maurício Meneghini Fauth
0bf7c0fa18
Suppress deprecation message of E_STRICT constant
The E_STRICT constant was deprecated in PHP 8.4.

It's still a possible error level when using PHP 7.2 and PHP 7.3.

See:
https://wiki.php.net/rfc/deprecations_php_8_4#remove_e_strict_error_level_and_deprecate_e_strict_constant

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-10-15 17:18:30 -03:00
Maurício Meneghini Fauth
555ea56cbd
Make PHPUnit's assertions stricter
Backports #18993 to QA_5_2.

This makes merging QA_5_2 into master easier.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-10-12 15:33:45 -03:00
Maurício Meneghini Fauth
7fc96d6621
Call PHPUnit static methods using static calls
Backports #18907 to QA_5_2.

This makes merging QA_5_2 into master easier.
Changes done using Rector.

- #18907

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-10-12 14:28:22 -03:00
Maurício Meneghini Fauth
52f5880c24
Update SA baselines
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-10-11 15:32:36 -03:00
Maurício Meneghini Fauth
2fb2477af5
Add phpstan/phpstan-deprecation-rules package
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-09-30 17:14:50 -03:00
Maurício Meneghini Fauth
c96a06edaf
Update SA baselines
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-08-31 12:07:17 -03:00
Maurício Meneghini Fauth
af7c5dc083
Fix coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-08-27 14:44:06 -03:00
Maurício Meneghini Fauth
46f2c8871c
Backport some fixes for PHPUnit 10 compatibility
- Fixes https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1070623

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-08-13 20:13:18 -03:00
Maurício Meneghini Fauth
4f67631d48
Fix undefined variables in table/zoom_search/result_form.twig
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-06-22 17:34:21 -03:00
Maurício Meneghini Fauth
ece6f4da0b
Fix routes cache validation
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-06-03 20:04:59 -03:00
Maximilian Krög
901ea2646b
Fix column sorting with limit subquery
The used regex found the subquery limit and added the order
clause before that. Better to use Query::replaceClause here.

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2024-05-23 23:59:43 +02:00
Maurício Meneghini Fauth
ca2d519f07
Merge pull request #19145 from MoonE/duplicate-url-params
Remove duplicate server and lang param from links
2024-05-23 18:50:55 -03:00
Maurício Meneghini Fauth
1a781a0898
Update PHPStan baseline
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-23 18:44:22 -03:00
Maximilian Krög
626aa23841
Remove duplicate server and lang param from links
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2024-05-03 02:54:06 +02:00
Maximilian Krög
d5e0d711bd
Fix linter annotations for special editors
When the sql string to lint isa changed, the result positions
need to be adjusted accordingly.

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2024-04-22 21:42:36 +02:00
Maurício Meneghini Fauth
de45958d54
Allow installation of Twig >= 3.9
- Fixes #19112

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-04-19 14:25:24 -03:00
Maurício Meneghini Fauth
1d8367368e
Remove allowDeny_forbidden global
Fixes issue introduced by 2327dbf3c3.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-03-26 16:08:42 -03:00
Luca Camillo
78335aac87
Add role based auth for MySQL 8.x and compatibles (#18814)
* add role based auth for mysql 8.x or compatible like mariadb/aws rds aurora mysql

Signed-off-by: Luca Camillo <luca.camillo@gmail.com>

* Using cache and check server version

Signed-off-by: Luca Camillo <luca.camillo@gmail.com>

* implement tests for getCurrentRolesAndHost / getCurrentRoles functions

Signed-off-by: Luca Camillo <luca.camillo@gmail.com>

* fix role checks on mariadb

Signed-off-by: Luca Camillo <luca.camillo@gmail.com>

* Simplify code + ignore NONE as result of CURRENT_ROLE()

Signed-off-by: Luca Camillo <luca.camillo@gmail.com>

* Fix tests

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Fixes #18782

---------

Signed-off-by: Luca Camillo <luca.camillo@gmail.com>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-03-02 19:31:03 -03:00
Maurício Meneghini Fauth
2b1f21ef07
Remove unused parameter from Table\StructureController::displayStructure
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-02-21 21:05:48 -03:00
Kamil Tekiela
3bde23aceb Fix bug with numeric table names
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-01-23 13:44:35 +01:00
William Desportes
a58479fa88
Update the phpstan baseline 2024-01-13 15:19:52 +01:00
Maurício Meneghini Fauth
b333efce8b
Specify text enconding when detecting PNG media types
UTF-8 can't be used for that.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-12-20 10:14:41 -03:00
Maurício Meneghini Fauth
6503321278
Fix case where column hash is empty in table relation page
- Fixes #18834
- Related to #14305

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-12-08 16:57:12 -03:00
Kamil Tekiela
7e4768c508 Update baselines
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-11-29 15:22:22 +01:00
Maurício Meneghini Fauth
4035903f69
Refactor Url::getArgSeparator to use ampersand when available
- Fixes #16826
- Closes #18540
- Related to #14969

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-11-22 13:01:55 -03:00
Maurício Meneghini Fauth
99168688a7
Add ChangeLog entry for #15670
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-11-17 13:15:38 -03:00
Maurício Meneghini Fauth
dcaf778ef8
Update PHPStan baseline
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-10-17 13:11:03 -03:00
Maurício Meneghini Fauth
3b750c73b4
Merge pull request #18702 from MoonE/qa-user-accounts
QA Fix user accout navigation by initials
2023-09-28 21:49:23 -03:00
Kamil Tekiela
dba0086b90 Fix AJAX real-row-count
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-09-15 21:01:15 +01:00
Maurício Meneghini Fauth
6e695df23d
Update PHPStan and Psalm baselines
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-09-15 16:20:41 -03:00
Maximilian Krög
bf17145c70
Fix filtering by initials for user accounts starting with %, \, or _
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2023-09-09 17:44:17 +02:00
Kamil Tekiela
d0e746fac6 Fix dropped triggers on rename
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-08-28 23:34:21 +01:00
Maximilian Krög
60a8a26026
update baselines
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2023-08-26 21:35:44 +02:00
Maximilian Krög
836c5bd7ea
Fix some type declarations
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2023-08-26 21:35:39 +02:00
Maurício Meneghini Fauth
fb2c4bf1df
Add ChangeLog entry for #18650
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-08-25 12:11:20 -03:00
William Desportes
1f94b4a0bd
Update baselines after #18578
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-08-03 18:13:26 +02:00
Kamil Tekiela
fb2953c487 Force string as return type of showCreate()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-07-24 19:45:24 +01:00
Maurício Meneghini Fauth
a9bbce6b99
Add ChangeLog entry for #17528
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-07-05 10:03:06 -03:00