Commit Graph

438 Commits

Author SHA1 Message Date
William Desportes
b6b9926a08
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-01 16:27:24 +02:00
Nupur Agrawal
4902d080e7
Fix #12729 - Sticky table header over dropdown menu
Fixes: #12729
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
2019-04-01 16:18:04 +02:00
William Desportes
c793b998a7
ESLINT fixes
Make eslint green for CI
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-30 08:30:48 +01:00
William Desportes
c112ba4da8
Merge branch 'QA_4_8'
Closes: https://github.com/phpmyadmin/phpmyadmin/pull/14876
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-02 12:07:40 +01:00
nmilo
68d81fa210 Fix: #14503 - JavaScript events not activating on input
Fixes: #14503
Signed-off-by: nmilo <nemanjamilosevic29@yahoo.com>
2019-03-02 11:47:34 +01:00
Hugues Peccatte
e175464301 Syntax error in JQuery selector
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-12 01:36:48 +01:00
Maurício Meneghini Fauth
9eba565bf4 Remove unnecessary HTML closing tags
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-19 00:12:54 -02:00
Maurício Meneghini Fauth
76d8bfdafa Merge branch 'QA_4_8'
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-12 21:04:19 -02:00
Lakshay arora
2b065133a2 Adds features discussed in #13023
1. Show ajax errors at the bottom of the page, instead of showing them in a popup.
2. Add copy query button for errors in processing sql queries.

Signed-off-by: Lakshay arora <arora.lakshya123@gmail.com>
2018-11-14 23:20:12 -02:00
Maurício Meneghini Fauth
e7e7d56c75 Retrieve parameters from $_POST in browse foreigners
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-10 20:48:59 -02:00
Bob Terrell
0861e05531 Fix several issues with table headers in Safari
The width += 1 does not apply to Safari, either.

Safari requires min-width and max-width to be set. “width” is not honored.

Add a line break to template so comments stay on separate line.

Moved browser checks to higher scope; the user agent only needs to be checked once, not once per cell.

Signed-off-by: Bob Terrell <bob.terrell@acordex.com>
2018-08-23 14:59:57 -04:00
Lakshay arora
f05bce1e94 Some minor bug fixes
Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>
2018-07-12 12:53:13 +05:30
Piyush Vijay
bf0198938c Remember table's sorting broken in 4.8.0 issue: #14189 fixed
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>

(cherry picked from commit e58dd74c40)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-12 04:53:08 -03:00
Maurício Meneghini Fauth
1f76f859fb
Merge pull request #14204 from Piyush3079/PMA_14189
Remember table's sorting broken in 4.8.0 issue: #14189 fixed
2018-05-12 04:51:29 -03:00
Maurício Meneghini Fauth
2936492555 Revert "Replace .focus() with .on()"
This reverts commit d18076eb96.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-12 02:40:33 -03:00
Maurício Meneghini Fauth
d18076eb96 Replace .focus() with .on()
.focus() event shorthand is deprecated

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-12 02:17:51 -03:00
Maurício Meneghini Fauth
3bf83954a0 Replace .keyup() with .on()
.keyup() event shorthand is deprecated

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-12 01:28:32 -03:00
Maurício Meneghini Fauth
8f8e3c26c9 Replace .click() with .on()
.click() event shorthand is deprecated

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-11 23:58:35 -03:00
Maurício Meneghini Fauth
f4fedc20ee Replace .change() with .on()
.change() event shorthand is deprecated

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-11 20:45:36 -03:00
Piyush Vijay
9c7c5ca951 Changes to make Get auto saved query and show this query here again button functional (#14166)
* Handling of autosaved query and making get auto-saved query button functional
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>

* Basic functionality of show this query here again added
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>

* Show this query here again checkbox working properly
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>

* deleting auto_saved_sql on clicking submit query button
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>

* javascript error handled
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>

* javascript error of JSON undefined removed
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-03 16:50:38 -03:00
Piyush Vijay
e58dd74c40
Remember table's sorting broken in 4.8.0 issue: #14189 fixed
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
2018-04-16 19:33:28 +05:30
Maurício Meneghini Fauth
bec8888e7c Revert "Merge pull request #14046 from shucon/login"
This reverts commit 5a1ceef67d, reversing
changes made to 063f380639.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-04-06 18:07:17 -03:00
Maurício Meneghini Fauth
7a6b3cbba8 Revert "Cannot read property sql_query of undefined: #14104 issue fix (#14105)"
This reverts commit ad86eab974.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-04-06 18:06:53 -03:00
Piyush Vijay
ad86eab974 Cannot read property sql_query of undefined: #14104 issue fix (#14105)
Fix #14101
Fix #14104

* Cannot read property sql_query of undefined: #14104 issue fix
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>

* Cannot read property sql_query of undefined: #14104 issue fix
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
2018-03-26 13:25:33 -03:00
Michal Čihař
5a1ceef67d
Merge pull request #14046 from shucon/login
Restore SQL query after session expire
2018-03-16 13:07:20 +01:00
Saksham Gupta
0eaf1b108c Add cookie restore and empty save error
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
2018-03-02 11:50:13 +05:30
Michal Čihař
f4026f60a4 Merge branch 'QA_4_7' 2018-03-01 16:02:57 +01:00
Michal Čihař
984c6a0054 Honor arg_separator in AJAX requests
Fixes #13940

Signed-off-by: Michal Čihař <michal@cihar.com>
2018-03-01 15:50:41 +01:00
Saksham Gupta
8537d0125a Fix whitespaces
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
2018-03-01 02:20:53 +05:30
Saksham Gupta
e5ff7f34fe Restore SQL query after session expire
Partially Fixes: https://github.com/phpmyadmin/phpmyadmin/issues/13654

Signed-off-by: Saksham Gupta <shucon01@gmail.com>
2018-03-01 02:17:28 +05:30
Michal Čihař
1f00c99be9 Share code for parsing data-post attribute
It can include leading question mark and we should deal with it in all
locations.

Fixes #13913

Signed-off-by: Michal Čihař <michal@cihar.com>
(cherry picked from commit 1fc566fd90)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-22 16:01:00 -03:00
Michal Čihař
be7d5ee738 Simplify handling of long URLs in Util::linkOrButton
We no longer create form, but rather rather tag the link to be handled
as POST on the client side.

This way the code is way simpler without need on any special case
handling on server side.

Fixes #13649

Signed-off-by: Michal Čihař <michal@cihar.com>
(cherry picked from commit 3b9fb2b664)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-22 13:02:58 -03:00
Michal Čihař
1fc566fd90 Share code for parsing data-post attribute
It can include leading question mark and we should deal with it in all
locations.

Fixes #13913

Signed-off-by: Michal Čihař <michal@cihar.com>
2018-01-08 17:35:32 +01:00
xypXiong
f65c3dc2ed fix #13727 copied table data add number of orders (#13823)
Signed-off-by: yanping <xyp.xiong@gmail.com>
2017-11-28 10:40:42 +01:00
Michal Čihař
3b9fb2b664 Simplify handling of long URLs in Util::linkOrButton
We no longer create form, but rather rather tag the link to be handled
as POST on the client side.

This way the code is way simpler without need on any special case
handling on server side.

Fixes #13649

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-16 15:33:53 +01:00
Maurício Meneghini Fauth
ef99fef8d6 Change ESLint's eqeqeq to error
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-25 21:30:14 -03:00
Maurício Meneghini Fauth
00e1ca9b66 Automatic fixes by ESLint
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-25 14:22:35 -03:00
Jakub Stanecki
5b1ed4c326 Added remember table sorting when browsing table
Signed-off-by: Jakub Stanecki <staneckijakub@gmail.com>
2017-09-11 21:37:29 +02:00
akritianand
4f6335bb59 Do not include messages when copying results
Unnecessary data should not come in clipboard copied table.

Fixes #13617 

Signed-off-by: Akriti Anand <anand.akriti@gmail.com>
2017-09-04 09:55:12 +02:00
Michal Čihař
5e9bb1b584 Merge branch 'QA_4_7' 2017-08-02 08:19:45 +02:00
Michal Čihař
ef891b2bba Simplify code for copying to clipboard
Honestly I don't understand the old code, but it breaks on fields with
applied transformations, while using simply text() works fine.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-08-02 08:18:37 +02:00
Michal Čihař
626c2b3a29 Remove not needed variable
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-08-02 08:14:12 +02:00
Michal Čihař
12f54fd0cf Fixed copy results to clipboard
Copy only results table, not all tables on the page.

Fixes #13550

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-08-02 08:12:41 +02:00
Michal Čihař
33dd51eaf7 Move SQL copy handler to sql.js
Issue #13550

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-08-02 08:11:32 +02:00
Michal Čihař
f7bb752573 Automatically add token to all AJAX requests
This way we don't have to do the same in every AJAX request, it can be
done just once in shared handler.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-06-13 11:45:40 +02:00
Michal Čihař
135e82cc69 Replace jquery.cookie.js with js.cookie.js
The latter one is suggested replacement for no longer maintained
jquery.cookie.js.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-06-13 10:19:09 +02:00
Gemorroj
6d2bf012d2 Simplify HTML: <input></input> -> <input />
Signed-off-by: Gemorroj <wapinet@gmail.com>
2017-04-28 16:09:20 +02:00
Dan Ungureanu
1ca19f0ac1 Replaced deprecated jQuery calls.
'bind' and 'unbind', 'delegate' and 'undelegate' have been deprecated in
favor of 'on' and 'off'.

Partially fixes #13166.

Signed-off-by: Dan Ungureanu <udan1107@gmail.com>
2017-04-10 13:06:32 +03:00
Michal Čihař
dbce3b54d1 Fix query simulating for more servers
The server parameter was missing.

Fixes #13047

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-03-03 14:48:11 +01:00
Michal Čihař
c77d8cff25 Do not use deprecated $.parseJSON
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-12-21 14:27:39 +01:00