Commit Graph

123 Commits

Author SHA1 Message Date
William Desportes
1e403f76d9
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-01 23:28:40 +02:00
William Desportes
ab748e2fac
Fix some potential php notices after merge of #15040
[ci skip]
See: 3d3d1a2b08
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-01 23:27:15 +02:00
William Desportes
76dca69460
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-01 22:29:25 +02:00
William Desportes
292d2db727
Merge branch 'QA_4_8' 2019-04-01 20:46:54 +02:00
apoorv
bca847f227 Fix #15010 - Sql preview show empty modal
Signed-off-by: apoorv <apoorvkhare007@gmail.com>
2019-03-26 23:48:58 +01:00
William Desportes
0988f9cf1b
Fix style issues
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-26 19:28:02 +01:00
William Desportes
79840be362
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-25 23:21:35 +01:00
Nitish Bahl
2b0a36eb21 Fix #14926 - Filling existing fields form while editing a view
Fix: #14926
See: #14916
Signed-off-by: Nitish Bahl <nitishbahl24@gmail.com>
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-25 22:31:29 +01:00
Maurício Meneghini Fauth
4d9da96469 Create server, database and table SqlControllers
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-03-23 22:41:29 -03:00
Maurício Meneghini Fauth
525a436162 Fix some PHPStan errors
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-03-19 16:48:54 -03:00
Maurício Meneghini Fauth
e575d4a739 Merge branch 'QA_4_8'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-03-19 14:38:16 -03:00
Maurício Meneghini Fauth
75eb905727 Fix wrong property name on TableStructureController
Introduced by 963ace6ada

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-03-19 14:31:10 -03:00
Maurício Meneghini Fauth
c9371d3a91 Rename Controller to AbstractController
Rename PhpMyAdmin\Controllers\Controller to
PhpMyAdmin\Controllers\AbstractController.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-03-11 15:57:14 -03:00
Maurício Meneghini Fauth
5ea75f4144 Rename Table\Controller to Table\AbstractController
Rename PhpMyAdmin\Controllers\Table\Controller to
PhpMyAdmin\Controllers\Table\AbstractController.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-03-11 15:15:31 -03:00
Maurício Meneghini Fauth
50ec2c0e2b Create Controllers\Database\CentralColumnsController
Moves db_central_columns.php logic to the controller

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-03-05 02:12:12 -03:00
Maurício Meneghini Fauth
4c93203904 Rename DatabaseController and TableController
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-27 22:52:36 -03:00
Maurício Meneghini Fauth
b97460a320 Rename TableStructureController to StructureController
Renames PhpMyAdmin\Controllers\Table\TableStructureController to
PhpMyAdmin\Controllers\Table\StructureController.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-14 16:30:49 -02:00
Maurício Meneghini Fauth
505af51a1c Rename TableSearchController to SearchController
Renames PhpMyAdmin\Controllers\Table\TableSearchController to
PhpMyAdmin\Controllers\Table\SearchController.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-14 16:08:18 -02:00
Maurício Meneghini Fauth
6c29e58ef7 Rename TableRelationController to RelationController
Renames PhpMyAdmin\Controllers\Table\TableRelationController to
PhpMyAdmin\Controllers\Table\RelationController.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-14 15:43:07 -02:00
Maurício Meneghini Fauth
a440e52541 Rename TableIndexesController to IndexesController
Renames PhpMyAdmin\Controllers\Table\TableIndexesController to
PhpMyAdmin\Controllers\Table\IndexesController.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-14 14:45:57 -02:00
Maurício Meneghini Fauth
cb8060ef4b Rename TableGisVisualizationController to GisVisualizationController
Renames PhpMyAdmin\Controllers\Table\TableGisVisualizationController to
PhpMyAdmin\Controllers\Table\GisVisualizationController.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-14 14:04:10 -02:00
Maurício Meneghini Fauth
d93a4e7e51 Rename TableChartController to ChartController
Renames PhpMyAdmin\Controllers\Table\TableChartController to
PhpMyAdmin\Controllers\Table\ChartController.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-14 13:51:42 -02:00
Maurício Meneghini Fauth
7eb2bbc102 Remove libraries/check_user_privileges.inc.php
Replaces with CheckUserPrivileges::getPrivileges

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-22 18:18:21 -02:00
Hugues Peccatte
f06883d2a7 Remove useless parenthesis
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-20 01:23:53 +01:00
Maurício Meneghini Fauth
fedad552cc
Merge pull request #14849 from Tithugues/feature/replace-regexp-when-simple
Replace regular expressions when simple
2019-01-16 02:14:51 -03:00
Hugues Peccatte
9406e922cc Update PHPDoc
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-13 09:52:46 +01:00
Hugues Peccatte
7685733389 Replace or improve use of 'for'
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-12 09:43:25 +01:00
Hugues Peccatte
746fd8b417 Replace regular expressions when simple
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-12 02:06:28 +01:00
Maurício Meneghini Fauth
23c3579804 Format array declarations
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-07 14:31:39 -02:00
Maurício Meneghini Fauth
4cee0cbc12 Adds space after not (!) and type cast
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-05 21:56:34 -02:00
Maurício Meneghini Fauth
999b4d14f0 Fix some coding standard errors
- Fixes array identation
- Removes empty statements

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-05 21:25:08 -02:00
Feliks Toomsoo
d6dde0180d Fix the table chart by not escaping null values
Signed-off-by: Feliks Toomsoo <feliks.toomsoo@gmail.com>
2018-12-26 20:10:02 +02:00
Maurício Meneghini Fauth
38e5b12c1c Define an absolute path to use for require statements
Fixes #6167

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-22 14:37:31 -02:00
Maurício Meneghini Fauth
9eba565bf4 Remove unnecessary HTML closing tags
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-19 00:12:54 -02:00
Maurício Meneghini Fauth
76d8bfdafa Merge branch 'QA_4_8'
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-12 21:04:19 -02:00
Tomas Votruba
637fe6de06 [cs] remove unused brackets, clean unused property assign
Signed-off-by: Tomas Votruba <tomas.vot@gmail.com>
2018-11-26 17:54:40 +01:00
William Desportes
cc2665121d
phpstan level 2 - fixes
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-11-25 13:57:57 +01:00
William Desportes
bcefdd79fa
phpstan level 2 - Fix phpdoc
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-11-25 13:57:55 +01:00
Tomas Votruba
bf720bad29 remove unused and fix @param, @var and @return annotation values
Signed-off-by: Tomas Votruba <tomas.vot@gmail.com>
2018-11-24 21:47:26 +01:00
Maurício Meneghini Fauth
d7affca556 Fix uncaught TypeError in Util::printableBitValue
Fixes #14718

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-12 21:50:42 -02:00
Maurício Meneghini Fauth
6fd9bfb75b Retrieve parameters from $_POST in table search
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-10 20:48:59 -02:00
Maurício Meneghini Fauth
d1d90b59b2 Retrieve parameters from $_POST in table relation
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-10 20:48:59 -02:00
Maurício Meneghini Fauth
d01ece698a Retrieve parameters from $_POST in tbl_indexes.php
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-10 20:48:59 -02:00
Maurício Meneghini Fauth
9219b28f47 Retrieve parameters from $_POST in table structure
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-10 20:48:58 -02:00
Alessandro Dolci
fd3dde47a6 Fixed condition on the emptiness of enum type criteriaValues array (#14648)
The if condition has a call to the empty function on the criteriaValues array, but in the considered case that array only contains a '0', so this makes it look empty to the function. I added a control on the first element of the array, to avoid this specific situation.
It's my first contribution, so I hope I did well with the branches. Let me know if there's something missing or to do, I'm happy to help.

Signed-off-by: Alessandro Dolci <alessandro.dolci@pm.me>
(cherry picked from commit 3f5fff3f4d)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-10-30 21:09:02 -03:00
Alessandro Dolci
3f5fff3f4d Fixed condition on the emptiness of enum type criteriaValues array (#14648)
The if condition has a call to the empty function on the criteriaValues array, but in the considered case that array only contains a '0', so this makes it look empty to the function. I added a control on the first element of the array, to avoid this specific situation.
It's my first contribution, so I hope I did well with the branches. Let me know if there's something missing or to do, I'm happy to help.

Signed-off-by: Alessandro Dolci <alessandro.dolci@pm.me>
2018-10-30 21:05:33 -03:00
Lakshay arora
2a07cee164 Automatically add index while editing an existing row and setting auto increment (#14417)
* Automates the addition of PRIMARY KEY index when user tries to edit an existing row and set AUTO INCREMENT.
* Disables the popup on insert new column page when user sets AUTO INCREMENT and automatically sets the index to PRIMARY KEY.

Signed-off-by: Lakshay arora <arora.lakshya123@gmail.com>
2018-10-23 16:33:36 -03:00
Maurício Meneghini Fauth
d4b4124a5e Remove $GLOBALS['dbi'] from Relation class
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-08-30 19:05:09 -03:00
Maurício Meneghini Fauth
5455897555 Fix unescaped string in table structure view
https://github.com/phpmyadmin/phpmyadmin/issues/14374#issuecomment-410017440

Introduced by commit 5d0fd81e67

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-08-28 02:41:27 -03:00
Maurício Meneghini Fauth
0913246f63
Merge pull request #14559 from CommanderRoot/patch-1
Fix displaying of indexes
2018-08-24 22:44:36 -03:00