Commit Graph

47 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
f9cb2ad2d0 Create PhpMyAdmin\InternalRelations
Extracts libraries/information_schema_relations.inc.php and
libraries/mysql_relations.inc.php relations to InternalRelations class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-03-24 17:23:42 -03:00
Maurício Meneghini Fauth
afebaad5f6 Fix bug when browsing foreign values
Introduced by #14741

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-03-08 15:20:40 -03:00
Hugues Peccatte
f06883d2a7 Remove useless parenthesis
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-20 01:23:53 +01:00
Maurício Meneghini Fauth
f9c168dbc1
Merge pull request #14850 from Tithugues/feature/group-str-replace
Group str_replace for performances
2019-01-16 02:55:53 -03:00
Maurício Meneghini Fauth
fedad552cc
Merge pull request #14849 from Tithugues/feature/replace-regexp-when-simple
Replace regular expressions when simple
2019-01-16 02:14:51 -03:00
Hugues Peccatte
9406e922cc Update PHPDoc
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-13 09:52:46 +01:00
Maurício Meneghini Fauth
9ed3d6eebf
Merge pull request #14851 from Tithugues/feature/replace-array-push-for-performances
Replace array_push for performances
2019-01-12 13:24:26 -03:00
Hugues Peccatte
d0797fff4d Group str_replace for performances
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-12 10:47:48 +01:00
Hugues Peccatte
ed132f1fe8 Replace array_push for performances
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-12 02:14:14 +01:00
Hugues Peccatte
746fd8b417 Replace regular expressions when simple
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-12 02:06:28 +01:00
Hugues Peccatte
5b19bb6845 Replace if+return by return
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-12 01:47:04 +01:00
Maurício Meneghini Fauth
23c3579804 Format array declarations
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-07 14:31:39 -02:00
Maurício Meneghini Fauth
4cee0cbc12 Adds space after not (!) and type cast
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-05 21:56:34 -02:00
Maurício Meneghini Fauth
999b4d14f0 Fix some coding standard errors
- Fixes array identation
- Removes empty statements

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-05 21:25:08 -02:00
Maurício Meneghini Fauth
38e5b12c1c Define an absolute path to use for require statements
Fixes #6167

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-22 14:37:31 -02:00
Maurício Meneghini Fauth
9eba565bf4 Remove unnecessary HTML closing tags
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-19 00:12:54 -02:00
Maurício Meneghini Fauth
76d8bfdafa Merge branch 'QA_4_8'
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-12 21:04:19 -02:00
Tomas Votruba
637fe6de06 [cs] remove unused brackets, clean unused property assign
Signed-off-by: Tomas Votruba <tomas.vot@gmail.com>
2018-11-26 17:54:40 +01:00
Tomas Votruba
bf720bad29 remove unused and fix @param, @var and @return annotation values
Signed-off-by: Tomas Votruba <tomas.vot@gmail.com>
2018-11-24 21:47:26 +01:00
Maurício Meneghini Fauth
593b2571cd Retrieve parameters from $_POST in chk_rel
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-10 20:48:59 -02:00
Maurício Meneghini Fauth
d296860a67 Fix Relation constructor parameter
DatabaseInterface is null if PMA_MINIMUM_COMMON is defined.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-08-30 19:24:42 -03:00
Maurício Meneghini Fauth
d4b4124a5e Remove $GLOBALS['dbi'] from Relation class
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-08-30 19:05:09 -03:00
William Desportes
3dce65d913 phpstan level 1 (#14472)
* level +1
* Install sami/sami globaly to avoid dependency clash

Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-08-18 14:37:41 -03:00
Maurício Meneghini Fauth
2d58411bee Some coding style fixes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-18 21:30:06 -03:00
Maurício Meneghini Fauth
244d4e8e81 Replace Template::get calls in libraries/classes
Uses Template::render() instead of Template::get().

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-18 18:18:24 -03:00
Maurício Meneghini Fauth
e6bfa47054
Merge pull request #14389 from williamdes/issue-14388
Closes #14388 - Search and Insert broken
2018-06-15 17:31:18 -03:00
Leonardo Strozzi
0d26cfb5f1 Finish db designer refactor
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
2018-06-11 19:37:07 -03:00
William Desportes
81a552cda0
Closes #14388 - Search and Insert broken
FK of type int breaks buildForeignDropdown
Closes: #14388

Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-06-11 12:07:33 +02:00
Maurício Meneghini Fauth
285e38e931 Fix some PSR-2 coding standard errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 09:07:56 -03:00
Maurício Meneghini Fauth
b9c0463d96 Use short array syntax instead of long array syntax
Replaces array() with [].

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 01:42:21 -03:00
Maurício Meneghini Fauth
6cf8ee0831 Enable strict mode in some classes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-15 01:03:57 -03:00
William Desportes
c19dec2c47
Revert modifications/error
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-05-10 00:06:15 +02:00
Maurício Meneghini Fauth
3bf396ce54
Merge pull request #14202 from williamdes/issue-13894-bin-fk-bug
Binary foreign key enhancement #13894
2018-05-03 15:52:04 -03:00
William Desportes
e9d3fdd493
Binary foreign key enhancement #13894
Closes: #13894
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-05-02 15:23:42 +02:00
Mohit Jawanjal
c8d9471c24 Inline style fix for Relation.php
Signed-off-by: Mohit Jawanjal <mohit.jawanjal@imnica.com>
2018-04-02 11:25:54 +05:30
Mohit Jawanjal
7d74f1e786 Remove inline styles from Relation.php
Signed-off-by: Mohit Jawanjal <mohit.jawanjal@imnica.com>
2018-03-28 17:08:17 +05:30
Maurício Meneghini Fauth
46ceeea14f Replace static methods with instance methods
Replace PhpMyAdmin\Relation static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-03-19 09:23:23 -03:00
Gabriel Caruso
a8bd364e02 Clean elses
Signed-off-by: Gabriel Caruso <carusogabriel34@gmail.com>
2017-12-14 22:02:17 -02:00
Maurício Meneghini Fauth
01fd301003 Use 'elseif' keyword istead of 'else if'
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-12-04 13:31:25 -02:00
Maurício Meneghini Fauth
f134a3ba67 Refactor templates/table/relation/foreign_key_row.phtml
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-10-29 12:18:28 -02:00
Michal Čihař
4fe87fb592 Remove usage of $GLOBALS['controllink']
This is now stored internally inside DatabaseInterface instance.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-25 10:21:18 +02:00
Michal Čihař
d574aede08 Bind Types to DatabaseInterface
This wayt it's automatically passed with DBI.

Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-10 12:05:02 +02:00
Michal Čihař
d2d32651bc Replace empty() by strlen()
In order to fix operation with database or table called 0.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-02 15:53:44 +02:00
Maurício Meneghini Fauth
1d4125f15c Add array type declarations
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-24 23:49:59 -03:00
Maurício Meneghini Fauth
9ecdd9c80a Rename libraries/mysql_relations.lib.php
Rename libraries/mysql_relations.lib.php to libraries/mysql_relations.inc.php

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-12 12:53:20 -03:00
Maurício Meneghini Fauth
62f53a1cd9 Rename information_schema_relations.lib.php
Rename libraries/information_schema_relations.lib.php to libraries/information_schema_relations.inc.php

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-12 11:09:03 -03:00
Maurício Meneghini Fauth
e2c83b954b Refactor relation functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-08-22 20:51:27 -03:00