Commit Graph

134 Commits

Author SHA1 Message Date
William Desportes
8b36aa39d2
Merge branch 'QA_4_8'
- Fixed code standard error
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-27 08:34:35 +01:00
William Desportes
252aebef48
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-26 23:37:53 +01:00
William Desportes
c1c22ff32f
Fix style issues
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-26 22:48:08 +01:00
William Desportes
76cbe9f961
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-26 21:05:09 +01:00
Anton Mokrousov
e41af9d6df Fixed issue #15077
Signed-off-by: Anton Mokrousov <settingx@mail.ru>
2019-03-24 21:36:25 +07:00
Maurício Meneghini Fauth
f009dfdb4f Merge branch 'QA_4_8' 2019-03-21 03:37:58 -03:00
Maurício Meneghini Fauth
33f510bfb4 Fix bug when creating or editing views
Fixes #14916

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-03-20 19:14:02 -03:00
William Desportes
cdff5426d6
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-19 22:39:38 +01:00
William Desportes
3e41eca650
Fix #14811 - SHOW FULL TABLES FROM when a table is locked
Fixes: #14811
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-19 22:34:22 +01:00
Maurício Meneghini Fauth
21e2ca4c4c Fix some PHPStan and phpcs errors
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-03-19 15:17:41 -03:00
Mohammad Reza Mansouri
23753e071e Fix missed padding on query results (#14730)
Solves missed paddings on query results.

Fixes #14053 

Signed-off-by: Mohammad Reza Mansouri <beekalam@gmail.com>
2019-03-16 15:07:36 +01:00
William Desportes
26963f2f2c
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-07 00:00:39 +01:00
William Desportes
638700692b
Fix #14734 - Invalid default value for bit field
Fixes: #14734
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-06 23:56:26 +01:00
William Desportes
6845dc41e9
Avoid duplicate test
Closes: https://github.com/phpmyadmin/phpmyadmin/pull/14874
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-02 11:35:25 +01:00
Maurício Meneghini Fauth
35fafd773a Create Controllers\Database\DataDictionaryController
- Extracts db_datadict.php logic to the controller
- Extracts HTML to database/data_dictionary/index template

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-03-01 23:06:13 -03:00
Vincent Milum Jr
31b40f71bb Fix for SYSTEM VERSIONED tables #14514, #14515, and #14516 (#14536)
Fixes #14514
Fixes #14515
Possible fix for #14516

 #14514 Tables which enable the new MariaDB 10.3 versioning show up as "SYSTEM VERSIONED" instead of "BASE TABLE" inside of information schema. This patch now checks for both, so these new table types don't incorrectly display as views.

 #14515 MariaDB 10.3 also supports INVISIBLE columns, which is optionally paired with SYSTEM VERSIONED tabled (or implemented separately). This patch helps handle this new column attribute.

 #14516 This patch cannot be fully tested and verified with current MariaDB builds. Version 10.3.9 (currently unreleased) corrects an issue with column information for SYSTEM VERSIONED columns that this patch relies on. https://jira.mariadb.org/browse/MDEV-16804 - the reason for checking with preg_match instead of adding to the list is because there are now combined "extra" information for columns, such as INVISIBLE columns. Just matching entire strings also has a bug with these other "extra" parameters.

Signed-off-by: Vincent Milum Jr <git@darkain.com>
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
(cherry picked from commit 3f6e360a4e)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-15 17:27:55 -02:00
Vincent Milum Jr
3f6e360a4e Fix for SYSTEM VERSIONED tables #14514, #14515, and #14516 (#14536)
Fixes #14514
Fixes #14515
Possible fix for #14516

#14514 Tables which enable the new MariaDB 10.3 versioning show up as "SYSTEM VERSIONED" instead of "BASE TABLE" inside of information schema. This patch now checks for both, so these new table types don't incorrectly display as views.

#14515 MariaDB 10.3 also supports INVISIBLE columns, which is optionally paired with SYSTEM VERSIONED tabled (or implemented separately). This patch helps handle this new column attribute.

#14516 This patch cannot be fully tested and verified with current MariaDB builds. Version 10.3.9 (currently unreleased) corrects an issue with column information for SYSTEM VERSIONED columns that this patch relies on. https://jira.mariadb.org/browse/MDEV-16804 - the reason for checking with preg_match instead of adding to the list is because there are now combined "extra" information for columns, such as INVISIBLE columns. Just matching entire strings also has a bug with these other "extra" parameters.

Signed-off-by: Vincent Milum Jr <git@darkain.com>
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-15 14:16:13 -02:00
Nitish Bahl
5014a289f3 fixes #14734 Invalid default value for bit field
Signed-off-by: Nitish Bahl <nitishbahl24@gmail.com>
2019-01-22 18:30:54 +05:30
Hugues Peccatte
4321120b80 Fix PHPCS issue
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-21 12:27:26 +01:00
Hugues Peccatte
f06883d2a7 Remove useless parenthesis
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-20 01:23:53 +01:00
Maurício Meneghini Fauth
f9c168dbc1
Merge pull request #14850 from Tithugues/feature/group-str-replace
Group str_replace for performances
2019-01-16 02:55:53 -03:00
Maurício Meneghini Fauth
9ab8066296
Merge pull request #14862 from Tithugues/feature/rewrite-concat-and-operations
Rewrite some concatenations or operations done in a long way
2019-01-16 02:25:43 -03:00
Maurício Meneghini Fauth
76fbe019da
Merge pull request #14856 from Tithugues/fix/escape-also-delimiter
Escape also delimiter
2019-01-16 02:19:24 -03:00
Maurício Meneghini Fauth
fedad552cc
Merge pull request #14849 from Tithugues/feature/replace-regexp-when-simple
Replace regular expressions when simple
2019-01-16 02:14:51 -03:00
Maurício Meneghini Fauth
728f61ec5d Extract HTML from PhpMyAdmin\Sql
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-15 03:50:38 -02:00
Maurício Meneghini Fauth
f3ccef50c6
Merge pull request #14860 from Tithugues/feature/use-real-names-not-aliases
Use real function names, not their aliases
2019-01-14 22:55:37 -03:00
Hugues Peccatte
9406e922cc Update PHPDoc
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-13 09:52:46 +01:00
Hugues Peccatte
7ef90149c3 Rewrite some concatenations or operations done in a long way
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-13 00:18:47 +01:00
Hugues Peccatte
280926e3f3 Escape also delimiter
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-12 23:38:39 +01:00
Hugues Peccatte
a8d801f176 Use real function names, not their aliases
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-12 23:37:52 +01:00
Maurício Meneghini Fauth
65d2693d85
Merge pull request #14845 from Tithugues/feature/replace-or-improve-for
Replace or improve use of 'for'
2019-01-12 13:18:05 -03:00
Hugues Peccatte
d0797fff4d Group str_replace for performances
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-12 10:47:48 +01:00
Hugues Peccatte
7685733389 Replace or improve use of 'for'
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-12 09:43:25 +01:00
Hugues Peccatte
746fd8b417 Replace regular expressions when simple
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-12 02:06:28 +01:00
Hugues Peccatte
68b88d0537 Remove useless variables before return
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-12 01:33:22 +01:00
Maurício Meneghini Fauth
25e480666e Fix doc comments alignment
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-07 15:09:32 -02:00
Maurício Meneghini Fauth
23c3579804 Format array declarations
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-07 14:31:39 -02:00
Maurício Meneghini Fauth
4cee0cbc12 Adds space after not (!) and type cast
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-05 21:56:34 -02:00
Maurício Meneghini Fauth
999b4d14f0 Fix some coding standard errors
- Fixes array identation
- Removes empty statements

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-05 21:25:08 -02:00
Maurício Meneghini Fauth
3a7e1503ac Fix some coding standard errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-04 19:42:10 -02:00
Maurício Meneghini Fauth
38e5b12c1c Define an absolute path to use for require statements
Fixes #6167

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-22 14:37:31 -02:00
Maurício Meneghini Fauth
ef5d7dd66b Use Bootstrap buttons component
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-21 01:01:12 -02:00
Maurício Meneghini Fauth
9eba565bf4 Remove unnecessary HTML closing tags
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-19 00:12:54 -02:00
Madhura Jayaratne
abb690e536 Escape SQL query in copy query functionality. Thanks to Ashish Kamble for reporting
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2018-12-14 23:23:55 +11:00
Mohammad Reza Mansouri
95167e6893 Fix missed padding on query results (#14730)
Solves missed paddings on query results.

Fixes #14053 

Signed-off-by: Mohammad Reza Mansouri <beekalam@gmail.com>
2018-11-28 20:52:36 -02:00
William Desportes
cc2665121d
phpstan level 2 - fixes
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-11-25 13:57:57 +01:00
William Desportes
bcefdd79fa
phpstan level 2 - Fix phpdoc
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-11-25 13:57:55 +01:00
Tomas Votruba
bf720bad29 remove unused and fix @param, @var and @return annotation values
Signed-off-by: Tomas Votruba <tomas.vot@gmail.com>
2018-11-24 21:47:26 +01:00
Lakshay arora
2b065133a2 Adds features discussed in #13023
1. Show ajax errors at the bottom of the page, instead of showing them in a popup.
2. Add copy query button for errors in processing sql queries.

Signed-off-by: Lakshay arora <arora.lakshya123@gmail.com>
2018-11-14 23:20:12 -02:00
Maurício Meneghini Fauth
d7affca556 Fix uncaught TypeError in Util::printableBitValue
Fixes #14718

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-12 21:50:42 -02:00