Commit Graph

4237 Commits

Author SHA1 Message Date
William Desportes
e453ad1320
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-27 19:15:57 +02:00
William Desportes
646668b52d
Fix Unit tests for #15229
See: 91c758aae4
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-27 19:01:59 +02:00
Maurício Meneghini Fauth
5254ec1b65 Refactor Navigation\NavigationTree
- Extract HTML from renderState() and renderDbSelect()
- Use DI for $dbi instead of global
- Fix tests

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-04-24 02:25:48 -03:00
Maurício Meneghini Fauth
7d199a7bc2 Fetch dbi from DI instead of global in Navigation class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-04-23 16:43:16 -03:00
Maurício Meneghini Fauth
1d0dad5cd6 Extract HTML from Navigation::getItemUnhideDialog()
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-04-23 16:24:55 -03:00
Maurício Meneghini Fauth
c642c29aa4 Extract HTML from Navigation::getDisplay()
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-04-22 15:57:16 -03:00
Maurício Meneghini Fauth
5abc69c280 Extract HTML from Scripts::getDisplay()
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-04-19 21:47:27 -03:00
Maurício Meneghini Fauth
b0e5a9ac59 Extract HTML from Footer::getDisplay()
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-04-19 16:39:24 -03:00
Maurício Meneghini Fauth
47fa0d8bdb Extract HTML from Header::getDisplay()
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-04-19 15:37:33 -03:00
Maurício Meneghini Fauth
7f793cdd59 Use DI for $dbi global in Export class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-04-17 22:10:43 -03:00
Maurício Meneghini Fauth
5e828ec810 Create Server\ReplicationController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-04-06 20:26:06 -03:00
William Desportes
252aebef48
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-26 23:37:53 +01:00
William Desportes
e1ebb641a6
Fix failing tests after merge of #14867
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-26 23:19:08 +01:00
William Desportes
c1c22ff32f
Fix style issues
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-26 22:48:08 +01:00
William Desportes
76cbe9f961
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-26 21:05:09 +01:00
Maurício Meneghini Fauth
be936acd3b Add ChangeLog entry for #13424
Fix coding standard errors

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-03-25 17:14:44 -03:00
amarjitsingh52922
dd88475656 Fix for #13424 Importing a CSV created tables named Table ##" (#14935)
Fix #13424 Importing a CSV created tables named "Table ##"

Signed-off-by: Amarjit Singh <amarjitsingh52922@gmail.com>
2019-03-25 16:49:16 -03:00
Nupur Agrawal
b09d9565df Deleted redundant help/tool tip on page settings (#15061)
Removed redundant help/tool tip in page settings "Query history length" area.

Fixes issue #15029

Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
2019-03-24 19:31:58 -04:00
William Desportes
9dd940c58a
Fix whitespace
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-24 18:35:37 +01:00
Anton Mokrousov
e41af9d6df Fixed issue #15077
Signed-off-by: Anton Mokrousov <settingx@mail.ru>
2019-03-24 21:36:25 +07:00
Maurício Meneghini Fauth
aa0796c7db Move special_schema_links.inc.php to Config\SpecialSchemaLinks
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-03-22 21:29:58 -03:00
Maurício Meneghini Fauth
3de704cf71 Skip test when PHP GD extension is not loaded
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-03-20 16:15:14 -03:00
Maurício Meneghini Fauth
525a436162 Fix some PHPStan errors
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-03-19 16:48:54 -03:00
Maurício Meneghini Fauth
d2d65d5a7b Create controllers for setup pages
- Create PhpMyAdmin\Controllers\Setup\HomeController
- Create PhpMyAdmin\Controllers\Setup\ConfigController
- Create PhpMyAdmin\Controllers\Setup\FormController
- Create PhpMyAdmin\Controllers\Setup\ServersController
- Remove setup/frames directory

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-03-06 17:04:58 -03:00
Maurício Meneghini Fauth
50ec2c0e2b Create Controllers\Database\CentralColumnsController
Moves db_central_columns.php logic to the controller

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-03-05 02:12:12 -03:00
Maurício Meneghini Fauth
e700760685 Refactor Controllers\Database\StructureController
Move request and response handling to db_structure.php

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-03-03 23:20:48 -03:00
Maurício Meneghini Fauth
9d12039264 Fix ProcessesControllerTest
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-25 21:05:32 -03:00
Maurício Meneghini Fauth
3ac708ab32 Remove PhpMyAdmin\Server\Status\Data::getMenuHtml()
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-25 19:07:15 -03:00
Maurício Meneghini Fauth
2074be7eab Create Server\Status\VariablesController
Extracts server_status_variables.php and Server\Status\Variables logic
to the controller.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-25 19:02:54 -03:00
Maurício Meneghini Fauth
e149a6188f Create Server\Status\QueriesController
Extracts server_status_queries.php and Server\Status\Queries logic to
the controller.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-25 00:53:57 -03:00
Maurício Meneghini Fauth
84d9e722d8 Merge branch 'QA_4_8'
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-24 20:10:36 -03:00
Maurício Meneghini Fauth
73427358f4 Fix QBE selenium test
Related to #14536

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-24 20:07:53 -03:00
Maurício Meneghini Fauth
6bd2dbd5f2 Add support for PHPUnit 8
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-24 16:32:28 -03:00
Maurício Meneghini Fauth
74105ab85c Replace readAttribute() and assertAttributeEquals()
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-24 16:32:28 -03:00
Maurício Meneghini Fauth
39141e7c68 Replace assertInternalType() with assertIsArray()
assertInternalType() is deprecated and will be removed in PHPUnit 9. Refactor your test to use assertIsArray(), assertIsBool(), assertIsFloat(), assertIsInt(), assertIsNumeric(), assertIsObject(), assertIsResource(), assertIsString(), assertIsScalar(), assertIsCallable(), or assertIsIterable() instead.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-24 16:32:28 -03:00
Maurício Meneghini Fauth
3e1b935df6 Replace assertEquals() with assertEqualsWithDelta()
The optional $delta parameter of assertEquals() is deprecated and will be removed in PHPUnit 9. Refactor your test to use assertEqualsWithDelta() instead.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-24 16:32:28 -03:00
Maurício Meneghini Fauth
92cc67fbf7 Replace assertContains() with assertStringContainsString()
Using assertContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringContainsString() or assertStringContainsStringIgnoringCase() instead.
Using assertNotContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringNotContainsString() or assertStringNotContainsStringIgnoringCase() instead.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-24 16:32:28 -03:00
Maurício Meneghini Fauth
73a0ddf1c1 Add void return types to selenium tests
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-22 22:05:50 -03:00
Maurício Meneghini Fauth
182491a73f Add void return type declaration for tests
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-22 21:33:55 -03:00
Maurício Meneghini Fauth
c485c311aa Create Server\Status\ProcessesController
Extracts server_status_processes.php and Server\Status\Processes logic
to controller.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-21 23:25:30 -03:00
Maurício Meneghini Fauth
12ae5553a6 Create Server\Status\MonitorController
Moves server_status_monitor.php logic to controller

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-21 02:23:23 -03:00
Maurício Meneghini Fauth
c9a31450fa Create server status abstract controller
Create PhpMyAdmin\Controllers\Server\Status\Controller abstract
controller.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-19 17:13:48 -03:00
Maurício Meneghini Fauth
5368c151b4 Create Server\Status\StatusController
- Extracts Server\Status and server_status.php logic to controller
- Extracts HTML to server/status/status/index template

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-18 15:59:59 -03:00
Maurício Meneghini Fauth
4bf6ad1952 Create Server\Status\AdvisorController
- Moves PhpMyAdmin\Server\Status\Advisor and server_status_advisor.php
logic to the controller.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-17 16:03:09 -03:00
Maurício Meneghini Fauth
02a9fd371c Refactor Server\VariablesController
- Moves request and response handling to server_variables.php
- Extracts and groups all HTML in server/variables/index template

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-17 13:01:10 -03:00
Maurício Meneghini Fauth
20cccfd53b Refactor Server\PluginsController
- Moves response handling to server_plugins.php
- Renames server/plugins/main to server/plugins/index

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-16 15:05:05 -02:00
Maurício Meneghini Fauth
d6dfb3eed6 Refactor Server\EnginesController
- Moves request and response handling back to server_engines.php
- Rename templates
- Refactor tests

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-15 20:35:00 -02:00
Maurício Meneghini Fauth
b97460a320 Rename TableStructureController to StructureController
Renames PhpMyAdmin\Controllers\Table\TableStructureController to
PhpMyAdmin\Controllers\Table\StructureController.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-14 16:30:49 -02:00
Maurício Meneghini Fauth
505af51a1c Rename TableSearchController to SearchController
Renames PhpMyAdmin\Controllers\Table\TableSearchController to
PhpMyAdmin\Controllers\Table\SearchController.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-14 16:08:18 -02:00
Maurício Meneghini Fauth
6c29e58ef7 Rename TableRelationController to RelationController
Renames PhpMyAdmin\Controllers\Table\TableRelationController to
PhpMyAdmin\Controllers\Table\RelationController.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-14 15:43:07 -02:00