Commit Graph

279 Commits

Author SHA1 Message Date
Chirayu Chiripal
1f324be4b1 RFE-637: Custom field handlers (input transformations)
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-07-12 01:52:32 +05:30
Atul Pratap Singh
ab1d28fb79 Merge commit '2819506' 2014-07-02 14:08:13 +05:30
Atul Pratap Singh
2819506bb0 Have single-sort url besides multi-sort for each column and make single-sort default on click
Signed-off-by: Atul Pratap Singh <atulpratapsingh05@gmail.com>
2014-07-01 23:32:05 +05:30
Marc Delisle
5b6331cb7e Fix parameter type
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-06-30 16:03:34 -04:00
Michal Čihař
dca981481d Remove plugin manager and observer classes
We don't really need the observer pattern, so let's simplify the code.

Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-25 09:25:59 +02:00
Hugues Peccatte
09a8a40300 Merge pull request #1240 from Tithugues/scrutinizer
Fix some Scrutinizer issues
2014-06-22 16:38:59 +02:00
Ann + J.M
6b778e09d9 Fix coding style
Signed-off-by: Ann + J.M <phpMyAdmin@ZweiSteinSoft.de>
2014-06-22 16:34:34 +02:00
Marc Delisle
67a705b053 Merge branch 'QA_4_2' 2014-06-20 15:41:05 -04:00
Marc Delisle
a30405fe0b bug #4467 shell_exec() has been disabled for security reasons
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-06-20 15:39:09 -04:00
Hugues Peccatte
66f82fbfac Update PHPDoc and remove useless variables and methods to fix scrutinizer errors.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-06-19 22:09:18 +02:00
Chirayu Chiripal
c8a6ea0467 scrutinizer issues fix
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-06-19 17:10:55 +05:30
Marc Delisle
c43df7d140 Clarify parameter type
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-06-14 17:42:08 -04:00
Marc Delisle
d4a45f66cc Fix typo
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-06-14 12:36:55 -04:00
Marc Delisle
03fb581447 Refactor vertical display links
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-06-14 12:34:06 -04:00
Michal Čihař
c1959a2e05 Fix parameter type declaration
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-06 14:23:06 +02:00
Michal Čihař
c3630c3cf7 Remove unused parameter
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-06 14:23:06 +02:00
Michal Čihař
4638c051f5 Use passed parameter instead of calculating it again
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-06 14:23:06 +02:00
Michal Čihař
900ce069ee Correctly store kill query for later use
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-06 11:56:47 +02:00
Michal Čihař
11f76e66b3 Fix typo in variable name
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-06 11:54:12 +02:00
Michal Čihař
3e268dbdf9 Make _addClass a bit more readable
We now construct an array which we join in the end. This avoids need to
care about spaces in the class names.

Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-06 11:21:04 +02:00
Michal Čihař
444c5828a6 Avoid double conditions for DELETE_ROW/KILL_PROCESS, handle all of that in _getDeleteAndKillLinks
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-06 11:12:27 +02:00
Michal Čihař
7bc9eba9bc One place to generate KILL query
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-06 11:08:40 +02:00
Craig Duncan
17fd6b576a Dynamically detect an amazon rds instance
This is to avoid more configuration options

Signed-off-by: Craig Duncan <git@duncanc.co.uk>
2014-06-05 19:38:57 +01:00
Craig Duncan
812d1ce67d Allow processes to be killed on Amazon RDS
The 'KILL' syntax isn't available but a procedure to do the same thing is
http://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/Appendix.MySQL.CommonDBATasks.html

Signed-off-by: Craig Duncan <git@duncanc.co.uk>
2014-06-03 22:39:04 +01:00
Marc Delisle
673fce8145 Fix coding style
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-06-03 12:33:25 -04:00
Ann + J.M
ddf78c212b Re-merge b3dbec1...9207203, changes got lost on original merge from QA_4_2
Signed-off-by: Ann + J.M <phpMyAdmin@ZweiSteinSoft.de>
2014-05-26 10:39:50 +02:00
Hugues Peccatte
b7b7e25fe0 Replace edit input for text fields.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-05-24 23:33:56 +02:00
Chirayu Chiripal
85390a7169 rfe-982: Support for editing binary fields in hexadecimal
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-05-21 21:42:21 +05:30
Ann + J.M
69ddb29989 Code style fixes
Signed-off-by: Ann + J.M <phpMyAdmin@ZweiSteinSoft.de>
2014-05-19 22:33:01 +02:00
Michal Čihař
329deddbfd Let's have just one PMA_mimeDefaultFunction
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-10 14:53:49 +02:00
Michal Čihař
c1d832b22c Remove unused code
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-06 19:32:54 +02:00
Michal Čihař
baaaacd176 Remove unused code
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-06 19:31:56 +02:00
Michal Čihař
da529f00b4 Remove default parameter value, passing sting here will fail
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-06 19:29:07 +02:00
Marc Delisle
f46865c660 Fix coding style
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-04-11 09:34:51 -04:00
Marc Delisle
ea3447ed8e Previous fix for notices was incorrect
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-04-06 08:56:53 -04:00
Marc Delisle
a0cdd1f97f Fix notices
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-04-06 08:43:35 -04:00
Marc Delisle
9fa2ea5a0f Show sorted column message for all of the sorted columns, not just the last one
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-04-06 08:32:45 -04:00
Marc Delisle
153b6c1497 Fix incorrect number of returned parameters
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-04-06 08:30:09 -04:00
Chanaka Indrajith
e24d4c3f90 Improved function logic to one statement and remove unnecessary functions
Signed-off-by: Chanaka Indrajith <pe.chanaka.ck@gmail.com>
2014-04-05 22:49:13 +05:30
Ashutosh Dhundhara
5ea6345adb Filter rows option on "Browse" table page.
Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Filter rows feature on "Browse" table page.

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Included table filter plugin in tbl_select.php.

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>
2014-03-31 17:52:48 +05:30
Chanaka Indrajith
a2caec9cc6 Remove unused parameters
Signed-off-by: Chanaka Indrajith <pe.chanaka.ck@gmail.com>
2014-03-30 00:10:31 +05:30
Chanaka Indrajith
d27bbe6f9d Fixed naming convention for private method makeURL
Signed-off-by: Chanaka Indrajith <pe.chanaka.ck@gmail.com>
2014-03-29 23:04:14 +05:30
Chanaka Indrajith
4071c6eaa6 Remove unused parameters in _getSortingUrlParams() function
Signed-off-by: Chanaka Indrajith <pe.chanaka.ck@gmail.com>
2014-03-29 22:52:39 +05:30
Chanaka Indrajith
60e33b5a59 Fixed some code violations
Signed-off-by: Chanaka Indrajith <pe.chanaka.ck@gmail.com>
2014-03-29 22:41:43 +05:30
Marc Delisle
81345e9b53 Fix coding style
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-03-26 12:39:52 -04:00
Aditya Sastry
a05ab9640b Multicolumn sorting feature request(1507)
This patch completely implements the feature requested and it modifies 4
existing files and adds one extra Javascript file. The existing system for
one column sorting has been refactored to be used for multicolumn sort.

Files messages.php and makegrid.js where modified to add the tool tip.

File sql.php was modified to add the import statement for the newly added JS
file.

The newly added columndelete.js is responsible for shift deleting the columns.
It gets the url of the link that was shift clicked and removes the name of the
column which we want to remove from the order by clause.

Finally, most of the crux of this feature request is implemented through
changes to the DisplayResult.class.php. 4 methods of this class have been
refactored to accomodate the required change. getsortparams() which process
the order by clause text remains the same, just the output parameters have
been turned into a array for each order by clause column. isInSort() has been
modified to check multiple order by clauses. The smart ordering feature in
to form a new function makeURL, which makes the url for multiple sorted table's
header's button's targets.

Signed-off-by: Aditya Sastry <ganeshaditya1@gmail.com>
2014-03-24 02:17:54 +05:30
Marc Delisle
5a1b20bf2a Fix coding style
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-02-19 12:38:22 -05:00
Marc Delisle
d20f0fee78 Merge branch 'QA_4_1' 2014-02-16 12:57:37 -05:00
Marc Delisle
06bd132d46 bug #4287 Printview - Always one column too much
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-02-16 12:57:01 -05:00
Marc Delisle
ae163e4d67 Merge commit '2453a15' 2014-02-03 12:30:23 -05:00