Commit Graph

451 Commits

Author SHA1 Message Date
Chirayu Chiripal
1f324be4b1 RFE-637: Custom field handlers (input transformations)
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-07-12 01:52:32 +05:30
Ann + J.M
f5a9a60382 Fix coding style
Signed-off-by: Ann + J.M <phpMyAdmin@ZweiSteinSoft.de>
2014-07-03 20:27:39 +02:00
Michal Čihař
6be21dcb47 Merge pull request #1251 from WhaleWatching/console
PMA console, history and bookmarks.
2014-06-25 15:37:29 +02:00
Edward Cheng
fb14e92d62 PMA console, history and bookmarks.
Modified: resizer of navigation bar: whole-time-bind events removed.

Signed-off-by: Edward Cheng <c4150221@gmail.com>
2014-06-25 21:22:33 +08:00
Michal Čihař
34fec13115 Merge pull request #1252 from nijel/remove-observer
Remove plugin manager and observer classes
2014-06-25 14:27:45 +02:00
Michal Čihař
06b1ffc8da Fix comments
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-25 14:11:01 +02:00
Michal Čihař
dca981481d Remove plugin manager and observer classes
We don't really need the observer pattern, so let's simplify the code.

Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-25 09:25:59 +02:00
Chirayu Chiripal
a78a7a0c9c export with table/column names changes extended for other export formats
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-06-18 16:09:57 +05:30
Chirayu Chiripal
3ea7d2b52d rfe-755: export with table/column name changes
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-06-16 22:41:50 +05:30
Dhananjay Nakrani
7b8006651b Make "Ignore All" button work on login page.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:52 +05:30
Michal Čihař
bd4cccc039 Move password change handling to authenticaton plugins
We should not care about plugin type while changing password, we should
just notify it and the plugin should be responsible for anything needed.

Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-12 14:43:10 +02:00
Michal Čihař
92a10d0968 Factor out cookie storing to separate methods
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-12 14:43:10 +02:00
Michal Čihař
e433d8189b Use phpseclib for generating session encryption key
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-12 14:43:10 +02:00
Michal Čihař
da047efbd1 Use random per session key for encrypting password
This makes it impossible to decrypt cookies later if the key would be
compromised.

Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-12 14:43:10 +02:00
Michal Čihař
5e51f178dd Remove some blowfish mentions
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-12 14:43:10 +02:00
Michal Čihař
cd4d54395b Remove another reference to Blowfish
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-12 14:43:10 +02:00
Michal Čihař
96977c994e Use require here
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-12 10:50:52 +02:00
Michal Čihař
20640592f0 Always use phpseclib for cookie encryption
- it provides fallback in case mcrypt is not found
- we now use AES in both mcrypt and PHP code case
- cleanup the code by removing mcrypt conditials
- rename some methods and cookies so that they don't refer to
  implementation details
- switching encryption implementations no longer invalidates the
  credentials

Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-12 10:39:52 +02:00
Michal Čihař
0652ca9ccd Merge remote-tracking branch 'origin/QA_4_2' 2014-06-12 10:19:00 +02:00
Michal Čihař
bc60315023 Adjust tests to new IV logic
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-12 10:18:45 +02:00
Michal Čihař
c6e76422c4 Allow to use system phpseclib
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-12 10:06:20 +02:00
Michal Čihař
716f6d4c55 Merge remote-tracking branch 'origin/QA_4_2' 2014-06-12 09:47:17 +02:00
Michal Čihař
953c7415ad Separate check for password cookie
Otherwise it would not be possible to recall user name.

Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-12 09:47:04 +02:00
Michal Čihař
5d39998a86 Merge commit '7cba81de271d62bdf93ded7598709702a96f92d7'
Conflicts:
	libraries/plugins/auth/AuthenticationCookie.class.php
2014-06-12 09:45:13 +02:00
Michal Čihař
7cba81de27 Regenerate cookie encryption IV for every session
The IV for cookie encryption was generated just once for every browser
and kept in a cookie. Generating it for every session is much better to
avoid information leaks (eg. that same user has logged in).

Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-12 09:41:27 +02:00
Michal Čihař
b252cb9981 Use better source of entropy for mcrypt IV
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-12 09:16:20 +02:00
Marc Delisle
a6d379caf2 Since PHP 5.3.0, it's not longer required to call srand() before
mcrypt_create_iv().

Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-06-11 08:31:23 -04:00
Marc Delisle
a83ca5d73b Fix merge conflict
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-06-10 12:43:07 -04:00
Chirayu Chiripal
ff688b18fb Bug-4448: Dump binary columns in hexadecimal notation not working and hex_for_blob -> hex_for_binary
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-06-10 19:00:16 +05:30
Michal Čihař
06abaaa33f Merge remote-tracking branch 'origin/QA_4_2' 2014-06-10 08:59:18 +02:00
Isaac Bennetch
307dd3b798 Bug 4449: Mediawiki export does not produce table header row; also fix related PHP warnings
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2014-06-09 16:37:43 -04:00
Chirayu Chiripal
33dfef377f RFE-759 Use aliases in SQL export for tables and columns
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-06-09 22:44:07 +05:30
Michal Čihař
c9dc5611ee Fix type string for longtext
It has to be checked before "long", otherwise it matches first.

Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-06 15:46:34 +02:00
Michal Čihař
1efadc8e7c We already check for empty value, remove todo
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-06 15:46:34 +02:00
Marc Delisle
84f135d048 Fix coding style
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-06-03 12:40:21 -04:00
Marc Delisle
49c9dd3ecb Remove dead code
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-05-30 12:20:32 -04:00
Ann + J.M
ddf78c212b Re-merge b3dbec1...9207203, changes got lost on original merge from QA_4_2
Signed-off-by: Ann + J.M <phpMyAdmin@ZweiSteinSoft.de>
2014-05-26 10:39:50 +02:00
Ann + J.M
d9bd81a2a1 Code style fixes
Signed-off-by: Ann + J.M <phpMyAdmin@ZweiSteinSoft.de>
2014-05-19 22:40:24 +02:00
Marc Delisle
39c181ca1e Merge branch 'QA_4_2' 2014-05-18 13:23:16 -04:00
Marc Delisle
e813cab608 bug #4418 When copying databases, primary key attributes get lost
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-05-18 13:22:14 -04:00
Chanaka Indrajith
cf6a8ce4e1 Fixed documentation issue related to argument type mismatching in ImportCsv.class.php file, raised by scrutinizer
Signed-off-by: Chanaka Indrajith <pe.chanaka.ck@gmail.com>
2014-05-17 18:11:10 +05:30
Marc Delisle
49f1bdd822 Merge commit '0ee881d' 2014-05-16 12:20:52 -04:00
Marc Delisle
0ee881da71 bug #4395 BLOB link transformation is broken
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-05-16 09:56:47 -04:00
Michal Čihař
8f45363f66 Merge branch 'QA_4_2' 2014-05-10 17:35:59 +02:00
Michal Čihař
b177557c11 Use preg_quote instead of home made replacement to quote string for preg
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-10 17:35:49 +02:00
Michal Čihař
afe414102a Improve check for empty message
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 16:02:48 +02:00
Michal Čihař
f159a39ff2 Handle cases when errno is set, but dbi does not return error message
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 15:53:45 +02:00
Michal Čihař
d44c4d9a96 Properly report MySQL error
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 15:12:06 +02:00
Michal Čihař
650e0512de Share code for getting error message
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 15:05:36 +02:00
Michal Čihař
82b4549176 Remove unused parameter of PMA_Util::cacheUnset
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 14:21:12 +02:00