Commit Graph

15 Commits

Author SHA1 Message Date
Kamil Tekiela
8015e4de72 Move DatabaseInterface to Dbal
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-22 18:34:53 +00:00
Kamil Tekiela
b687a6f62b Split off fetchSingleColumn()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-22 00:07:06 +00:00
Kamil Tekiela
319ae0d2e3 Split off fetchResultSimple
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-22 00:04:18 +00:00
Maurício Meneghini Fauth
dc1bd60dd1
Fix boolean usage of the return value of preg_match()
preg_match() and preg_match_all() returns the number of pattern matches
(which might be zero), or false on failure. However, preg_match() always
returns 1 when a pattern is matched as it stops searching after the
first match.

- https://www.php.net/manual/en/function.preg-match.php
- https://www.php.net/manual/en/function.preg-match-all.php

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-07-13 14:43:05 -03:00
Kamil Tekiela
8e4443b17b
Applying suggestions from static analysis tools (#19013)
* Drop array keys from lists

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Import UrlTest

When it doesn't exist in Prod, the code will still work the same.
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Drop redundant return [];

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix object access checks

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use strict comparison

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Int keys should be specified as integers

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use empty string check instead of strlen

Potential null deprecations are replaced with loose condition.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use stripos instead of *substr

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify substr's 3rd param

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove unnecessary defaults

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace isZeroBasedArray with array_is_list

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify texEscape()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify exportZeroBasedArray()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace for loop with array_diff

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace for with foreach

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove nullable param in backquoteCompat

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use null-coalescing operator

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Inline $result variable

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Turn $event into a constant

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Move selectDb outside the loop

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix code style order of operation

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove unnecessary isset argument

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove line break

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use foreach instead of for

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-02-27 12:29:02 -03:00
Maurício Meneghini Fauth
20364c92fc
Rename CheckUserPrivileges class to UserPrivilegesFactory
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-02-10 19:26:52 -03:00
Maurício Meneghini Fauth
8ee44a377e
Refactor UserPrivileges to use instance instead of static props
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-02-09 15:49:00 -03:00
Maurício Meneghini Fauth
0a15e1ca0b Extract dependencies from ListDatabase class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-01-07 00:00:38 -03:00
Maurício Meneghini Fauth
8a9690749d Remove ListAbstract class
This abstract class is not necessary.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-01-06 22:18:41 -03:00
Maurício Meneghini Fauth
4f92a073ae Remove ListAbstract::getDefault() method
This method only returns the value of Current::$database.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-01-06 22:09:39 -03:00
Maurício Meneghini Fauth
4fefea40c7 Extract privileges globals to static props of UserPrivileges class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-01-05 17:50:13 -03:00
Kamil Tekiela
2501d77bd3 Use first-class function for strnatcasecmp
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-19 21:43:41 +01:00
Maurício Meneghini Fauth
ec873965ed
Fix some issues with Current::$database
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-12-17 14:59:04 -03:00
Maurício Meneghini Fauth
711f6c0f14
Replace db global variable with static class property
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-12-17 14:58:59 -03:00
Maurício Meneghini Fauth
c2955cc2b2
Rename the directory libraries/classes/ to src/
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-08-30 15:59:28 -03:00