Commit Graph

21 Commits

Author SHA1 Message Date
Kamil Tekiela
821bb81af2 Drop getColumnsFull()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-23 17:58:03 +00:00
Kamil Tekiela
e48812937b Refactor getDisplayField to remove DATA_TYPE
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-23 17:12:28 +00:00
Kamil Tekiela
edd1e2ea0a Refactor getISCompatForGetColumnsFull
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-23 16:05:51 +00:00
Kamil Tekiela
8015e4de72 Move DatabaseInterface to Dbal
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-22 18:34:53 +00:00
Kamil Tekiela
678f367bcc Drop DbalInterface
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-22 18:34:53 +00:00
Maurício Meneghini Fauth
fabf58df27
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-10-31 17:21:13 -03:00
Maurício Meneghini Fauth
cd62509cb3
Make AddKeyController extends AbstractIndexController
Refactors Table\Structure\AddKeyController class to extends
Table\Structure\AbstractIndexController and to remove the dependency on
the Sql\SqlController class.

This helps with the response handling.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-22 12:18:07 -03:00
Kamil Tekiela
54b5464ec2 Replace function casts with normal casts
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-03-03 15:07:57 +01:00
Maurício Meneghini Fauth
a82c7fcb6f
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-03-03 00:46:10 -03:00
Kamil Tekiela
8e4443b17b
Applying suggestions from static analysis tools (#19013)
* Drop array keys from lists

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Import UrlTest

When it doesn't exist in Prod, the code will still work the same.
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Drop redundant return [];

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix object access checks

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use strict comparison

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Int keys should be specified as integers

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use empty string check instead of strlen

Potential null deprecations are replaced with loose condition.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use stripos instead of *substr

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify substr's 3rd param

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove unnecessary defaults

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace isZeroBasedArray with array_is_list

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify texEscape()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify exportZeroBasedArray()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace for loop with array_diff

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace for with foreach

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove nullable param in backquoteCompat

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use null-coalescing operator

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Inline $result variable

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Turn $event into a constant

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Move selectDb outside the loop

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix code style order of operation

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove unnecessary isset argument

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove line break

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use foreach instead of for

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-02-27 12:29:02 -03:00
Maurício Meneghini Fauth
a858f08fec Move error related classes to the Error namespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-01-05 13:28:23 -03:00
Kamil Tekiela
344e3306cf Redesign getCachedTableContent()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-27 18:17:31 +01:00
Kamil Tekiela
efbfe24348 Narrow down types in Cache
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-20 21:07:03 +01:00
Kamil Tekiela
5e24fb8a52 Replace cacheTableContent with cacheTableValue
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-20 21:07:03 +01:00
Kamil Tekiela
d90f31f67c Remove nullable param
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-20 21:07:03 +01:00
Kamil Tekiela
4e394dddf6 Apply narrower type hints
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-20 21:07:02 +01:00
Kamil Tekiela
982b5bb4d0 Simplify Util::getValueByKey()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-17 22:16:45 +01:00
Kamil Tekiela
4fb335e960 Make in_array strict
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-07 17:11:48 +01:00
Kamil Tekiela
51f9c749ad Simplify code
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-11-28 14:42:37 +01:00
Maurício Meneghini Fauth
4f647158d6
Replace escapeString with quoteString
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-10-03 22:01:47 -03:00
Maurício Meneghini Fauth
c2955cc2b2
Rename the directory libraries/classes/ to src/
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-08-30 15:59:28 -03:00