Commit Graph

56 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
c2cdfd7fb3
Remove the buffer_message global variable
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-01-10 17:57:39 -03:00
Maurício Meneghini Fauth
1564e8037b
Remove the using_bookmark_message global variable
Replaces it with Sql::$usingBookmarkMessage static property.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-01-10 16:54:08 -03:00
Maurício Meneghini Fauth
56b9e2132f
Remove the show_as_php global variable
Replaces it with Sql::$showAsPhp static property.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-01-10 12:46:42 -03:00
Maurício Meneghini Fauth
f42d1b297c
Remove the querytime global variable
Replaces it with a private property.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-01-09 20:31:13 -03:00
Maurício Meneghini Fauth
ebea0aa748
Remove the reload global variable
Replace it with ResponseRenderer::$reload static property.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-01-07 23:56:16 -03:00
Kamil Tekiela
f0f84295cc Undo change to $table
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-29 22:58:19 +00:00
Kamil Tekiela
30868c4e60 Remove nullability in Sql
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-29 22:40:42 +00:00
Kamil Tekiela
df463502b3 Remove dead param $sqlData
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-29 22:25:24 +00:00
Kamil Tekiela
de5c7b544b Remove nullability in Sql
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-29 22:15:31 +00:00
Kamil Tekiela
2921585089 Remove unnecessary nullability
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-29 21:50:36 +00:00
Kamil Tekiela
2348ae8342 Refactor storeTheQueryAsBookmark
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-29 15:21:09 +00:00
Maurício Meneghini Fauth
081d6c13d0
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-12-25 12:37:15 -03:00
Maurício Meneghini Fauth
03d9afc33f
Replace message global with Current::$message prop
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-12-23 19:09:46 -03:00
Kamil Tekiela
8015e4de72 Move DatabaseInterface to Dbal
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-22 18:34:53 +00:00
Kamil Tekiela
5a8f01c595 Refactor fetchSingleRow()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-22 00:07:09 +00:00
William Desportes
57a56f1aa7
Merge branch 'QA_5_2'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2024-12-18 03:00:58 +01:00
Maurício Meneghini Fauth
7d6b17a417
Replace sql_query global var with Current::$sqlQuery
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-12-09 13:51:22 -03:00
Kamil Tekiela
039481df30 Create UrlParams::$params
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-11-13 15:32:01 -03:00
Kamil Tekiela
d0f797e50c More refactoring
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-09-28 21:41:57 +01:00
Maurício Meneghini Fauth
70105294ef
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-07-22 15:44:41 -03:00
Maurício Meneghini Fauth
90ee00efd5
Create the 'pma' global variable for Twig templates
Creates the Twig\PmaGlobalVariable class to handle the 'pma' Twig global
variable.

The idea of this global variable is to automatically inject in all
templates some useful information.

For now it only includes `pma.version` to get the phpMyAdmin version
and `pma.text_dir` to get the text direction ('ltr' or 'rtl').

Adding new variables to the `pma` global variable should be done with
caution.

- https://twig.symfony.com/doc/3.x/advanced.html#globals

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-07-09 20:30:48 -03:00
Maurício Meneghini Fauth
725f4b94de
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-06-12 15:58:51 -03:00
Kamil Tekiela
99c4d34db2 Create MessageType enum
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-05-14 16:30:45 +02:00
Kamil Tekiela
24e6089625 Add UiProperty enum
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-05-02 23:01:12 +02:00
Kamil Tekiela
6e8f5b16d0 Create ForeignData
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-04-27 21:31:25 +02:00
Kamil Tekiela
2f3c4d3830 Refactor Operations::getWarningMessagesArray
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-03-23 14:39:05 +01:00
Maurício Meneghini Fauth
42b5a46d05
Extract Config from Sql class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-02-12 19:20:48 -03:00
Maurício Meneghini Fauth
bfc1926cf6
Extract Config from Display\Results class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-02-12 19:09:33 -03:00
Kamil Tekiela
79a68a4349
Add type hints instead of mixed (#18976)
* Remove some empty() statements

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix docbloc

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type hint to getHtmlForOneKey()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to buildColumnCreationStatement()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add return type to fetchByMode()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getCompatibilities()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getDirContent

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getCharLists()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to executeSqlQuery()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to findLineNumberAndColumn

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to lint()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getHtmlForNewTables3NF()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getViewsAndCreateSqlViewStandIn()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getPossibleRowFormat()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getTableAltersArray()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getValuesForColumn()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getAvailableMimeTypes()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add types to TwigLintCommand

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to isRowCountApproximated

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getReplicationStatus()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type in formatVariable()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to fetchSingleRow()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getPages()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to CentralColumns::getParams()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to removeRelation()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getWarnings()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getTableCommentsArray()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix docbloc comment

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to sanitizeUrl()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to uploadProgressSetup()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to explodeMarkup()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add types in Table

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getHtmlForDataStatements()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-02-07 19:19:12 -03:00
Maurício Meneghini Fauth
e9671ea610
Replace StatementInfo class with SqlParser\Utils\StatementInfo
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-02-06 08:07:13 -03:00
Maurício Meneghini Fauth
6aa4bc2e50
Update sql-parser dependency
Adds a quick fix for the sql-parser update.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-02-05 17:18:58 -03:00
Maurício Meneghini Fauth
d36358a818
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-01-30 14:02:14 -03:00
Kamil Tekiela
822ebbfe59 Remove unnecessary parentheses
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-01-12 15:26:31 +01:00
Maurício Meneghini Fauth
18d91ef865
Merge pull request #18869 from kamil-tekiela/getStatusInfo-$disableError
Refactoring getStatusInfo() and Cache
2023-12-30 23:11:45 -03:00
Kamil Tekiela
01aaa90861 Remove $_SESSION['is_multi_query']
It's not clear what this was supposed to do, but it definitely shouldn't be done this way.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-27 14:49:28 +01:00
Maurício Meneghini Fauth
0307babf27
Replace text_dir global var with LanguageManager::$textDir static
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-12-26 16:20:58 -03:00
Maurício Meneghini Fauth
1129750eee
Replace server global with Current::$server
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-12-24 02:08:50 -03:00
Maurício Meneghini Fauth
ef6c30c865
Replace table global var with static class property
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-12-17 15:51:29 -03:00
Maurício Meneghini Fauth
711f6c0f14
Replace db global variable with static class property
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-12-17 14:58:59 -03:00
Kamil Tekiela
0ada2f471a Remove old comment
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-16 02:05:47 +01:00
Kamil Tekiela
d204a758fd Remove $GLOBALS['showtable']
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-15 20:00:31 +01:00
Kamil Tekiela
8e1dd72448 Remove $GLOBALS['find_real_end']
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-15 19:55:15 +01:00
Kamil Tekiela
906bf77789 Remove unused parameters
This is a mistake on my part. I committed this without checking.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-02 00:52:48 +01:00
Kamil Tekiela
e29fe59597 Introduce getProfilingChart()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-02 00:39:34 +01:00
Kamil Tekiela
51f9c749ad Simplify code
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-11-28 14:42:37 +01:00
Maurício Meneghini Fauth
582809d589
Move Table class into Table namespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-11-15 16:09:42 -03:00
Maurício Meneghini Fauth
dd5f087aa5
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-10-03 17:31:12 -03:00
Kamil Tekiela
e06fad7b4f Remove sanitize method
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-10-01 22:03:09 +01:00
Kamil Tekiela
1ee285cadd Refactor static into instance
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-09-22 19:36:35 +01:00
Kamil Tekiela
ee6489722e Create BookmarkRepository class
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-09-22 14:59:59 +01:00