Maurício Meneghini Fauth
faded196d7
Remove the no_constraints_comments global variable
...
Replaces it with ExportSql::$noConstraintsComments static property.
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-01-10 16:37:00 -03:00
Maurício Meneghini Fauth
aad57a864b
Remove the asfile global variable
...
Replaces it with Export::$asFile static property.
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-01-08 00:27:45 -03:00
Maurício Meneghini Fauth
38f42dab62
Merge pull request #19470 from kamil-tekiela/getColumnsFull
...
Remove DatabaseInterface::getColumnsFull()
2024-12-25 11:53:10 -03:00
Maurício Meneghini Fauth
03d9afc33f
Replace message global with Current::$message prop
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-12-23 19:09:46 -03:00
Kamil Tekiela
f6a0e931c9
Refactor getNameAndTypeOfTheColumns
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-23 17:32:23 +00:00
Kamil Tekiela
f09d805d28
Remove $column param
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-23 17:23:11 +00:00
Kamil Tekiela
8015e4de72
Move DatabaseInterface to Dbal
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-22 18:34:53 +00:00
Kamil Tekiela
a07292ecc1
Small changes
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-22 00:07:09 +00:00
Kamil Tekiela
5a8f01c595
Refactor fetchSingleRow()
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-22 00:07:09 +00:00
Kamil Tekiela
319ae0d2e3
Split off fetchResultSimple
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-22 00:04:18 +00:00
Maurício Meneghini Fauth
c30bc4ddcc
Merge pull request #19464 from MauricioFauth/export-globals
...
Remove some global variables from export plugins
2024-12-21 15:12:41 -03:00
Maurício Meneghini Fauth
75d11f910b
Remove sql_* global variables
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-12-20 19:42:52 -03:00
Kamil Tekiela
d950ad8949
Fix type hints
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-18 15:09:43 +00:00
Kamil Tekiela
cbdaff3356
Fix type hints
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-18 15:09:43 +00:00
Kamil Tekiela
fb130367a0
Fix type hints
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-18 15:09:43 +00:00
Kamil Tekiela
eaa9f2d051
Fix type hints
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-18 15:09:41 +00:00
Maurício Meneghini Fauth
ddc64a4f3e
Merge pull request #19450 from kamil-tekiela/Removal-of-some-dead-GLOBALS
...
Removal of some dead globals
2024-12-17 11:30:16 -03:00
Kamil Tekiela
873a743aaa
Localize $GLOBALS['mime_map']
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-16 01:34:30 +00:00
Maurício Meneghini Fauth
f9d5612f6b
Remove sql_dates global variable
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-12-14 17:46:13 -03:00
Kamil Tekiela
24fba67ccd
Create ExportType enum
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-14 00:34:12 +00:00
Kamil Tekiela
dce24cca42
Make parameters a primitive type
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-13 23:19:53 +00:00
Kamil Tekiela
ce016798f9
Remove all unnecessary $GLOBALS['errorUrl']
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-12-12 23:05:34 +00:00
Maurício Meneghini Fauth
7d6b17a417
Replace sql_query global var with Current::$sqlQuery
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-12-09 13:51:22 -03:00
Maurício Meneghini Fauth
d8f0c402ad
Merge pull request #19346 from kamil-tekiela/getReservedColumnNames
...
Drop getReservedColumnNames()
2024-10-31 17:28:44 -03:00
Maurício Meneghini Fauth
fabf58df27
Merge branch 'QA_5_2'
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-10-31 17:21:13 -03:00
Kamil Tekiela
0c84b630a4
Drop getReservedColumnNames()
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-10-30 19:29:02 +00:00
Liviu-Mihail Concioiu
6b8a93e114
Fix add primary key from More drop down
...
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2024-10-29 22:06:35 +01:00
Kamil Tekiela
625dcf215a
Split up getForeignKeysData from getForeigners
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-09-28 14:48:44 +01:00
Kamil Tekiela
ec977df5cd
ForeignerKey
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-09-24 18:35:32 +01:00
Kamil Tekiela
70f7682425
Add native true type
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-08-16 11:56:22 +02:00
Maurício Meneghini Fauth
dc1bd60dd1
Fix boolean usage of the return value of preg_match()
...
preg_match() and preg_match_all() returns the number of pattern matches
(which might be zero), or false on failure. However, preg_match() always
returns 1 when a pattern is matched as it stops searching after the
first match.
- https://www.php.net/manual/en/function.preg-match.php
- https://www.php.net/manual/en/function.preg-match-all.php
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-07-13 14:43:05 -03:00
Maurício Meneghini Fauth
cd62509cb3
Make AddKeyController extends AbstractIndexController
...
Refactors Table\Structure\AddKeyController class to extends
Table\Structure\AbstractIndexController and to remove the dependency on
the Sql\SqlController class.
This helps with the response handling.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-22 12:18:07 -03:00
Maurício Meneghini Fauth
c6c9aeb678
Merge #19124 - Refactoring move copy
...
The goal of this was to partition the big method into smaller easier to
understand chunks and get rid of globals. This code is still far from
perfect but I have no idea how to proceed further right now.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-05-10 11:13:57 -03:00
Kamil Tekiela
24e6089625
Add UiProperty enum
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-05-02 23:01:12 +02:00
Kamil Tekiela
c14efeb924
Wrap long line
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-04-23 00:48:23 +02:00
Kamil Tekiela
ac3f68d27c
Fix comment
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-04-22 23:52:45 +02:00
Kamil Tekiela
fe6300f325
Use public property $sqlConstraintsQuery instead of global
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-04-22 23:50:08 +02:00
Kamil Tekiela
34caf80af1
Replace $GLOBALS with public properties
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-04-22 23:35:46 +02:00
Kamil Tekiela
bb37e649b9
Fix unit tests
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-04-22 22:56:33 +02:00
Kamil Tekiela
d381057f0b
Move getRelationParameters() to its right place
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-04-22 21:56:52 +02:00
Kamil Tekiela
b6da9bbd5a
Fix global value
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-04-22 21:56:52 +02:00
Kamil Tekiela
cb80c51a39
Extract handleStructureCreation()
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-04-22 21:56:52 +02:00
Kamil Tekiela
ae8d2dac79
Extract copyData()
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-04-22 21:56:52 +02:00
Kamil Tekiela
d103ff8db0
Extract dropOldStructure()
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-04-22 21:56:52 +02:00
Kamil Tekiela
b2fbc55ff2
Make TableMover non-static
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-04-22 21:56:52 +02:00
Kamil Tekiela
14afc6c815
Carve out executeAlterAutoIncrement()
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-04-22 21:52:44 +02:00
Kamil Tekiela
c3d8e508c8
Carve out createIndexes()
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-04-22 21:52:44 +02:00
Kamil Tekiela
0511e604e1
Carve out executeDropIfExists()
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-04-22 21:52:44 +02:00
Kamil Tekiela
1a824c1fb8
Carve out createNewStructure()
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-04-22 21:52:44 +02:00
Kamil Tekiela
a3436e4117
Merge $move into MoveScope
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-04-22 21:52:44 +02:00