gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
136,124 Commits 12 Branches 481 Tags 2.4 GiB
c2e27e1697
Commit Graph

17 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
9c576fcc9c
Refactor Twig extensions to use Twig's AttributeExtension 
This allows to remove most extensions.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-07-08 13:23:34 -03:00
Maurício Meneghini Fauth
e7765efd63
Make some comparisons stricter 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-07-06 15:44:31 -03:00
Maurício Meneghini Fauth
37cbc4b3f3
Extract dependencies from Transformations class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
 2025-06-21 14:39:37 -03:00
Kamil Tekiela
0797f9c44b Rector: small improvements 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-06-11 14:43:20 +01:00
Kamil Tekiela
371eb78ce1 Fix type hint 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-16 22:20:11 +00:00
Kamil Tekiela
21c8329718 Make code easier to read 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2025-01-16 22:15:58 +00:00
Kamil Tekiela
8015e4de72 Move DatabaseInterface to Dbal 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-12-22 18:34:53 +00:00
Maurício Meneghini Fauth
a97cca5f39
Replace static variables with static class properties 
Static variables are better suitable for standalone functions. For
methods, static properties are better because they are easier to handle.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2024-07-17 22:24:06 -03:00
Maurício Meneghini Fauth
dc1bd60dd1
Fix boolean usage of the return value of preg_match() 
preg_match() and preg_match_all() returns the number of pattern matches
(which might be zero), or false on failure. However, preg_match() always
returns 1 when a pattern is matched as it stops searching after the
first match.

- https://www.php.net/manual/en/function.preg-match.php
- https://www.php.net/manual/en/function.preg-match-all.php

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2024-07-13 14:43:05 -03:00
Kamil Tekiela
0c7c968104 Refactor Transformation plugin instantiation 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-03-12 17:15:37 +01:00
Kamil Tekiela
8e4443b17b
Applying suggestions from static analysis tools (#19013) 
* Drop array keys from lists

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Import UrlTest

When it doesn't exist in Prod, the code will still work the same.
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Drop redundant return [];

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix object access checks

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use strict comparison

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Int keys should be specified as integers

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use empty string check instead of strlen

Potential null deprecations are replaced with loose condition.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use stripos instead of *substr

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify substr's 3rd param

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove unnecessary defaults

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace isZeroBasedArray with array_is_list

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify texEscape()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify exportZeroBasedArray()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace for loop with array_diff

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace for with foreach

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove nullable param in backquoteCompat

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use null-coalescing operator

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Inline $result variable

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Turn $event into a constant

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Move selectDb outside the loop

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix code style order of operation

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove unnecessary isset argument

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove line break

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use foreach instead of for

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-02-27 12:29:02 -03:00
Kamil Tekiela
79a68a4349
Add type hints instead of mixed (#18976) 
* Remove some empty() statements

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix docbloc

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type hint to getHtmlForOneKey()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to buildColumnCreationStatement()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add return type to fetchByMode()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getCompatibilities()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getDirContent

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getCharLists()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to executeSqlQuery()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to findLineNumberAndColumn

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to lint()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getHtmlForNewTables3NF()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getViewsAndCreateSqlViewStandIn()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getPossibleRowFormat()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getTableAltersArray()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getValuesForColumn()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getAvailableMimeTypes()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add types to TwigLintCommand

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to isRowCountApproximated

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getReplicationStatus()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type in formatVariable()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to fetchSingleRow()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getPages()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to CentralColumns::getParams()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to removeRelation()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getWarnings()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getTableCommentsArray()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix docbloc comment

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to sanitizeUrl()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to uploadProgressSetup()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to explodeMarkup()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add types in Table

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getHtmlForDataStatements()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-02-07 19:19:12 -03:00
Maurício Meneghini Fauth
3353b47721
Create ConnectionType enum 
Replaces Connection::TYPE_* constants with ConnectionType enum.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2024-01-29 12:47:15 -03:00
Kamil Tekiela
822ebbfe59 Remove unnecessary parentheses 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2024-01-12 15:26:31 +01:00
Kamil Tekiela
a6bca696b5 Replace escapeString in Transformations 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-09-08 11:19:54 +01:00
Maurício Meneghini Fauth
1ddcad2bfb
Replace libraries/classes references with src 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-08-30 15:59:29 -03:00
Maurício Meneghini Fauth
c2955cc2b2
Rename the directory libraries/classes/ to src/ 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-08-30 15:59:28 -03:00