Commit Graph

22 Commits

Author SHA1 Message Date
Kamil Tekiela
fb2953c487 Force string as return type of showCreate()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-07-24 19:45:24 +01:00
William Desportes
8b4a158a1b
Ref #16005 - Remove loading on each request favorites and recents
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-07-14 17:47:30 +02:00
William Desportes
007036765f
Fix #17443 - stop reloading the navigation tree if nothing changed
Fixes: #17443
Ref: ca54f1db05

Git bisect seems to say that ca54f1db05 is the first bad commit
And it is, in fact the `fixPmaTables` function was called with the request DB and so the code had 99.9% chance to NOT hit `$GLOBALS['reload'] = true;` since the clicked DB had no phpMyAdmin tables.
But now, it always targets first the phpmyadmin configured DB and so always does hit the reload, causing the panel to always reload

Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-07-14 17:47:28 +02:00
William Desportes
4cec0f1163
Stop pmadb database detection when all features are disabled
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-04-08 13:42:44 +02:00
Kamil Tekiela
e7717ed186 Fix bug preventing disabling tracking feature
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-04-03 12:22:31 +01:00
Rodrigo Pokemaobr
5a57873744 Removing types from in RelationExtension for avoid null error on global
Signed-off-by: Rodrigo Pokemaobr <contato@pokemaobr.dev>
2022-05-17 15:11:46 -03:00
Maurício Meneghini Fauth
1faab7119d
Fix bug when renaming tables with config storage enabled
Fixes https://github.com/phpmyadmin/phpmyadmin/issues/17359

Introduced by https://github.com/phpmyadmin/phpmyadmin/pull/17256

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-09 13:58:35 -03:00
Isaac Bennetch
985912f58f Fix merge conflicts from security branch
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2022-01-20 12:28:17 -05:00
Maurício Meneghini Fauth
9b3a1f7734
Merge branch 'QA_5_1-security' into master-security
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-01-13 17:41:16 -03:00
Kamil Tekiela
a4b2d7e524 Deimplement fetchRow() helper
This helper isn't needed anymore.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-01-09 22:44:53 +00:00
Kamil Tekiela
f5bb90ebb9 Move queryAsControlUser - Dbal refactoring pt.3
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-01-06 19:31:27 +00:00
Kamil Tekiela
83b4dda1a3 Change QUERY_STORE to QUERY_BUFFERED
Set the value to 0 instead of 1 and remove all unnecessary usages of this constant

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-01-01 01:46:01 +00:00
Kamil Tekiela
47a039d70c Implement ResultInterface & MysqliResult
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2021-12-31 23:59:24 +00:00
Maurício Meneghini Fauth
d84af02945
Create VO classes for each RelationParameters features
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-26 19:17:58 -03:00
Maurício Meneghini Fauth
4e0141e19f
Merge pull request #17253 from kamil-tekiela/fetchValue
Remove $row_number from DatabaseInterface::fetchValue
2021-12-23 11:40:25 -03:00
Maurício Meneghini Fauth
44fe103b9c
Remove @access annotations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-22 11:43:45 -03:00
Kamil Tekiela
70c86f5e21 Remove $row_number from DatabaseInterface::fetchValue
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2021-12-21 21:09:38 +00:00
Maurício Meneghini Fauth
42e4dd519e
Refactor Relation::getRelationParameters method
Makes checkRelationsParam method private.
Saves 'relation' to Session from RelationParameters class

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-17 12:09:14 -03:00
Maurício Meneghini Fauth
ce18740be4
Remove passing null to Relation's constructor
Related to d296860a67.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-17 12:09:14 -03:00
Maurício Meneghini Fauth
aaee7961c1
Remove Template dependency from Relation class
Related to 2299a62e49.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-17 12:09:14 -03:00
Maurício Meneghini Fauth
995ec44d13
Move DatabaseInterface::initRelationParamsCache method to Relation class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-17 12:09:13 -03:00
Maurício Meneghini Fauth
c411121fd8
Move Relation classes into the ConfigStorage namespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-17 12:09:13 -03:00