Commit Graph

1146 Commits

Author SHA1 Message Date
Liviu-Mihail Concioiu
81f550c693 Fix syntax error
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2025-09-22 17:35:23 +02:00
Liviu-Mihail Concioiu
b5fb37b939
Fix #19570 - Check for HTTP_HOST and document the issue in FAQ (#19858)
Fixes #19570

* Check for HTTP_HOST and document the issue in FAQ

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>

* Remove whitespace

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>

* Update libraries/classes/Controllers/HomeController.php

Co-authored-by: William Desportes <williamdes@wdes.fr>

---------

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
Co-authored-by: William Desportes <williamdes@wdes.fr>
2025-09-14 16:00:21 -03:00
Pin-Yi Song
5496edd11d
style: phpcs fix.
Signed-off-by: Pin-Yi Song <611077101@mail.nknu.edu.tw>
2025-08-05 22:57:50 +08:00
Pin-Yi Song
221ba2eeb3
fix: add the ignore condition.
Signed-off-by: Pin-Yi Song <611077101@mail.nknu.edu.tw>
2025-08-05 22:57:50 +08:00
Maximilian Krög
0c6d29358a
Fix move column for table with foreign key
Signed-off-by: Maximilian Krög <maximilian.kroeg@geocept.com>
2025-07-09 16:41:57 +02:00
Maximilian Krög
56beb41ac6
Make gis visualization work with huge tables
The query was executed without a limit clause but only the meta data
was read, so adding a 'limit 0' clause is a big improvement for big tables.

Signed-off-by: Maximilian Krög <maximilian.kroeg@geocept.com>
2025-04-30 15:22:35 +02:00
Maurício Meneghini Fauth
92efecc7f6
Add SQL parse error message when simulating DML
Fixes https://github.com/phpmyadmin/phpmyadmin/issues/18903

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-04-21 22:37:38 -03:00
Liviu-Mihail Concioiu
fc67cb4532
Implement getValuesForCsvTable for CSV table type (#19540)
* Implement getValuesForCsvTable

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>

* Improve code

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>

* Improve code

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>

* Fix phpcs

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>

---------

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2025-03-30 12:10:08 -03:00
Liviu-Mihail Concioiu
d7a52d6d44
Fix #19641 - Allow optional param for NOW (#19642)
* Allow optional param for NOW

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>

* Fix phpcs

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>

* Improve precision check

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>

* Validate NOW precision

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>

---------

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2025-03-27 18:29:01 -03:00
Maurício Meneghini Fauth
e6f08a8682 Ignore ISO-2022-CN-EXT charset for iconv
Fixes possible glibc/iconv vulnerability (CVE-2024-2961).

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-01-20 14:14:17 -05:00
Maurício Meneghini Fauth
cf886df108 Ignore system databases when deleting using UI
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2025-01-20 13:08:55 -05:00
William Desportes
4d51855d67
Fix #18129 - PHP warning while editting a view definition
Signed-off-by: William Desportes <williamdes@wdes.fr>
2025-01-16 02:56:56 +01:00
Maurício Meneghini Fauth
8b38f49efa
Merge pull request #19520 from kamil-tekiela/Avoid-passing-null-to-synchronizeFavoriteTables
Avoid passing null to synchronizeFavoriteTables
2025-01-14 16:17:51 -03:00
Kamil Tekiela
5e1356f85f Avoid passing null to synchronizeFavoriteTables
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2025-01-14 17:22:39 +00:00
Liviu-Mihail Concioiu
de4a193fe6 Fix table detected as view
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2024-12-15 15:08:57 +01:00
Maurício Meneghini Fauth
f6ce169290
Fix issue when updating privs for various databases
The sql_query global variable should be a string, and it can be a string
in this case, which will cause an error as the string will not be
converted to array.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-11-05 15:09:21 -03:00
Maurício Meneghini Fauth
12efd0a0fe
Replace replication statements with new terminology
SHOW MASTER LOGS was removed in MySQL 8.4.0 and SHOW BINARY LOGS is
available since MySQL 4.1.1.

As of MySQL 8.2.0, SHOW BINARY LOG STATUS is available.
As of MariaDB 10.5.2, SHOW BINLOG STATUS is available.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
2024-10-31 13:50:11 -03:00
Maurício Meneghini Fauth
587d185bb7
Validate *_structure_or_data param when exporting
- Fixes #19213

This is not the best fix, but will avoid generating an invalid file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-07-18 16:07:46 -03:00
Maurício Meneghini Fauth
4f67631d48
Fix undefined variables in table/zoom_search/result_form.twig
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-06-22 17:34:21 -03:00
Maximilian Krög
3b84890770
Fix simulating query with -- comment
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2024-06-01 00:58:42 +02:00
Maximilian Krög
6d917b5b7f
Fix simulate multiple queries with ; in a string
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2024-06-01 00:16:35 +02:00
Faissal Wahabali
de7a96467f
Fix notification links (#18243)
* fix not working notification copy link

Signed-off-by: faissaloux <fwahabali@gmail.com>

* fix not working notification links

Signed-off-by: faissaloux <fwahabali@gmail.com>

* fix notification links tooltip messages

Signed-off-by: faissaloux <fwahabali@gmail.com>

* update Edit Query message

Signed-off-by: faissaloux <fwahabali@gmail.com>

* remove unused event param

Signed-off-by: faissaloux <fwahabali@gmail.com>

* refactor

Signed-off-by: faissaloux <fwahabali@gmail.com>

* revert Edit Query message

Signed-off-by: faissaloux <fwahabali@gmail.com>

* refactor

Signed-off-by: faissaloux <fwahabali@gmail.com>

* code style

Signed-off-by: faissaloux <fwahabali@gmail.com>

* refactor

Signed-off-by: faissaloux <fwahabali@gmail.com>

---------

Signed-off-by: faissaloux <fwahabali@gmail.com>



Fixes #18241

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-04-30 16:08:56 -03:00
Mattia Rizzolo
3dfaed3554
Fix inverted logic hide serverlist (#18021)
* Reflow lines to arguably better understand the logic

There are a bit too many branch in this single line..

Signed-off-by: Mattia Rizzolo <mattia@mapreri.org>

* Fix inverted logic in the serverlist in the home page

Here the server list was visible when it wasn't supposed to be, and
hidden when it was supposed to be visible.

Signed-off-by: Mattia Rizzolo <mattia@mapreri.org>

---------

Signed-off-by: Mattia Rizzolo <mattia@mapreri.org>

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-04-29 21:21:36 -03:00
William Desportes
892dda0f04
Fix #19041 - footer.twig gets printed to Binary File Download
Signed-off-by: William Desportes <williamdes@wdes.fr>
2024-04-28 17:18:43 +02:00
William Desportes
0bcc3e402d
Merge #19105 - Fix #17920, Fix #18006, Fix #18962 - Preserve check constraint during column move
Pull-request: #19105
Fixes: #17920
Fixes: #18006
Fixes: #18962

Signed-off-by: William Desportes <williamdes@wdes.fr>
2024-04-28 10:46:15 +02:00
William Desportes
40d5b6dd57
Merge #19135 - Fix #18389, Fix #18487, Fix #18511 - Fix linter for sql query box with multiple statements
Pull-request: #19121
Fixes: #18389
Fixes: #18487
Fixes: #18511

Signed-off-by: William Desportes <williamdes@wdes.fr>
2024-04-28 10:37:57 +02:00
Maximilian Krög
d5e0d711bd
Fix linter annotations for special editors
When the sql string to lint isa changed, the result positions
need to be adjusted accordingly.

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2024-04-22 21:42:36 +02:00
Maximilian Krög
02ebd6c5b0
Fix linting in sql editor with delimiter
Always setting the delimiter to $$ is not right in normal sql editor.
This breaks usage of the default delimiter ; and using DELIMITER in the sql.

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2024-04-21 16:01:26 +02:00
Maximilian Krög
26fc8f1b9e
Fix editing column where only virtuality changed
Without this the column wasn't detected as changed and thus not
included in the alter statement.

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2024-04-21 15:30:31 +02:00
Maximilian Krög
3b992e6a13
Preserve check constraint during column move
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2024-04-19 22:01:43 +02:00
Peter de Kraker
10a8943cfc
Add RocksDB support
Signed-off-by: Peter de Kraker <peterdekraker@umito.nl>
2024-03-15 20:13:58 -03:00
Maurício Meneghini Fauth
2b1f21ef07
Remove unused parameter from Table\StructureController::displayStructure
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-02-21 21:05:48 -03:00
Maurício Meneghini Fauth
4d20a8b7e3 Change error message link in ChangeLogController
Uses URL redirector instead of a direct link in the error message.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-01-04 19:00:27 -03:00
Kamil Tekiela
7652f018aa Fix #17538 Index Rename Button generated incorrect sql
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-28 00:25:10 +01:00
Maurício Meneghini Fauth
6503321278
Fix case where column hash is empty in table relation page
- Fixes #18834
- Related to #14305

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-12-08 16:57:12 -03:00
Liviu-Mihail Concioiu
bd9aa34013 Adds missing dot in translations
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2023-12-03 00:36:12 +02:00
Maurício Meneghini Fauth
99168688a7
Add ChangeLog entry for #15670
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-11-17 13:15:38 -03:00
Bram Stokman
d2c153d557
Update Table SaveController.php - bug fix (#18724)
* Update SaveController.php - bug fix

Fix for possible truncation of data upon changing a MEDIUMTEXT or LONGTEXT column's collation when their content exceeds the length a BLOB column can hold.

* Update SaveController.php - bug fix

Signed-off-by: Bram Stokman <marbbom@hotmail.com>

* Fixed spacing

Signed-off-by: Bram Stokman <marbbom@hotmail.com>

---------

Signed-off-by: Bram Stokman <marbbom@hotmail.com>
2023-11-17 12:38:40 -03:00
Maurício Meneghini Fauth
5cba58c82e
Fix truncate operation in EmptyTableController
- Fixes https://github.com/phpmyadmin/phpmyadmin/issues/18762

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-11-12 15:05:35 -03:00
Maurício Meneghini Fauth
5c7e84047e
Merge pull request #18693 from kamil-tekiela/parseEnumSetValues_52
Fix enum/set value escaping
2023-10-03 16:54:56 -03:00
Maurício Meneghini Fauth
5e8ec69240
Improve git hash info error handling in home.js
Instead of showing a generic error message alert when an error occurs,
it displays an error message at the same place where the success output
goes.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-09-20 14:14:28 -03:00
Maurício Meneghini Fauth
b06c773360
Merge pull request #18713 from MoonE/fix-column-type-lost
Fix gis editor changing geometry type and opening in search views
2023-09-20 11:22:26 -03:00
Kamil Tekiela
dba0086b90 Fix AJAX real-row-count
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-09-15 21:01:15 +01:00
Maximilian Krög
4bd6a2dd52
Fix opening GIS editor in zoom search
The editor couldn't be opened there at all

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2023-09-15 00:36:02 +02:00
Maximilian Krög
5128da0071
Remember the current column type
After switching the geometry type once the geometry select disappeared.

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2023-09-14 22:58:23 +02:00
Kamil Tekiela
94eee04d50 Remove htmlentities()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-09-05 18:12:38 +01:00
Maximilian Krög
3786b40499
Geometry type selection only for Geometry column type
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2023-08-26 21:59:06 +02:00
Maximilian Krög
62db67a47c
Show affected rows instead of matched rows in SimulateDml
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2023-08-26 21:35:44 +02:00
William Desportes
7c975030b9
Fix #18592 - Remove instruction to remove the pma_collation_connection cookie removed in 4.8.0
Ref: 3b6a994dcd
Fixes: #18592

Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-08-03 15:00:19 +02:00
Kamil Tekiela
fb2953c487 Force string as return type of showCreate()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-07-24 19:45:24 +01:00