Michal Čihař
27fb0b58af
Merge branch 'QA_4_6'
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-01-23 14:07:29 +01:00
Michal Čihař
e4bf536906
Update to SQL Parser 4.0.1
...
It now follows PSR-4 and uses PhpMyAdmin namespace prefix.
See https://github.com/phpmyadmin/sql-parser/issues/126
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-01-23 13:56:35 +01:00
Isaac Bennetch
77c33d0444
Rename Relations to Relationships in many places; Fixes issue #12536
...
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2017-01-13 18:20:30 -05:00
Michal Čihař
9772df3518
Merge branch 'QA_4_6'
2016-12-01 11:49:37 +01:00
Michal Čihař
e61b2135da
Fixed SQL export with newlines
...
Remove manual escaping where we do proper escaping through MySQL
extension.
Fixes #12765
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-12-01 11:02:04 +01:00
Michal Čihař
dad93483c1
Merge branch 'QA_4_6'
2016-11-10 11:08:36 +01:00
Deven Bansod
f14cffdbe7
Properly escape strings in MySQL statement values
...
Use *_real_escape string functions provided by connectors to escape strings while exporting
Fix #12453
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
Conflicts:
libraries/server_privileges.lib.php
2016-10-29 10:45:12 +05:30
Deven Bansod
c00cf34886
Use IF EXISTS with DROP Database while exporting to prevent error while importing this dump
...
Fix #12634
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2016-10-14 10:00:50 +05:30
Deven Bansod
6ed1da5a45
Merge branch 'QA_4_6'
2016-10-14 09:59:32 +05:30
Deven Bansod
41b07b2009
Use IF EXISTS with DROP Database to prevent error while importing
...
Fix #12634
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2016-10-14 09:54:50 +05:30
Michal Čihař
205694982b
Fix exporting multiline comments
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-13 12:16:50 +02:00
Michal Čihař
7b3dc673d2
Fix exporting multiline comments
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-13 12:12:26 +02:00
Michal Čihař
f0ad030460
Merge branch 'QA_4_6-security' into master-security
2016-07-13 10:34:31 +02:00
Michal Čihař
dc52930bba
Properly handle newlines in SQL comments
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-13 09:59:39 +02:00
Michal Čihař
c2ca1c8c22
Merge branch 'QA_4_6-security' into master-security
2016-07-12 16:58:46 +02:00
Michal Čihař
80b03a4f16
Ensure page number is integer
...
Even if somebody decides to change configuration storage structure.
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-12 16:57:35 +02:00
Michal Čihař
637d4eb4de
Merge branch 'QA_4_6-security' into master-security
2016-06-20 17:35:46 +02:00
Michal Čihař
1cc7466db3
Quote delimiter before using preg_replace
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-06-20 12:16:03 +02:00
Michal Čihař
0b2b23f2ce
Merge branch 'QA_4_6'
2016-06-08 14:00:26 +02:00
Michal Čihař
d7fcbab1cd
Ensure we parse query for views as well
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-06-08 14:00:04 +02:00
Michal Čihař
8a494f26d2
Merge branch 'QA_4_6'
2016-06-03 14:42:07 +02:00
Michal Čihař
b49030528f
Fixed export of tables without explicitly set engine
...
Fixes #12290
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-06-03 14:41:55 +02:00
Michal Čihař
9d5c5f0c86
Adjust tests to new error messages
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-05-23 21:27:41 +02:00
Michal Čihař
4cd8ab8a95
Better report errors while generating SQL exports
...
The errors will include table and database name in the dump and the
error is also shown in the UI on next page.
Fixes #5555
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-05-23 17:21:58 +02:00
Michal Čihař
1d1e269144
Merge branch 'QA_4_6'
2016-05-23 15:54:33 +02:00
Michal Čihař
3b374237d6
Fixed export of ARCHIVE tables with keys
...
We can not rewrite the ARCHIVE table as it can not be altered.
Fixes #12082
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-05-23 15:54:26 +02:00
Michal Čihař
a2b8bfc308
Merge branch 'QA_4_6'
2016-05-17 10:50:16 +02:00
Michal Čihař
b0f8511e60
Use https for links to www.phpmyadmin.net
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-05-17 10:49:21 +02:00
Michal Čihař
aaa707ab4d
Merge branch 'QA_4_6'
2016-05-17 10:18:52 +02:00
Michal Čihař
11089cbe41
Use https for links to dev.mysql.com
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-05-17 10:16:44 +02:00
Michal Čihař
e2deac4b22
Move getting collation to the DBI layer
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-04-11 11:42:29 +02:00
Michal Čihař
cd4008b3d7
Move MySQL charset maps to separate class
...
This allows us to load it only when needed
Issue #11731
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-04-11 10:33:40 +02:00
Michal Čihař
1580d2fa4d
Fixed SQL quoting in SQL export
...
The fix for 4.5 branch was wrongly merged here.
Fixes #12029
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-04-05 10:05:22 +02:00
Michal Čihař
1b43606a48
Fixed possible invalid SQL export
...
We should emit the charset restoration only if we have emitted its
setting in the header. As the condition was slightly different in both
cases it was possible that only one part of these two was emitted in
past.
Fixes #12074
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-03-18 10:34:17 +01:00
Michal Čihař
33f0b947db
Merge branch 'QA_4_5' into QA_4_6
2016-02-25 12:30:42 +01:00
Michal Čihař
67b681d63e
Merge branch 'QA_4_5' into QA_4_6
2016-02-16 10:21:07 +01:00
Dan Ungureanu
c6b3292fe5
Merge branch 'QA_4_5' into QA_4_6
2016-02-12 09:39:01 +02:00
Michal Čihař
628b19283d
Fix spacing of docstrings
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-05 16:40:44 +01:00
Michal Čihař
ca59f5046c
Use new contructor for Group() objects
...
This safes us next calls to setName and setText.
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-05 15:26:52 +01:00
Michal Čihař
4975ef2bc2
Use new constructor for Item() objects
...
This allows to directly set name and text.
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-05 15:04:02 +01:00
Michal Čihař
1168ed61b4
Share code for routines export
...
The exporting of functions and procedures is almost same.
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-05 13:06:28 +01:00
Michal Čihař
c660edd057
Simplify code by removing parallel if statements
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-05 12:53:18 +01:00
Michal Čihař
f4eb1a9b4f
There is no need to reset() before foreach()
...
The code is there since past when PHP 4 was still supported reset was
necessary.
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-05 11:26:34 +01:00
Michal Čihař
55b317c699
Remove /*overload*/ prefix from mb_* calls
...
I believe this was temporary flagging to see which code is migrated and
can be safely removed now.
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-04 16:35:28 +01:00
Hugues Peccatte
8baf7c4a8a
Update PHPDoc.
...
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-12-11 23:21:54 +01:00
Madhura Jayaratne
fd0f3d4264
Merge branch 'QA_4_5'
2015-12-11 16:29:12 +11:00
Marc Delisle
2f2b505a2e
Fixes ##11711 Clarify the meaning of "Stand-in structure for view" in SQL export
...
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-12-02 10:44:14 -05:00
Marc Delisle
80f079e525
Clarify message because a table name can be the same as a database name
...
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-11-17 08:14:36 -05:00
Marc Delisle
06a4c57da1
Remove dead code
...
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-11-09 05:39:17 -08:00
Hugues Peccatte
e1dd0a9f97
Make PHPCS happy.
...
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-10-18 22:51:01 +02:00