Commit Graph

123 Commits

Author SHA1 Message Date
Michal Čihař
308c9d7951 Simplify Response object handling
- always use use and short name
- avoid calling getInstance() several times in one script

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-12-07 18:17:59 +01:00
Michal Čihař
75a5fde46d Use secure.php.net for PHP documentation links
This avoids unnecessary redirect on the way (I still think this website
setup is weird, but that's all I can do about it).

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-10-18 11:13:24 +02:00
Michal Čihař
31f6d76405 Merge branch 'QA_4_6' 2016-08-24 11:55:10 +02:00
Michal Čihař
48b6dd58d8 Use one code to check external links
There is no good reason to duplicate the check in several places.

Fixes #12479

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-08-24 11:38:03 +02:00
Michal Čihař
360b8e8a11 Merge branch 'master' into master-security 2016-07-28 09:44:08 +02:00
Michal Čihař
d31ff5a1e7 Merge branch 'QA_4_6' into QA_4_6-security 2016-07-28 09:43:26 +02:00
Michal Čihař
a2e6c78fb7 Use https for outbound links where applicable
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-28 09:41:52 +02:00
Michal Čihař
6d8e1d7935 Merge branch 'QA_4_6' 2016-07-28 09:38:08 +02:00
Michal Čihař
257e65ba9f Use https for outbound links where applicable
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-28 09:19:13 +02:00
Michal Čihař
4072c1d29a Use example.com for sample test urls
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-28 09:12:01 +02:00
Michal Čihař
0aa3b23b41 Merge branch 'QA_4_6-security' into master-security 2016-07-26 16:39:59 +02:00
Michal Čihař
77a4d6ed95 Move generator scripts out of the code
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-26 16:39:40 +02:00
Michal Čihař
a7333d7cc7 Merge branch 'QA_4_6-security' into master-security 2016-07-13 11:12:48 +02:00
Michal Čihař
e4be768781 Ensure widht and height are integers
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-13 10:55:07 +02:00
Michal Čihař
dc899d8e75 Ensure widht and height are integers
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-13 10:52:28 +02:00
Michal Čihař
c3310536b2 Ensure widht and height are integers
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-13 10:49:47 +02:00
Michal Čihař
cc6853538c Properly escape error input in the message
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-13 10:46:14 +02:00
Michal Čihař
f00b258749 Merge branch 'QA_4_6-security' into master-security 2016-07-12 14:16:11 +02:00
Michal Čihař
2ef4fe3d84 Use iframe sandbox for rendering HTML in transformation
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-12 14:15:30 +02:00
Michal Čihař
065b876c1a Merge branch 'QA_4_6-security' into master-security 2016-07-12 11:22:37 +02:00
Michal Čihař
2ea0b722d7 Use _blank target instead of invalid _new
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-12 11:22:23 +02:00
Michal Čihař
fb1884295f Merge branch 'QA_4_6-security' into master-security 2016-07-12 11:19:09 +02:00
Michal Čihař
3c06eede3f Add rel="noopener noreferrer" to all target="_blank" links
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-12 11:02:53 +02:00
Michal Čihař
3434c70a51 Merge branch 'QA_4_6-security' into master-security 2016-07-12 10:38:08 +02:00
Michal Čihař
0bf21ebf72 Use whitelist rather than blacklist for URL filtering
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-12 10:37:25 +02:00
Michal Čihař
c3f7aa8190 Merge branch 'QA_4_6-security' into master-security 2016-06-22 13:29:13 +02:00
Michal Čihař
615212a14d Do not allow javascript: links in transformation
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-06-22 13:28:07 +02:00
Michal Čihař
791bdafcdd Merge branch 'QA_4_6-security' into master-security 2016-06-17 16:24:39 +02:00
Michal Čihař
be3ecbb4cc Simplify and cleanup transformation plugins
Remove PMA_transformation_global_html_replace which makes the code only
more confusing.

Also add escaping to browse transformations.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-06-17 16:18:13 +02:00
Michal Čihař
44a6ae9b50 Use https when linking to php.net
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-05-17 10:13:16 +02:00
Michal Čihař
daf5b0d329 Use php.net to link to their website
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-04-18 17:11:15 +02:00
Michal Čihař
55b317c699 Remove /*overload*/ prefix from mb_* calls
I believe this was temporary flagging to see which code is migrated and
can be safely removed now.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-04 16:35:28 +01:00
Hugues Peccatte
154a942145 Remove side effects in declaration files.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-10-27 18:56:40 +01:00
Hugues Peccatte
e1dd0a9f97 Make PHPCS happy.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-10-18 22:51:01 +02:00
Hugues Peccatte
09f87f4770 Make PHPCS happy.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-10-07 22:09:55 +02:00
Hugues Peccatte
e81234d142 Fix typo in class name.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-30 21:54:17 +02:00
Hugues Peccatte
8c289e523b Revert transformation classes rename.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-12 21:48:43 +02:00
Hugues Peccatte
99633d238a Fix wrong case in files.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-12 15:01:59 +02:00
Hugues Peccatte
857c8a92cf Move abstract transformation plugins to abs folder.
Update templates.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-12 14:13:31 +02:00
Hugues Peccatte
178a6edd38 Add namespace on part of plugins classes.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-05 00:33:42 +02:00
Hugues Peccatte
f0ba28fc1d Set namespace on Advisor, Config, Console and Util classes.
Set namespace on DbQbe.
Set namespace to 'DbSearch'.
Split Advisor.class.php file.
Change Advisor namespace.
Rename DbQbe class and file.
Set namespace on DisplayResults.
Set namespace on Error.
Use namespace for ErrorHandler.
Add class autoloader.
Change ErrorHandler filename.
Remove some require.
Update Config namespace path.
Update PMA_Util to PMA\libraries\Util.
Rename Font and File classes files.
Use namespace for Footer.
Set namespace in all libraries classes.
Namespace OutputBuffering.
Export SubPartition.
Rename Partition file.
Namespace PDF.
Namespace RecentFavoriteTable.
Replace PMA_Response by Response and PMA_Message by Message.
Update uses and calls.
Fix unit tests.
Fix SqlParser autoload.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:22:52 +02:00
Dan Ungureanu
91b97fadc2 Remove unneeded closing tags.
Signed-off-by: Dan Ungureanu <udan1107@gmail.com>
2015-07-19 00:18:38 +03:00
Dan Ungureanu
19cdd09c08 Removed dead code.
Signed-off-by: Dan Ungureanu <udan1107@gmail.com>
2015-07-10 23:18:18 +03:00
Marc Delisle
ce3d41fb4c Use uppercase for column type
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-05-01 07:28:23 -04:00
Madhura Jayaratne
09b5c4399e Add missing doc comments
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-04-28 07:17:06 +05:30
Madhura Jayaratne
7950b63ce0 Merge branch 'QA_4_4'
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-04-23 19:26:28 +05:30
Madhura Jayaratne
3d3e0ece6c Avoid filling up error log with info level messages
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-04-23 19:23:12 +05:30
Madhura Jayaratne
cacafa8e88 Use lower case names
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-04-20 17:26:00 +05:30
Madhura Jayaratne
6b81b3925d align
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-04-20 15:37:03 +05:30
Madhura Jayaratne
2e48c6f1f5 Pass additional variables to input transformations
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-04-20 15:33:04 +05:30