Commit Graph

48 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
1c084de30b
Fix coding standard errors
Related to 62f142c9fa.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-03 16:50:33 -03:00
Maurício Meneghini Fauth
e376c4189b
Remove the .pma-fieldset from some pages
Replaces with Bootstrap's cards

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-27 18:18:23 -03:00
Maurício Meneghini Fauth
95fdd35e2f
Remove the .pma-table CSS class
Replaces with equivalent Bootstrap classes.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-15 17:16:22 -03:00
Maurício Meneghini Fauth
8d0c2a339c
Move both operands of an assignment to the same line
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-04-20 22:35:21 -03:00
William Desportes
993a6aa8a0
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-23 01:13:58 +01:00
William Desportes
2885bbca99
Fix #14430 - Execute button is disabled for routines
Allow the procedure definer to the procedure

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-23 00:29:00 +01:00
William Desportes
157be3004d
Do not query twice to ask about "CREATE ROUTINE" privs
They do not change between calls, store the value then.

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-23 00:05:03 +01:00
Brittany Barnes
dc1be997c9
Converted getExecuteform to utilize twig template (#16712)
Signed-off-by: Britt Barnes <britbarnes92@gmail.com>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-19 15:23:27 -03:00
Maurício Meneghini Fauth
d83abf63e7
Use PSR-12 for control structures spacing
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 15:27:03 -03:00
Maurício Meneghini Fauth
0b8edc5bde
Use PSR-12 for namespace use statements
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 14:18:35 -03:00
William Desportes
1ac9a165e0
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-25 18:44:47 +01:00
William Desportes
c5155ecae9
Refactor field flags to use an object an not strpos
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-24 23:56:33 +01:00
Saksham Gupta
6f64a08906 Fix 13325 : Created procedure shows up in triggers and events and vice versa
Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Remove console.log

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Change variable name tableType

Signed-off-by: Saksham Gupta <shucon01@gmail.com>
2021-02-17 13:56:01 +05:30
William Desportes
54f09a8e9c
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-05 01:51:54 +01:00
William Desportes
2cac456ce2
Fix code comment typos
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-05 01:03:28 +01:00
Maurício Meneghini Fauth
65ca0c1b2c
Extract HTML from Database\Routines::getEditorForm method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-08 17:49:22 -03:00
Maurício Meneghini Fauth
5178f76f95
Move fieldset CSS style to the .pma-fieldset class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-12-28 19:46:40 -03:00
Maurício Meneghini Fauth
ac4bfaebe7
Remove some custom CSS utilities
Uses Bootstrap equivalents.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-12-26 20:05:03 -03:00
Maurício Meneghini Fauth
5bad0f74af
Use Bootstrap's table for db routines page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-30 23:04:48 -03:00
Maurício Meneghini Fauth
d23be36126
Fix some errors found by PHPStan and Psalm
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-26 15:20:44 -03:00
Maurício Meneghini Fauth
c64b77abe1
Move HTML's table CSS to the pma-table class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-16 16:36:16 -03:00
Maurício Meneghini Fauth
a83ec78ebf Make DatabaseInterface::isUserType method private
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-24 00:40:03 -03:00
Maurício Meneghini Fauth
c447bac98d Move Routines::main to the controller
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-02 23:13:31 -03:00
Rajat Jain
13aae49714 Added search in Routines.
Signed-off-by: Rajat Jain <rajatjain.ix@gmail.com>
2020-09-24 22:13:24 +05:30
Maurício Meneghini Fauth
ceac762e09 Remove pmaThemePath and pmaThemeImage PHP globals
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-02 10:57:57 -03:00
Maurício Meneghini Fauth
3f01cd8c13 Remove Message::display method
Related to https://github.com/phpmyadmin/phpmyadmin/issues/16258.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-20 19:43:46 -03:00
Maurício Meneghini Fauth
3b285ff17e Use identical operator for non-empty strings
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-10 18:06:29 -03:00
Maurício Meneghini Fauth
e81146e4b3 Remove useless return annotations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-07 10:30:27 -03:00
Maurício Meneghini Fauth
58eee2e371 Use early exit when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 21:46:12 -03:00
Maurício Meneghini Fauth
f4582e083e Use early exit when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
82c2964bb8 Remove useless elses
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 22:27:45 -03:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
9269d75fb4 Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 20:22:18 -03:00
Maurício Meneghini Fauth
80a45fa0ae Break too long lines
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-16 18:08:20 -03:00
William Desportes
1cc7f78012
Split part of the logic of getQueryFromRequest into processFunctionSpecificParameters
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-16 14:39:00 +02:00
William Desportes
f2d349df40
Split part of the logic of getQueryFromRequest into processParamsAndBuild
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-16 14:06:36 +02:00
William Desportes
7766f93904
Use variables to limit access to $_POST and improve code of getQueryFromRequest
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-16 13:40:38 +02:00
William Desportes
62eb1eaf95
Improve signature of getDataFromName
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-16 12:14:39 +02:00
Maurício Meneghini Fauth
8dd310fb6a Remove assignments in if conditions
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-16 01:35:19 -03:00
William Desportes
e9a3657a93
Move some code of handleExecuteRoutine into getQueriesFromRoutineForm
Ref: 178f6db302
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-16 00:45:35 +02:00
William Desportes
178f6db302
Split Database/Routines::handleExecute code into a function
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-16 00:04:50 +02:00
William Desportes
cc981860a7
Coding standard fixes and baselines updates
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-15 23:20:14 +02:00
William Desportes
fcd41f6c85
Remove some mysql extension assertions
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-15 22:17:58 +02:00
Maurício Meneghini Fauth
84139f4d51 Remove some useless variables
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-13 16:15:37 -03:00
Maurício Meneghini Fauth
a64393e7f5 Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-13 00:23:28 -03:00
William Desportes
b7af1364c6
Psalm auto fixes manualy reviewed and edited
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-04-28 23:18:59 +02:00
Maurício Meneghini Fauth
367df7b0a1 Remove Database\Routines::setGlobals method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-13 21:53:51 -03:00
Maurício Meneghini Fauth
1102bdfdb7 Move Rte classes to the Database namespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-13 18:26:47 -03:00