Commit Graph

80 Commits

Author SHA1 Message Date
Michal Čihař
5231649343 Merge commit 'cda4290749f10ed686bfb466b415e5e3a1c04fea' 2016-05-09 20:09:36 +02:00
Michal Čihař
d2dc9481d2 Fix possible path existence disclossure
On non released versions (where line counts are not precalculated) it
was possible to check for file existence due to limited checks for
supplied path.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-04-29 15:28:32 +02:00
Durgesh
0b64827930 Refactored url parmeters generating, Issue #11990
Signed-off-by: Durgesh <007durgesh219@gmail.com>
2016-02-22 14:36:41 +05:30
Michal Čihař
bfe0e8814e Merge branch 'QA_4_5' into QA_4_6 2016-02-12 10:08:07 +01:00
Michal Čihař
6566e94914 Correct content type for uploaded error reports
Fixes #11939

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-02-12 10:06:54 +01:00
Michal Čihař
55b317c699 Remove /*overload*/ prefix from mb_* calls
I believe this was temporary flagging to see which code is migrated and
can be safely removed now.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-04 16:35:28 +01:00
Hugues Peccatte
8baf7c4a8a Update PHPDoc.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-12-11 23:21:54 +01:00
Michal Čihař
95d10b8c1f Remove PMA_prettyPrint
It is no longer needed as JSON_PRETTY_PRINT is there since PHP 5.4 (and
we require 5.5).

Signed-off-by: Michal Čihař <michal@cihar.com>
2015-12-09 07:54:36 +01:00
Hugues Peccatte
7f8f34e89d Remove classes require_once.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:30:22 +02:00
Hugues Peccatte
0761fb1801 Rename classes files.
Rename classes.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:30:21 +02:00
Hugues Peccatte
f0ba28fc1d Set namespace on Advisor, Config, Console and Util classes.
Set namespace on DbQbe.
Set namespace to 'DbSearch'.
Split Advisor.class.php file.
Change Advisor namespace.
Rename DbQbe class and file.
Set namespace on DisplayResults.
Set namespace on Error.
Use namespace for ErrorHandler.
Add class autoloader.
Change ErrorHandler filename.
Remove some require.
Update Config namespace path.
Update PMA_Util to PMA\libraries\Util.
Rename Font and File classes files.
Use namespace for Footer.
Set namespace in all libraries classes.
Namespace OutputBuffering.
Export SubPartition.
Rename Partition file.
Namespace PDF.
Namespace RecentFavoriteTable.
Replace PMA_Response by Response and PMA_Message by Message.
Update uses and calls.
Fix unit tests.
Fix SqlParser autoload.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:22:52 +02:00
Michal Čihař
4b41406009 Use HTTPS to submit error reports
Signed-off-by: Michal Čihař <michal@cihar.com>
2015-08-19 07:49:45 +02:00
Dan Ungureanu
91b97fadc2 Remove unneeded closing tags.
Signed-off-by: Dan Ungureanu <udan1107@gmail.com>
2015-07-19 00:18:38 +03:00
Hugues Peccatte
ef16b1e358 Templating error report form.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-07-17 23:36:23 +02:00
Madhura Jayaratne
c64ed4ddcc Mark variable types
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-07-15 20:54:48 +05:30
Marc Delisle
75d9fd93a1 Merge branch 'QA_4_4' 2015-05-12 11:56:34 -04:00
Tom Sommer
50616659e1 Don't throw errors in case reports.phpmyadmin.net is down
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-05-12 11:54:21 -04:00
Madhura Jayaratne
3d85296d79 Spaces around assignments
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-04-27 18:06:36 +05:30
Hugues Peccatte
763707a72e Fix typos.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-01-04 15:19:09 +01:00
Tekin Birdüzen
bf486ccd1f Fixed typo in variable name
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-12-10 09:02:55 -05:00
Michal Čihař
61fcf215e5 Detect failure of curl_init
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-12-05 10:20:13 +01:00
Madhura Jayaratne
93366c8c24 Merge branch 'QA_4_2' into QA_4_3
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-11-20 21:44:53 +05:30
Madhura Jayaratne
b99b6b6672 bug #4595 [security] Path traversal can lead to leakage of line count
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-11-20 06:24:34 +05:30
Madhura Jayaratne
9364e2eee5 bug #4596 [security] XSS through exception stack
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-11-20 06:20:49 +05:30
Hugues Peccatte
fd7f02f929 Fix typos.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-11-02 14:33:41 +01:00
Hugues Peccatte
3de88162ff Replace PMA_String uses by mb_* calls.
Remove part of unused  variables.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-09-28 20:53:01 +02:00
Hugues Peccatte
5985894160 Fix typos.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-09-07 00:31:45 +02:00
Hugues Peccatte
9b77d746ab Mass modifications to use PMA_String.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-09-06 10:44:03 +02:00
chanaka
237b00cc00 Fixed some codesniffer errors
Signed-off-by: chanaka <chanaka@oneit.com.au>
2014-07-28 21:49:11 +05:30
Marc Delisle
864a80209a Handle possible execution path
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-07-23 06:49:38 -07:00
Michal Čihař
a01e065d55 Fix typo
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-24 09:30:55 +02:00
Michal Čihař
c04f7e86c6 Query string does not have to be present
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-24 09:06:06 +02:00
Michal Čihař
2cc58f0847 Handle error on top page
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-24 09:05:00 +02:00
Michal Čihař
60211dd027 Document problem in a code
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-24 09:03:49 +02:00
Ann + J.M
6b778e09d9 Fix coding style
Signed-off-by: Ann + J.M <phpMyAdmin@ZweiSteinSoft.de>
2014-06-22 16:34:34 +02:00
Dhananjay Nakrani
8b09aa7f76 Make Syntax compatible with php-5.3
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:55 +05:30
Dhananjay Nakrani
c00d1d5ef6 Change hardcoded indexing to dynamic one.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:55 +05:30
Dhananjay Nakrani
b2e3164441 Make return values of PMA_getReportData() consistent.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:54 +05:30
Dhananjay Nakrani
e37616adba Fix coding style issues.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:54 +05:30
Dhananjay Nakrani
0b9439a246 Make automatic php error report submission ('sendErrorReport'='always') aysnchronous. Stop infinite auto error reporting loop.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:54 +05:30
Dhananjay Nakrani
86b3f352a9 Stop false alarms (displaying prompts-reporting form and reporting for 'false' (user warnings) errors).
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:53 +05:30
Dhananjay Nakrani
ed564f4d63 Remove unnecessary code. A deliberate error & local error-reporting-server URL.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:53 +05:30
Dhananjay Nakrani
6d04bc17bc Send only backtrace (not displayBacktrace). Change getBacktrace to return first 'X' frames. Send stackhash too.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:53 +05:30
Dhananjay Nakrani
1ba7140be5 Send only(without HTML) error message string.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:52 +05:30
Dhananjay Nakrani
43e1aa5ce2 Fix Syntax errors.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:52 +05:30
Dhananjay Nakrani
e74cd6ec1d Report errors based on user preference. All the cases taken care of.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:52 +05:30
Michal Čihař
c17eea8dba Remove documentation for removed parameter
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-06 14:06:24 +02:00
Michal Čihař
3f21b2816f Get rid of overridable return type
Separate function for collecting the data from pretty printing it.

Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-06 13:26:41 +02:00
Sachith Hasaranga Seneviratne
4e28aa1a81 (Feature Request 1466)
Refactor PMA_Util::getLatestVersion() and PMA_sendErrorReport()
to further reuse curl_handle option setting code.

Signed-off-by: Sachith Seneviratne sachith500@gmail.com
2014-01-08 19:08:18 +05:30
Madhura Jayaratne
6335b10574 Fix coding style
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-01-08 14:35:15 +05:30