Commit Graph

21 Commits

Author SHA1 Message Date
Michal Čihař
b450e58dbb Remove require of libraries included in test bootstrap
There is no need to specify them in every test when we already do it
globally.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-12 16:43:16 +01:00
Michal Čihař
3565e4db79 Remove PMA_arrayMergeRecursive
It can be replaced with array_replace_recursive as of PHP 5.3, we
require PHP 5.5.

Signed-off-by: Michal Čihař <michal@cihar.com>
2015-12-09 08:06:00 +01:00
Michal Čihař
06bb1e67f2 Remove PMA_arrayWalkRecursive
For the single remaining use case native array_walk_recursive is good
enoug.

Signed-off-by: Michal Čihař <michal@cihar.com>
2015-12-09 07:42:13 +01:00
Marc Delisle
2a7f1ed42e Remove code duplication
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-02-14 06:12:53 -05:00
Michal Čihař
a3e05a32ef Add test for double call of PMA_arrayWalkRecursive
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-04-10 13:30:44 +02:00
Hugues Peccatte
c38b78defb PHPCS updates.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-03-15 11:46:16 +01:00
Jeff Chan
896fe8169a Fix PMA_arrayWalkRecursive to ensure single pass thru keys
Fix a bug with PMA_arrayWalkRecursive that causes it to apply a function
to its keys/values more than once. A previously incorrect test is fixed
as well.

The bug happens because when keys are modified, PHP's foreach loops
through the new keys again. This does not usually happen unless the
iterating array is passed through by reference (or has refcount=1).
See: http://stackoverflow.com/a/14854568/791890

Please see #936 for full explanation.

Signed-off-by: Jeff Chan <jefftchan@gmail.com>
2014-02-17 03:09:34 +00:00
Hugues Peccatte
32a6150272 Fix PHPCS new errors.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2013-12-09 08:09:42 +01:00
Hugues Peccatte
b76f616079 Fix unit test.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2013-12-08 11:16:07 +01:00
Hugues Peccatte
226ae34061 New unit tests.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2013-12-07 20:01:49 +01:00
Michal Čihař
778369595c Simplify test method name, no need to repeat class name 2013-10-02 13:37:21 +02:00
Michal Čihař
4382c7385c Wrap some long lines 2013-05-02 16:03:51 +02:00
Michal Čihař
92c76b9630 Various class name improvements in testsuite 2013-05-02 15:57:09 +02:00
Madhura Jayaratne
3849390b8b Fix function name: PMA_array_merge_recursive -> PMA_arrayMergeRecursive 2012-06-01 21:57:07 +05:30
Madhura Jayaratne
381ae7b85a Fix function name: PMA_array_read -> PMA_arrayRead 2012-06-01 21:46:31 +05:30
Madhura Jayaratne
0a595f1f54 Fix function name: PMA_array_write -> PMA_arrayWrite 2012-06-01 21:44:33 +05:30
Madhura Jayaratne
ddc575ca04 Fix function name: PMA_array_remove -> PMA_arrayRemove 2012-06-01 21:41:59 +05:30
Michal Čihař
e56949f160 Use package name PhpMyAdmin
Needed to match phpdoc rules as package name must begin with upper case.
2011-10-25 10:13:17 +02:00
Madhura Jayaratne
13adb5adf7 Use lower case for true, false and null 2011-09-23 11:11:41 +05:30
Madhura Jayaratne
e67a0a2531 Spaces between parameters in function calls 2011-09-23 08:43:41 +05:30
Zarubin Stas
f7d7102d2f - Unit Test grouped by library directory
- Added configuration file phpunit.xml.dist and bootstraper-dist.php
 - Ignoring phpunit.xml, bootstraper.php and build/
2011-06-29 20:06:27 +03:00