Commit Graph

287 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
1c084de30b
Fix coding standard errors
Related to 62f142c9fa.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-03 16:50:33 -03:00
Maurício Meneghini Fauth
e376c4189b
Remove the .pma-fieldset from some pages
Replaces with Bootstrap's cards

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-27 18:18:23 -03:00
Maurício Meneghini Fauth
b9464bdd1b
Extract the HTML from the Triggers::getEditorForm method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-27 15:44:21 -03:00
Maurício Meneghini Fauth
bfc93d8e6f
Extract the HTML from Database\Triggers::export method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-27 14:26:58 -03:00
Maurício Meneghini Fauth
95fdd35e2f
Remove the .pma-table CSS class
Replaces with equivalent Bootstrap classes.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-15 17:16:22 -03:00
William Desportes
77b5e402c5
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-05-11 01:20:20 +02:00
Liviu-Mihail Concioiu
1c8f9b4d23 Replace secure.php.net with www.php.net and remove Polish and Persian from PHP documentation
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
2021-04-26 14:32:03 +02:00
Maurício Meneghini Fauth
8d0c2a339c
Move both operands of an assignment to the same line
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-04-20 22:35:21 -03:00
William Desportes
8fbb01a684
Merge branch 'origin/QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-04-19 21:51:45 +02:00
Maurício Meneghini Fauth
59e4dae52a
Remove invalid inline doc comments
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-04-18 14:49:28 -03:00
Maurício Meneghini Fauth
cb55bdbaf7
Rename Database\Qbe class variables to use camel case
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-04-18 13:01:37 -03:00
Fawzi E. Abdulfattah
a4b7bbb334 support RTL mode - Designer
Signed-off-by: Fawzi E. Abdulfattah <iifawzie@gmail.com>
2021-04-16 00:02:53 +02:00
William Desportes
993a6aa8a0
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-23 01:13:58 +01:00
William Desportes
2885bbca99
Fix #14430 - Execute button is disabled for routines
Allow the procedure definer to the procedure

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-23 00:29:00 +01:00
William Desportes
157be3004d
Do not query twice to ask about "CREATE ROUTINE" privs
They do not change between calls, store the value then.

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-23 00:05:03 +01:00
William Desportes
c2bf51ea19
Fix #16694 - check privileges for triggers down to the table if possible
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-03-22 23:29:09 +01:00
Maurício Meneghini Fauth
caa3337411
Extract FK related methods from Util class
Creates the PhpMyAdmin\Utils\ForeignKey class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-21 15:25:45 -03:00
Brittany Barnes
dc1be997c9
Converted getExecuteform to utilize twig template (#16712)
Signed-off-by: Britt Barnes <britbarnes92@gmail.com>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-19 15:23:27 -03:00
Maurício Meneghini Fauth
d3ce67593d
Fix some errors found by PHPStan
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-09 17:22:03 -03:00
Maurício Meneghini Fauth
d83abf63e7
Use PSR-12 for control structures spacing
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 15:27:03 -03:00
Maurício Meneghini Fauth
0b8edc5bde
Use PSR-12 for namespace use statements
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-05 14:18:35 -03:00
William Desportes
1ac9a165e0
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-25 18:44:47 +01:00
William Desportes
c5155ecae9
Refactor field flags to use an object an not strpos
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-24 23:56:33 +01:00
Saksham Gupta
6f64a08906 Fix 13325 : Created procedure shows up in triggers and events and vice versa
Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Remove console.log

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Change variable name tableType

Signed-off-by: Saksham Gupta <shucon01@gmail.com>
2021-02-17 13:56:01 +05:30
William Desportes
54f09a8e9c
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-05 01:51:54 +01:00
William Desportes
2cac456ce2
Fix code comment typos
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-02-05 01:03:28 +01:00
Maurício Meneghini Fauth
1e5fbd57fc
Create Twig\AssetExtension and image Twig function
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-28 16:09:17 -03:00
Maurício Meneghini Fauth
05d1f0a0c8
Redesign the Triggers pages
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-23 18:07:02 -03:00
William Desportes
b0d10e7fa3
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-01-13 23:09:35 +01:00
Rouslan Placella
194dc4d5db Added IF EXISTS clause to DROP EVENT statement when editing event.
Fixes #16565.

Signed-off-by: Rouslan Placella <rouslan@placella.com>
2021-01-13 18:57:29 +00:00
Maurício Meneghini Fauth
65ca0c1b2c
Extract HTML from Database\Routines::getEditorForm method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-08 17:49:22 -03:00
William Desportes
0605f38d9a
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-12-31 23:31:51 +01:00
Paul Gomez
23e23e3b3b
Added "Build Query" button to Visual Query Builder #16485
There was a ```if not visual_builder ``` that kept it from displaying. I did a search to see if that value is supplied and what it would mean.

Signed-off-by: Paul Gomez <pauldro952@hotmail.com>
2020-12-31 23:22:50 +01:00
Maurício Meneghini Fauth
5178f76f95
Move fieldset CSS style to the .pma-fieldset class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-12-28 19:46:40 -03:00
Maurício Meneghini Fauth
ac4bfaebe7
Remove some custom CSS utilities
Uses Bootstrap equivalents.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-12-26 20:05:03 -03:00
William Desportes
fb5d6159af
Fix Doctum reported phpdoc errors
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-12-18 22:01:51 +01:00
William Desportes
70320f256b
Fix a "PHP Fatal error: Uncaught TypeError: rawurlencode" using sakila database
NOTICE: PHP message: PHP Fatal error:  Uncaught TypeError: rawurlencode(): Argument #1 ($string) must be of type string, int given in libraries/classes/Database/Designer/Common.php:141
Stack trace:
#0 libraries/classes/Database/Designer/Common.php(141): rawurlencode(1)
#1 libraries/classes/Controllers/Database/DesignerController.php(203): PhpMyAdmin\Database\Designer\Common->getScriptContr(Array)
#2 libraries/classes/Routing.php(92): PhpMyAdmin\Controllers\Database\DesignerController->index(Array)
#3 index.php(18): PhpMyAdmin\Routing::callControllerForRoute('/database/desig...', Object(FastRoute\Dispatcher\GroupCountBased), Object(Symfony\Component\DependencyInjection\ContainerBuilder))
#4 {main}
  thrown in libraries/classes/Database/Designer/Common.p...

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-12-07 01:20:53 +01:00
Maurício Meneghini Fauth
c698be7a70
Use Bootstrap's table for db triggers page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-30 23:04:49 -03:00
Maurício Meneghini Fauth
5bad0f74af
Use Bootstrap's table for db routines page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-30 23:04:48 -03:00
Maurício Meneghini Fauth
d23be36126
Fix some errors found by PHPStan and Psalm
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-26 15:20:44 -03:00
Maurício Meneghini Fauth
2f5f118ce5
Merge pull request #16486 from mauriciofauth/table-css
Add support for Bootstrap tables
2020-11-16 21:09:58 -03:00
Maurício Meneghini Fauth
c64b77abe1
Move HTML's table CSS to the pma-table class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-16 16:36:16 -03:00
William Desportes
ed0c44a621
Update files to follow new coding standard rules
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-11-16 19:36:52 +01:00
Maurício Meneghini Fauth
0a4b10ba5e
Remove toggle button generator
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-14 13:17:03 -03:00
Maurício Meneghini Fauth
a83ec78ebf Make DatabaseInterface::isUserType method private
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-24 00:40:03 -03:00
Maurício Meneghini Fauth
db3da81056 Remove some useless comments
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-13 19:56:56 -03:00
Maurício Meneghini Fauth
ac9bccf67d Replace $GLOBALS['dbi'] with global $dbi
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-11 09:24:21 -03:00
Maurício Meneghini Fauth
e66be179ca Use camel case naming for class members
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-05 10:37:07 -03:00
Maurício Meneghini Fauth
bb32ba6d9c Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-04 12:31:43 -03:00
Maurício Meneghini Fauth
c447bac98d Move Routines::main to the controller
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-02 23:13:31 -03:00